https://bugzilla.wikimedia.org/show_bug.cgi?id=34013
Web browser: ---
Bug #: 34013
Summary: "intro", "outro" and "default" query format issues
Product: MediaWiki extensions
Version: any
Platform: All
OS/Version: All
Status: NEW
Severity: normal
Priority: Unprioritized
Component: Semantic MediaWiki
AssignedTo: wikibugs-l@lists.wikimedia.org
ReportedBy: danwe...@web.de
CC: jeroen_ded...@yahoo.com, mar...@semantic-mediawiki.org
Classification: Unclassified
I think since Version 1.7 "intro", "outro" and "default" don't trim() their
values anymore before applying them.
This makes the replacement of "_" against " " useless. So either they should
trim() or the replacement should be omitted.
It would also be enough to just replace leading and tailing "_" but not those
in the middle.
There is also a replacement of "_" happening for the 'default' parameter, I
can't see why.
It might be worth re-thinking the whole concept of these parameters. On the
other hand, they are in use for a long time already and it might break stuff
changing their behavior more radically.
Anyway, there is also Bug 28075 which suggests to expand the 'default' only
when needed. I suggest doing the same for 'intro' and 'outro' and perhaps
moving the parameter handling to the parser functions instead of handling it
within the SMWResultPrinter.
'Intro' and 'Outro' are getting handled twice right now it seems, for one in
SMWQueryProcessor::getResultFromQuery() but also in SMWResultPrinter
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
