https://bugzilla.wikimedia.org/show_bug.cgi?id=34303
Jack Phoenix changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|
https://bugzilla.wikimedia.org/show_bug.cgi?id=34303
--- Comment #6 from Van de Bugger 2012-07-16 17:28:27
UTC ---
Hi,
I thought process is: If you committed the fix, please move it to RESOLVED
state. When I check the fix I will move record to VERIFIED state. Then you can
move it to CLOSED.
--
https://bugzilla.wikimedia.org/show_bug.cgi?id=34303
--- Comment #5 from Jack Phoenix 2012-07-15
16:20:17 UTC ---
Thanks for the patch Van, I've committed a patch based on yours to SVN in
r115613, which adds user rights checking to two AJAX functions, wfCommentSubmit
and wfCommentVote. Now the A
https://bugzilla.wikimedia.org/show_bug.cgi?id=34303
Mark A. Hershberger changed:
What|Removed |Added
Keywords|need-review |reviewed
Priority|Unpr
https://bugzilla.wikimedia.org/show_bug.cgi?id=34303
Mark A. Hershberger changed:
What|Removed |Added
CC||m...@everybody.org
--- Comment #
https://bugzilla.wikimedia.org/show_bug.cgi?id=34303
Sumana Harihareswara changed:
What|Removed |Added
Keywords||need-review, patch
https://bugzilla.wikimedia.org/show_bug.cgi?id=34303
--- Comment #2 from Van de Bugger 2012-02-09 19:31:47
UTC ---
Hmm... Similar issue for other conditions: checking conditions on UI side is
not enough. For example, hiding vote buttons at user's own messages is not
enough, server side should re
https://bugzilla.wikimedia.org/show_bug.cgi?id=34303
--- Comment #1 from Van de Bugger 2012-02-09 19:15:37
UTC ---
The same issue for voting. See the next function, wfCommentVote:
> // Blocked users cannot vote, obviously
> if( $wgUser->isBlocked() ) {
> return '';
> }
Must be
> // Block
