https://bugzilla.wikimedia.org/show_bug.cgi?id=34339
Web browser: ---
Bug #: 34339
Summary: ResourceLoader checks touched date twice for some
pages
Product: MediaWiki
Version: 1.19-svn
Platform: All
OS/Version: All
Status: NEW
Severity: normal
Priority: Unprioritized
Component: Resource Loader
AssignedTo: wikibugs-l@lists.wikimedia.org
ReportedBy: duplicate...@googlemail.com
CC: krinklem...@gmail.com, roan.katt...@gmail.com,
tpars...@wikimedia.org
Classification: Unclassified
For modules with js and css pages, the ResourceLoader is checking the touched
date twice for all pages of that module. The first time, when building the CSS
and the second time, when building the scripts.
For example:
SELECT page_namespace,page_title,page_touched FROM `page` WHERE (page_namespace
= '8' AND page_title IN
('Common.js','Common.css','Vector.js','Vector.css','Print.css') )
Callers:
MediaWiki::run/MediaWiki::main/MediaWiki::finalCleanup/OutputPage::output/SkinTemplate::outputPage/Skin::bottomScripts/OutputPage::getBottomScripts/OutputPage::getScriptsForBottomQueue/OutputPage::makeResourceLoaderLink/ResourceLoaderWikiModule::isKnownEmpty/ResourceLoaderWikiModule::getTitleMtimes/DatabaseBase::select
SELECT page_namespace,page_title,page_touched FROM `page` WHERE (page_namespace
= '8' AND page_title IN
('Common.js','Common.css','Vector.js','Vector.css','Print.css') )
Callers:
MediaWiki::run/MediaWiki::main/MediaWiki::finalCleanup/OutputPage::output/SkinTemplate::outputPage/OutputPage::headElement/OutputPage::buildCssLinks/OutputPage::makeResourceLoaderLink/ResourceLoaderWikiModule::isKnownEmpty/ResourceLoaderWikiModule::getTitleMtimes/DatabaseBase::select
This is the same for the group-*.js/.css pages
(ResourceLoaderUserGroupsModule).
When the module only contains css pages, there is only one select
(ResourceLoaderNoscriptModule)
So you have 5 queries for loggedin users. You can reduce this to 3, maybe
combine all to one query? When this is already done in the ResourceLoader2,
than mark this as FIXED.
Thanks.
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
