https://bugzilla.wikimedia.org/show_bug.cgi?id=34787
Web browser: --- Bug #: 34787 Summary: Sanity check before $wgHooks['UserLoadAfterLoadFromSession'] doesn't validate all the required settings Product: MediaWiki extensions Version: any Platform: All OS/Version: All Status: NEW Severity: minor Priority: Unprioritized Component: LdapAuthentication AssignedTo: rlan...@gmail.com ReportedBy: dam...@damianzaremba.co.uk CC: wikibugs-l@lists.wikimedia.org Classification: Unclassified Mobile Platform: --- Created attachment 10127 --> https://bugzilla.wikimedia.org/attachment.cgi?id=10127 Diff of changes The current sanity check which ensures that the wgLDAPAutoAuthUsername variable is set to something doesn't ensure that the wgLDAPAutoAuthDomain is set to something. If the wgLDAPAutoAuthDomain is not set and the hook is loaded, when the auth call runs it ends up generating a php warning and no debug output. The attached patch resolves the issue. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l