[Bug 42142] VisualEditor: Don't offer Edit button when user cannot edit page

2012-11-28 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=42142 --- Comment #6 from Krinkle krinklem...@gmail.com 2012-11-28 18:12:04 UTC --- That's not a problem I guess, but I noticed while implementing it that it was a matter of removing the code that explicitly ignored the presence of the edit button

[Bug 42142] VisualEditor: Don't offer Edit button when user cannot edit page

2012-11-28 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=42142 --- Comment #7 from James Forrester jforres...@wikimedia.org 2012-11-28 18:24:47 UTC --- Yeah, well, different protection levels for VE and non-VE editors feels like the wrong kind of solution. -- Configure bugmail:

[Bug 42142] VisualEditor: Don't offer Edit button when user cannot edit page

2012-11-28 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=42142 James Forrester jforres...@wikimedia.org changed: What|Removed |Added Status|ASSIGNED|RESOLVED

[Bug 42142] VisualEditor: Don't offer Edit button when user cannot edit page

2012-11-27 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=42142 --- Comment #4 from Krinkle krinklem...@gmail.com 2012-11-27 22:12:58 UTC --- I suppose the lazy solution (use the presence of a button outputted by server side) is sufficient, especially given that if someone games it, saving will still fail.

[Bug 42142] VisualEditor: Don't offer Edit button when user cannot edit page

2012-11-27 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=42142 --- Comment #5 from Krinkle krinklem...@gmail.com 2012-11-28 01:49:37 UTC --- If we do that it means we can no longer pseudo-restrict Edit source on a different level than VisualEditor Edit. e.g. on MediaWiki.org we protected the namespace

[Bug 42142] VisualEditor: Don't offer Edit button when user cannot edit page

2012-11-21 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=42142 James Forrester jforres...@wikimedia.org changed: What|Removed |Added AssignedTo|tpars...@wikimedia.org

[Bug 42142] VisualEditor: Don't offer Edit button when user cannot edit page

2012-11-16 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=42142 Roan Kattouw roan.katt...@gmail.com changed: What|Removed |Added Summary|VisualEditor: Stop user |VisualEditor:

[Bug 42142] VisualEditor: Don't offer Edit button when user cannot edit page

2012-11-16 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=42142 --- Comment #2 from Krinkle krinklem...@gmail.com 2012-11-17 03:49:58 UTC --- We have mw.user.getRights()[async] now in core as well. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this

[Bug 42142] VisualEditor: Don't offer Edit button when user cannot edit page

2012-11-16 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=42142 --- Comment #3 from Krinkle krinklem...@gmail.com 2012-11-17 03:51:14 UTC --- And for the current page, I suppose wgRestrictionEdit and wgUserGroups could be used. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email