https://bugzilla.wikimedia.org/show_bug.cgi?id=46615
Bartosz Dziewoński changed:
What|Removed |Added
Status|REOPENED|RESOLVED
Resolution|---
https://bugzilla.wikimedia.org/show_bug.cgi?id=46615
Bartosz Dziewoński changed:
What|Removed |Added
Version|1.21.0 |1.22-git
Assignee|wikib
https://bugzilla.wikimedia.org/show_bug.cgi?id=46615
--- Comment #15 from Gerrit Notification Bot ---
Change 64503 merged by jenkins-bot:
updateCollation.php: sanity check the collation before proceeding
https://gerrit.wikimedia.org/r/64503
--
You are receiving this mail because:
You are the a
https://bugzilla.wikimedia.org/show_bug.cgi?id=46615
--- Comment #14 from Gerrit Notification Bot ---
Related URL: https://gerrit.wikimedia.org/r/64503 (Gerrit Change
I77de040f97080653fe0d1734d38490eaa2d322db)
--
You are receiving this mail because:
You are the assignee for the bug.
You are on
https://bugzilla.wikimedia.org/show_bug.cgi?id=46615
--- Comment #13 from Bartosz Dziewoński ---
> (In reply to comment #9)
> > Tim wrote the code - can you explain? I suppose loading all the data
> > would be slow, but it's not like we're instantiating Collations left
> > and right.
>
> In the
https://bugzilla.wikimedia.org/show_bug.cgi?id=46615
--- Comment #12 from Tim Starling ---
(In reply to comment #5)
>(can I +2 a revert if its reverting code I +2'd in the first place)
Yes. I would have preferred it if you had done that instead of leaving the
maintenance script horribly broken f
https://bugzilla.wikimedia.org/show_bug.cgi?id=46615
--- Comment #11 from Gerrit Notification Bot ---
https://gerrit.wikimedia.org/r/57500 (Gerrit Change
Ib7b9597ff842a76185ba5c153922834ffb741237) | change APPROVED and MERGED [by Tim
Starling]
--
You are receiving this mail because:
You are the
https://bugzilla.wikimedia.org/show_bug.cgi?id=46615
--- Comment #10 from Platonides ---
What about changing $collation->getFirstLetterData(); to
$collation->getFirstLetter(); ?
On a IcuCollation, it will call getFirstLetterCount() which will load
getFirstLetterData(), but it's a member of Collat
https://bugzilla.wikimedia.org/show_bug.cgi?id=46615
Bartosz Dziewoński changed:
What|Removed |Added
Keywords|patch-in-gerrit |
Priority|High
https://bugzilla.wikimedia.org/show_bug.cgi?id=46615
--- Comment #8 from Bawolff (Brian Wolff) ---
The revert was meant as a temporary measure.
In this case maybe the constructor should be changed to throw an exception.
MatmaRex had previously tried to do that, at the time I didnt think it was a
https://bugzilla.wikimedia.org/show_bug.cgi?id=46615
--- Comment #7 from Platonides ---
Maybe we should wrap it in an if instanceof IcuCollation instead of reverting?
--
You are receiving this mail because:
You are watching all bug changes.
___
Wikibu
https://bugzilla.wikimedia.org/show_bug.cgi?id=46615
--- Comment #6 from Bawolff (Brian Wolff) ---
That's gerrit change Ib7b9597ff842a76185ba5c153922834ffb741237 for reference
--
You are receiving this mail because:
You are watching all bug changes.
_
https://bugzilla.wikimedia.org/show_bug.cgi?id=46615
--- Comment #5 from Bawolff (Brian Wolff) ---
Whoops that method isnt in the base class and i had only tested on uca
collations. I submitted a revert for now (can I +2 a revert if its reverting
code I +2'd in the first place)
--
You are recei
https://bugzilla.wikimedia.org/show_bug.cgi?id=46615
Platonides changed:
What|Removed |Added
Status|RESOLVED|REOPENED
CC|
https://bugzilla.wikimedia.org/show_bug.cgi?id=46615
Bawolff (Brian Wolff) changed:
What|Removed |Added
Status|ASSIGNED|RESOLVED
Resolution|--
https://bugzilla.wikimedia.org/show_bug.cgi?id=46615
jeremyb changed:
What|Removed |Added
CC||bugzilla+org.wikimedia@tuxm
https://bugzilla.wikimedia.org/show_bug.cgi?id=46615
Greg Grossmeier changed:
What|Removed |Added
Priority|Highest |High
--
You are receiving this mail
https://bugzilla.wikimedia.org/show_bug.cgi?id=46615
Greg Grossmeier changed:
What|Removed |Added
Priority|Unprioritized |Highest
CC|
https://bugzilla.wikimedia.org/show_bug.cgi?id=46615
--- Comment #2 from Bartosz Dziewoński ---
Basically, updateCollation didn't actually check if chosen collation is
supported by both the underlying ICU library and MediaWiki's list of
first-letters for this language, and so processed all the pa
https://bugzilla.wikimedia.org/show_bug.cgi?id=46615
Bartosz Dziewoński changed:
What|Removed |Added
Keywords||patch-in-gerrit
Statu
20 matches
Mail list logo
