[Bug 46887] Remove sleep from tests

https://bugzilla.wikimedia.org/show_bug.cgi?id=46887 Andre Klapper aklap...@wikimedia.org changed: What|Removed |Added Whiteboard|gci2013 |gci2014

[Bug 46887] Remove sleep from tests

https://bugzilla.wikimedia.org/show_bug.cgi?id=46887 Andre Klapper aklap...@wikimedia.org changed: What|Removed |Added Priority|Unprioritized |Low -- You are

[Bug 46887] Remove sleep from tests

https://bugzilla.wikimedia.org/show_bug.cgi?id=46887 --- Comment #18 from Andre Klapper aklap...@wikimedia.org --- Are there more tests containing sleep or is this fixed? Tony: Are you still working on this or should the assignee be reset to default? -- You are receiving this mail because: You

[Bug 46887] Remove sleep from tests

https://bugzilla.wikimedia.org/show_bug.cgi?id=46887 --- Comment #19 from Tony Thomas 01tonytho...@gmail.com --- (In reply to Andre Klapper from comment #18) Are there more tests containing sleep or is this fixed? Tony: Are you still working on this or should the assignee be reset to

[Bug 46887] Remove sleep from tests

https://bugzilla.wikimedia.org/show_bug.cgi?id=46887 Tony Thomas 01tonytho...@gmail.com changed: What|Removed |Added Assignee|01tonytho...@gmail.com

[Bug 46887] Remove sleep from tests

https://bugzilla.wikimedia.org/show_bug.cgi?id=46887 --- Comment #20 from Chris McMahon cmcma...@wikimedia.org --- We can keep this open. I actually just added a sleep to a test because I needed to get on with other things, and I should return to fix it at some point. -- You are receiving this

[Bug 46887] Remove sleep from tests

https://bugzilla.wikimedia.org/show_bug.cgi?id=46887 Andre Klapper aklap...@wikimedia.org changed: What|Removed |Added Status|PATCH_TO_REVIEW |NEW --- Comment

[Bug 46887] Remove sleep from tests

https://bugzilla.wikimedia.org/show_bug.cgi?id=46887 --- Comment #16 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 109471 merged by jenkins-bot: Removed sleep variable from TwnMainPage tests https://gerrit.wikimedia.org/r/109471 -- You are receiving this mail because: You

[Bug 46887] Remove sleep from tests

https://bugzilla.wikimedia.org/show_bug.cgi?id=46887 Nik Everett neverett+bugzi...@wikimedia.org changed: What|Removed |Added CC|

[Bug 46887] Remove sleep from tests

https://bugzilla.wikimedia.org/show_bug.cgi?id=46887 --- Comment #14 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 109471 had a related patch set uploaded by 01tonythomas: Removed sleep variable from TwnMainPage tests https://gerrit.wikimedia.org/r/109471 -- You are

[Bug 46887] Remove sleep from tests

https://bugzilla.wikimedia.org/show_bug.cgi?id=46887 Gerrit Notification Bot gerritad...@wikimedia.org changed: What|Removed |Added Status|ASSIGNED

[Bug 46887] Remove sleep from tests

https://bugzilla.wikimedia.org/show_bug.cgi?id=46887 --- Comment #10 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 108916 had a related patch set uploaded by Zfilipin: Replaced sleep with page-object gem waiting API https://gerrit.wikimedia.org/r/108916 -- You are receiving

[Bug 46887] Remove sleep from tests

https://bugzilla.wikimedia.org/show_bug.cgi?id=46887 --- Comment #11 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 108918 had a related patch set uploaded by 01tonythomas: Removed sleep with waiting API in browsertests https://gerrit.wikimedia.org/r/108918 -- You are

[Bug 46887] Remove sleep from tests

https://bugzilla.wikimedia.org/show_bug.cgi?id=46887 --- Comment #12 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 108918 merged by jenkins-bot: Removed sleep with waiting API in browsertests https://gerrit.wikimedia.org/r/108918 -- You are receiving this mail because: You

[Bug 46887] Remove sleep from tests

https://bugzilla.wikimedia.org/show_bug.cgi?id=46887 --- Comment #13 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 108916 merged by Cmcmahon: Replaced sleep with page-object gem waiting API https://gerrit.wikimedia.org/r/108916 -- You are receiving this mail because: You

[Bug 46887] Remove sleep from tests

https://bugzilla.wikimedia.org/show_bug.cgi?id=46887 --- Comment #8 from Željko Filipin zfili...@wikimedia.org --- Tony and I have paired on getting his environment set up to work on this. Tony, if you still are interested in working on this, feel free to assign the bug to yourself. Let me know

[Bug 46887] Remove sleep from tests

https://bugzilla.wikimedia.org/show_bug.cgi?id=46887 Tony Thomas 01tonytho...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED -- You

[Bug 46887] Remove sleep from tests

https://bugzilla.wikimedia.org/show_bug.cgi?id=46887 --- Comment #9 from Tony Thomas 01tonytho...@gmail.com --- (In reply to comment #8) Tony and I have paired on getting his environment set up to work on this. I will put my status in [QA] once I have made my environment ready. -- You are

[Bug 46887] Remove sleep from tests

https://bugzilla.wikimedia.org/show_bug.cgi?id=46887 Tony Thomas 01tonytho...@gmail.com changed: What|Removed |Added Assignee|wikibugs-l@lists.wikimedia.

[Bug 46887] Remove sleep from tests

https://bugzilla.wikimedia.org/show_bug.cgi?id=46887 --- Comment #7 from Željko Filipin zfili...@wikimedia.org --- Tony, if you need help getting started apply for Pair programming Friday for fun and profit: https://www.mediawiki.org/wiki/Pair_programming_Friday_for_fun_and_profit -- You are

[Bug 46887] Remove sleep from tests

https://bugzilla.wikimedia.org/show_bug.cgi?id=46887 Tony Thomas 01tonytho...@gmail.com changed: What|Removed |Added CC|

[Bug 46887] Remove sleep from tests

https://bugzilla.wikimedia.org/show_bug.cgi?id=46887 --- Comment #6 from Chris McMahon cmcma...@wikimedia.org --- Tony Thomas: just removing the code is not enough. The tests have to be made to wait properly for whatever it is they are waiting for. Using sleep() is either an interim step

[Bug 46887] Remove sleep from tests

https://bugzilla.wikimedia.org/show_bug.cgi?id=46887 Željko Filipin zfili...@wikimedia.org changed: What|Removed |Added Whiteboard||gci2013

[Bug 46887] Remove sleep from tests

https://bugzilla.wikimedia.org/show_bug.cgi?id=46887 --- Comment #4 from Željko Filipin zfili...@wikimedia.org --- If you need more information (and you probably do), feel free to ask questions here, at #wikimedia-qa freenode IRC channel or at QA mailing list:

[Bug 46887] Remove sleep from tests

https://bugzilla.wikimedia.org/show_bug.cgi?id=46887 --- Comment #2 from Željko Filipin zfili...@wikimedia.org --- There are more robust ways to wait for something to happen than using sleep: http://watirwebdriver.com/waiting/ https://github.com/cheezy/page-object/wiki/Ajax-Calls -- You are

[Bug 46887] Remove sleep from tests

https://bugzilla.wikimedia.org/show_bug.cgi?id=46887 --- Comment #3 from Željko Filipin zfili...@wikimedia.org --- Sleep statements found: browsertests https://github.com/wikimedia/qa-browsertests/blob/master/features/step_definitions/print_export_menu_steps.rb#L14

[Bug 46887] Remove sleep from tests

https://bugzilla.wikimedia.org/show_bug.cgi?id=46887 Željko Filipin zfili...@wikimedia.org changed: What|Removed |Added Summary|Remove sleep from |Remove sleep

[Bug 46887] Remove sleep from tests

https://bugzilla.wikimedia.org/show_bug.cgi?id=46887 --- Comment #1 from Željko Filipin zfili...@wikimedia.org --- We are using sleep in several places. Sleep is evil. We should remove it from all places. -- You are receiving this mail because: You are the assignee for the bug. You are on the