https://bugzilla.wikimedia.org/show_bug.cgi?id=47188
Web browser: ---
Bug ID: 47188
Summary: Echo + weird internal bots
Product: MediaWiki extensions
Version: master
Hardware: All
OS: All
Status: NEW
Severity: minor
Priority: Unprioritized
Component: Echo
Assignee: wikibugs-l@lists.wikimedia.org
Reporter: b...@mzmcbride.com
CC: agarr...@wikimedia.org, b...@mzmcbride.com,
bs...@wikimedia.org, kren...@gmail.com,
mflasc...@wikimedia.org, q...@wikimedia.org,
rkald...@wikimedia.org, s.mazel...@xs4all.nl
Classification: Unclassified
Mobile Platform: ---
Cloning this from bug 43701 (with particular focus on bug 43701 comment 14):
---
This is going to be a bit difficult to fix. The LinksUpdateAfterInsert hook
doesn't provide any access to the agent, nor does the function that calls the
hook, LinkUpdate::incrTableUpdate. I imagine the agent is abandoned further up
the chain somewhere. The way we're retrieving the agent right now is just
through the global $wgUser, which isn't reliable. I see 4 possible solutions:
1. pass the agent all the way through the chain from the article being saved to
the hook being executed (might be a pain)
2. Figure out how to get the jobqueue to properly set $wgUser for every action
it performs (probably a pain)
3. Don't include the agent in this notification. It's not really important in
this context anyway, which is why it isn't in the execution chain. Why would a
user care who performed the linking?
4. Don't include the agent in the notification if the agent is the jobqueue
(127.0.0.1). This will be a bit of a pain since we'll have to create a separate
notification type for this one edge case (since all the messages will need to
be different).
---
Bug 43701 seems to have been worked around (the relevant messages were
rewritten, effectively option 3), but I think the underlying issue is still
unresolved. Filing a new bug so this doesn't get lost, if there's still an
issue. If there's no longer an issue, feel free to mark this resolved.
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
