https://bugzilla.wikimedia.org/show_bug.cgi?id=52061
--- Comment #47 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 106861 restored by Legoktm:
Merge Poem extension into core
Reason:
I think this is a valuable changeset that should be pursued.
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061
Kunal Mehta (Legoktm) legoktm.wikipe...@gmail.com changed:
What|Removed |Added
CC|
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061
--- Comment #49 from James Forrester jforres...@wikimedia.org ---
(In reply to Kunal Mehta (Legoktm) from comment #48)
(In reply to Tpt from comment #45)
Yes, you have right with mw-lines.
I understand your concern with differing
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061
Nathan Larson nathanlarson3...@gmail.com changed:
What|Removed |Added
CC|
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061
--- Comment #51 from MZMcBride b...@mzmcbride.com ---
(In reply to comment #42)
(In reply to comment #38)
A Global Message Delivery to all Wikisource Scriptoriums/Village pump is
higly recommended
MZMcBride, could you advise how feasible
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061
Krinkle krinklem...@gmail.com changed:
What|Removed |Added
Status|PATCH_TO_REVIEW |NEW
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061
--- Comment #46 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 106861 abandoned by Krinkle:
Merge Poem extension into core
Reason:
Closing for now to clear pending review dashboard. Feel free to re-open when
you can work on
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061
Tpt thoma...@hotmail.fr changed:
What|Removed |Added
CC||thoma...@hotmail.fr
---
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061
--- Comment #44 from This, that and the other at.li...@live.com.au ---
That's a very good suggestion, Tpt. I would be inclined to call the CSS class
something more like mw-lines or similar, to comply with modern class naming
standards.
However
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061
--- Comment #45 from Tpt thoma...@hotmail.fr ---
Yes, you have right with mw-lines.
I understand your concern with differing functionality that would require two
buttons in the editing interface (it's the major concern I see). I think we
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061
--- Comment #42 from This, that and the other at.li...@live.com.au ---
(In reply to comment #37)
(In reply to comment #31)
1) In comment 29, Jesús Martínez Novo made a good suggestion to more widely
publicize the new lines name before it
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061
555 lugu...@gmail.com changed:
What|Removed |Added
Depends on||6810
--
You are receiving
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061
555 lugu...@gmail.com changed:
What|Removed |Added
CC||lugu...@gmail.com
--- Comment
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061
Bug 52061 depends on bug 6810, which changed state.
Bug 6810 Summary: create prose tag
https://bugzilla.wikimedia.org/show_bug.cgi?id=6810
What|Removed |Added
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061
--- Comment #39 from This, that and the other at.li...@live.com.au ---
(In reply to comment #38)
In the time that poem/ tag arised on Wikisources, we have also asked for a
prose/ tag (See bug 6810).
That is an entirely separate issue. The
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061
This, that and the other at.li...@live.com.au changed:
What|Removed |Added
Depends on|6810|
--
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061
--- Comment #40 from 555 lugu...@gmail.com ---
The poem/ tag usage on texts that does not contains poems, only the need to
parse line breaks in a different behaviour, isn't the feature itself provided
by the extension, only a very interesting
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061
--- Comment #41 from This, that and the other at.li...@live.com.au ---
(In reply to comment #40)
The poem/ tag usage on texts that does not contains poems, only the need to
parse line breaks in a different behaviour, isn't the feature itself
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061
--- Comment #36 from MZMcBride b...@mzmcbride.com ---
(In reply to comment #31)
1) In comment 29, Jesús Martínez Novo made a good suggestion to more widely
publicize the new lines name before it gets committed. We almost
inadvertently
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061
--- Comment #37 from This, that and the other at.li...@live.com.au ---
(In reply to comment #31)
1) In comment 29, Jesús Martínez Novo made a good suggestion to more widely
publicize the new lines name before it gets committed.
A mailing
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061
--- Comment #35 from Jesús Martínez Novo (Ciencia Al Poder)
martinezn...@gmail.com ---
Instead of finding similarities between poem and indent-pre, which is moot
since the indentation already breaks all markup that depends on being on the
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061
--- Comment #31 from C. Scott Ananian canan...@wikimedia.org ---
I think I just saved this patch from a premature +2.
I'd like to summarize what still needs to be done here:
1) In comment 29, Jesús Martínez Novo made a good suggestion to more
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061
--- Comment #32 from C. Scott Ananian canan...@wikimedia.org ---
I added a few more test cases to [[testwiki:bug 52061]] -- leading colons are
also parsed differently inside poem.
--
You are receiving this mail because:
You are on the CC list
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061
--- Comment #33 from C. Scott Ananian canan...@wikimedia.org ---
From chat:
(07:32:52 PM) subbu: i just checked the updated wiki page .. and hr and
colon-indents seem different in poem vs. indent-pre .. probably all wikitext
elements that
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061
--- Comment #34 from This, that and the other at.li...@live.com.au ---
(In reply to comment #31)
I'd like to resolve this discrepancy: I really really *really* don't want to
complicate the parser more with Yet Another Slightly Different Way
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061
--- Comment #27 from Michael M. listenle...@gmail.com ---
(In reply to comment #22)
(In reply to comment #16)
verbatim is a misleading name since it still parses wikitext in its
content.
It is only verbatim for text-content.
I do see
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061
--- Comment #28 from This, that and the other at.li...@live.com.au ---
I like lines, the name puts the focus on the individual lines of the
content, which is also what the tag is doing. Nice lateral thinking, Michael :)
--
You are receiving
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061
--- Comment #29 from Jesús Martínez Novo (Ciencia Al Poder)
martinezn...@gmail.com ---
lines sounds good, or preservelines
That said, maybe it would be more user friendly to use a mediawiki.org page to
discuss the tag name, so ideas can be
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061
--- Comment #30 from C. Scott Ananian canan...@wikimedia.org ---
Regarding my use of indent-pre above -- I'm looking at this mostly from the
perspective of parser maintenance. As [[testwiki:bug 52061]] demonstrates, the
desired behavior of
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061
ssas...@wikimedia.org changed:
What|Removed |Added
CC||ssas...@wikimedia.org
---
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061
--- Comment #17 from MZMcBride b...@mzmcbride.com ---
(In reply to comment #16)
From what I can tell, looking at output, this is indent-pre - indent +
CSS-class. Given that indent-pre provides all the formatting functionality, I
presume the
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061
--- Comment #19 from MZMcBride b...@mzmcbride.com ---
(In reply to comment #17)
I don't know what you mean by indent-pre.
Subbu clarified that this means the preceding space trick. I updated
[[testwiki:bug 52061]].
--
You are receiving this
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061
Jesús Martínez Novo (Ciencia Al Poder) martinezn...@gmail.com changed:
What|Removed |Added
CC|
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061
C. Scott Ananian canan...@wikimedia.org changed:
What|Removed |Added
CC|
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061
--- Comment #21 from ssas...@wikimedia.org ---
I agree reg. output being pre class='poem' .. /pre
However, maybe make it possible for the editor to provide a css-class rather
than hardcode class=poem into the tag?
For standard poem content,
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061
--- Comment #22 from This, that and the other at.li...@live.com.au ---
(In reply to comment #16)
verbatim is a misleading name since it still parses wikitext in its
content.
It is only verbatim for text-content.
I do see what you mean
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061
--- Comment #23 from ssas...@wikimedia.org ---
(In reply to comment #22)
(In reply to comment #20)
IMO the poem tag should be rendered as pre
class=poem and it has exactly the behavior of indent-pre (with an extra
HTML
class and
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061
--- Comment #24 from This, that and the other at.li...@live.com.au ---
What you are saying makes sense. Presumably the CSS for .poem would have to
neutralise the monospace/gray formatting normally applied to pre tags.
My main question is, if
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061
--- Comment #25 from ssas...@wikimedia.org ---
That is right reg. CSS.
Since this is going to be merged into core/php-parser, presumably, you control
this behavior and where in the parser pipeline the outer wrapping pre tag is
generated? I
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061
--- Comment #26 from This, that and the other at.li...@live.com.au ---
(In reply to comment #25)
Since this is going to be merged into core/php-parser, presumably, you
control
this behavior and where in the parser pipeline the outer wrapping
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061
Michael M. listenle...@gmail.com changed:
What|Removed |Added
CC|
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061
--- Comment #12 from This, that and the other at.li...@live.com.au ---
I'm wondering if people would prefer verbatim as the name of this tag?
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061
--- Comment #13 from Jackmcbarn jackmcbarn+w...@gmail.com ---
I'd also prefer verbatim as the name.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061
MZMcBride b...@mzmcbride.com changed:
What|Removed |Added
Whiteboard||migrate Poem extension
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061
MZMcBride b...@mzmcbride.com changed:
What|Removed |Added
Whiteboard|migrate Poem extension bugs |migrate Poem extension
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061
--- Comment #11 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 106861 had a related patch set uploaded by TTO:
Merge Poem extension into core
https://gerrit.wikimedia.org/r/106861
--
You are receiving this mail because:
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061
Gerrit Notification Bot gerritad...@wikimedia.org changed:
What|Removed |Added
Status|ASSIGNED
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061
--- Comment #9 from MZMcBride b...@mzmcbride.com ---
(In reply to comment #8)
I am thinking something like verbatim, asis (as is), nocollapse,
pretext/pre-text (as in pre but for text, not code), keepbreaks
[...]
Okay, I'll paint this
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061
--- Comment #10 from Ryan Kaldari rkald...@wikimedia.org ---
The compact feature has always seemed quite buggy (or at least bizarrely
unintuitive) and I wonder if we would really hurt much by killing it
altogether.
Regarding the tag name, is
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061
This, that and the other at.li...@live.com.au changed:
What|Removed |Added
Status|NEW
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061
Andre Klapper aklap...@wikimedia.org changed:
What|Removed |Added
Keywords|easy|
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061
Jack Phoenix j...@countervandalism.net changed:
What|Removed |Added
CC|
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061
Chad H. innocentkil...@gmail.com changed:
What|Removed |Added
CC|innocentkil...@gmail.com|
--- Comment #5
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061
--- Comment #6 from MZMcBride b...@mzmcbride.com ---
(In reply to comment #5)
If you merge it to core, please call it something other than poem. Other
than that I couldn't care less :D
I think we must keep the name poem for
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061
--- Comment #7 from Alex Monk kren...@gmail.com ---
(In reply to comment #6)
(In reply to comment #5)
If you merge it to core, please call it something other than poem. Other
than that I couldn't care less :D
I think we must keep the
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061
MZMcBride b...@mzmcbride.com changed:
What|Removed |Added
Keywords||easy
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061
MZMcBride b...@mzmcbride.com changed:
What|Removed |Added
Blocks||26751
--
You are
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061
Ryan Kaldari rkald...@wikimedia.org changed:
What|Removed |Added
Blocks||26751
--
You
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061
--- Comment #2 from MZMcBride b...@mzmcbride.com ---
(In reply to comment #1)
Anytime an extension is created or deprecated it's a logistical pain in the
ass.
Can you elaborate on this? It seems pretty easy to me.
--
You are receiving this
https://bugzilla.wikimedia.org/show_bug.cgi?id=52061
--- Comment #3 from Ryan Kaldari rkald...@wikimedia.org ---
Steps to deprecate an extension (apart from actual code changes):
* Turn off extension for testwiki in InitialiseSettings.php and make sure
nothing breaks (1 deployment cycle)
* Turn
60 matches
Mail list logo
