[Bug 52139] Write parserTests for fostered content

2013-08-27 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=52139 --- Comment #6 from ssas...@wikimedia.org --- https://gerrit.wikimedia.org/r/#/c/81429/ is one more example where our testing setup gets in the way of writing a whole bunch of tests to catch these errors early and also prevent regressions in

[Bug 52139] Write parserTests for fostered content

2013-08-16 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=52139 --- Comment #2 from C. Scott Ananian canan...@wikimedia.org --- I'll leave this for subbu to answer. Subbu: is exhaustive selser testing an adequate replacement for the tests that you've been doing manually to verify fostering fixes? -- You

[Bug 52139] Write parserTests for fostered content

2013-08-16 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=52139 --- Comment #3 from ssas...@wikimedia.org --- For this patchset, adding that snippet as a test and having selser changes generate a change could test this example. But, bug 51718 makes this harder because wt2wt will show a diff and fail the

[Bug 52139] Write parserTests for fostered content

2013-08-16 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=52139 --- Comment #4 from Gabriel Wicke gwi...@wikimedia.org --- Generating selser change permutations iteratively instead of with generate test as discussed in bug 50316 can make selser testing exhaustive. Are the gaps you are referring to in

[Bug 52139] Write parserTests for fostered content

2013-08-16 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=52139 --- Comment #5 from ssas...@wikimedia.org --- The kind of changes we can generate. The only changes that are currently generated are text-based. However, real edits add/insert/move dom-trees, not just text nodes. -- You are receiving this

[Bug 52139] Write parserTests for fostered content

2013-08-15 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=52139 Gabriel Wicke gwi...@wikimedia.org changed: What|Removed |Added Priority|Unprioritized |Normal ---