https://bugzilla.wikimedia.org/show_bug.cgi?id=53241
--- Comment #19 from Arlo Breault abrea...@wikimedia.org ---
Subbu, here's a comparison as requested in d),
https://gist.github.com/arlolra/6913667
So it's clear, in this case:
master is before that merge that just went in, so
https://bugzilla.wikimedia.org/show_bug.cgi?id=53241
Gerrit Notification Bot gerritad...@wikimedia.org changed:
What|Removed |Added
Status|REOPENED
https://bugzilla.wikimedia.org/show_bug.cgi?id=53241
--- Comment #20 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 88242 had a related patch set uploaded by Cscott:
Replace harmony-collections with es6-shim.
https://gerrit.wikimedia.org/r/88242
--
You are receiving this
https://bugzilla.wikimedia.org/show_bug.cgi?id=53241
--- Comment #21 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 88242 merged by jenkins-bot:
Replace harmony-collections with es6-shim
https://gerrit.wikimedia.org/r/88242
--
You are receiving this mail because:
You are on
https://bugzilla.wikimedia.org/show_bug.cgi?id=53241
Arlo Breault abrea...@wikimedia.org changed:
What|Removed |Added
Status|PATCH_TO_REVIEW |RESOLVED
https://bugzilla.wikimedia.org/show_bug.cgi?id=53241
--- Comment #17 from C. Scott Ananian canan...@wikimedia.org ---
wrt (b) https://github.com/cscott/es6-shim/tree/faster-map recovers the lost
speed:
$ time tests/parserTests.js --quiet
real0m38.924s
user0m38.896s
sys0m0.464s
--
https://bugzilla.wikimedia.org/show_bug.cgi?id=53241
--- Comment #18 from Arlo Breault abrea...@wikimedia.org ---
For a), this seems to be the largest culprit:
https://gerrit.wikimedia.org/r/88927
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugzilla.wikimedia.org/show_bug.cgi?id=53241
--- Comment #15 from C. Scott Ananian canan...@wikimedia.org ---
OK. I suggest moving to es6-shim. The codebase is much simpler.
Things left to do:
a) profile our code and figure out why we are creating so many different Set
objects during
https://bugzilla.wikimedia.org/show_bug.cgi?id=53241
--- Comment #16 from ssas...@wikimedia.org ---
Regarding (d), here is one possible page:
fr:Coupe_du_pays_de_Galles_de_football
See https://gist.github.com/subbuss/6876447 for some tests I did y'day morning.
--
You are receiving this mail
https://bugzilla.wikimedia.org/show_bug.cgi?id=53241
Gabriel Wicke gwi...@wikimedia.org changed:
What|Removed |Added
Status|RESOLVED|REOPENED
https://bugzilla.wikimedia.org/show_bug.cgi?id=53241
--- Comment #10 from C. Scott Ananian canan...@wikimedia.org ---
I've fixed the performance regression by patching harmony-collections.
I might also patch es6-shim to be O(1) so that would be another option.
--
You are receiving this mail
https://bugzilla.wikimedia.org/show_bug.cgi?id=53241
--- Comment #11 from Gabriel Wicke gwi...@wikimedia.org ---
(In reply to comment #10)
I've fixed the performance regression by patching harmony-collections.
I might also patch es6-shim to be O(1) so that would be another option.
Can you
https://bugzilla.wikimedia.org/show_bug.cgi?id=53241
--- Comment #12 from C. Scott Ananian canan...@wikimedia.org ---
$ node --version
v0.10.20
$ git checkout master
$ time tests/parserTests.js --quiet
real1m8.476s
user1m3.036s
sys0m0.628s
$ git checkout no-es6
$ time
https://bugzilla.wikimedia.org/show_bug.cgi?id=53241
--- Comment #13 from C. Scott Ananian canan...@wikimedia.org ---
With es6-shim (https://gerrit.wikimedia.org/r/88241 and
https://gerrit.wikimedia.org/r/88242 ):
$ time tests/parserTests.js --quiet
real0m46.265s
user0m46.228s
sys
https://bugzilla.wikimedia.org/show_bug.cgi?id=53241
--- Comment #14 from C. Scott Ananian canan...@wikimedia.org ---
(In reply to comment #13)
Don't know why exactly this is slower than the harmony-collections version; I
suspect it's due to the other stuff hacked by es6-shim. The actual
https://bugzilla.wikimedia.org/show_bug.cgi?id=53241
Arlo Breault abrea...@wikimedia.org changed:
What|Removed |Added
Status|PATCH_TO_REVIEW |RESOLVED
https://bugzilla.wikimedia.org/show_bug.cgi?id=53241
--- Comment #8 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 85432 merged by jenkins-bot:
ES6 shim cleanup
https://gerrit.wikimedia.org/r/85432
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugzilla.wikimedia.org/show_bug.cgi?id=53241
--- Comment #7 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 85432 had a related patch set uploaded by Arlolra:
WIP: ES6 shim cleanup.
https://gerrit.wikimedia.org/r/85432
--
You are receiving this mail because:
You are
https://bugzilla.wikimedia.org/show_bug.cgi?id=53241
Gerrit Notification Bot gerritad...@wikimedia.org changed:
What|Removed |Added
Status|NEW
https://bugzilla.wikimedia.org/show_bug.cgi?id=53241
--- Comment #6 from Gabriel Wicke gwi...@wikimedia.org ---
(In reply to comment #5)
The standard thunk is something like:
function Map() { this.store = Object.create(null); }
Map.prototype.get = function( k ) { return this.store['$'+k]; }
https://bugzilla.wikimedia.org/show_bug.cgi?id=53241
C. Scott Ananian canan...@wikimedia.org changed:
What|Removed |Added
CC|
https://bugzilla.wikimedia.org/show_bug.cgi?id=53241
Arlo Breault abrea...@wikimedia.org changed:
What|Removed |Added
CC|
https://bugzilla.wikimedia.org/show_bug.cgi?id=53241
Gabriel Wicke gwi...@wikimedia.org changed:
What|Removed |Added
Priority|Unprioritized |Normal
--
You
https://bugzilla.wikimedia.org/show_bug.cgi?id=53241
--- Comment #1 from Gabriel Wicke gwi...@wikimedia.org ---
Another contender: https://github.com/WebReflection/es6-collections
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugzilla.wikimedia.org/show_bug.cgi?id=53241
--- Comment #2 from Gabriel Wicke gwi...@wikimedia.org ---
(In reply to comment #1)
Another contender: https://github.com/WebReflection/es6-collections
This one uses linear search on a key array to support object keys. Search for
'function
https://bugzilla.wikimedia.org/show_bug.cgi?id=53241
--- Comment #3 from Gabriel Wicke gwi...@wikimedia.org ---
https://github.com/paulmillr/es6-shim/blob/master/es6-shim.js
uses iteration on a linked list in its Map implementation. Search for 'function
Map'.
--
You are receiving this mail
https://bugzilla.wikimedia.org/show_bug.cgi?id=53241
--- Comment #4 from Gabriel Wicke gwi...@wikimedia.org ---
https://github.com/Benvie/harmony-collections/blob/master/harmony-collections.js
seems to be the only one of the contenders so far that uses native objects for
primitive keys (and
27 matches
Mail list logo
