https://bugzilla.wikimedia.org/show_bug.cgi?id=53691
Jeff Hall changed:
What|Removed |Added
Status|PATCH_TO_REVIEW |RESOLVED
Resolution|---
https://bugzilla.wikimedia.org/show_bug.cgi?id=53691
--- Comment #29 from Gerrit Notification Bot ---
Change 111890 merged by jenkins-bot:
[Browser test] Headless browser test(s)
https://gerrit.wikimedia.org/r/111890
--
You are receiving this mail because:
You are on the CC list for the bug.
_
https://bugzilla.wikimedia.org/show_bug.cgi?id=53691
--- Comment #28 from Gerrit Notification Bot ---
Change 100797 abandoned by Hashar:
[browser test] Cucumber default profile for CI
Reason:
we are using something different than the ciwmf profile.
https://gerrit.wikimedia.org/r/100797
--
You
https://bugzilla.wikimedia.org/show_bug.cgi?id=53691
--- Comment #27 from Gerrit Notification Bot ---
Change 111890 had a related patch set uploaded by Jhall:
[Browser test] New test for headless browser testing on a fresh Mediawiki
install with VisualEditor.
https://gerrit.wikimedia.org/r/11189
https://bugzilla.wikimedia.org/show_bug.cgi?id=53691
--- Comment #26 from Gerrit Notification Bot ---
Change 110468 abandoned by Jhall:
[Browser test] WIP Headless test for VE verification on a fresh Mediawiki
install (as on Integration server).
Reason:
Abandoning this change since I'm going to
https://bugzilla.wikimedia.org/show_bug.cgi?id=53691
Bug 53691 depends on bug 60584, which changed state.
Bug 60584 Summary: Add support for running headless browser tests to
mediawiki-selenium Rubygem
https://bugzilla.wikimedia.org/show_bug.cgi?id=60584
What|Removed
https://bugzilla.wikimedia.org/show_bug.cgi?id=53691
--- Comment #25 from Gerrit Notification Bot ---
Change 110468 had a related patch set uploaded by Jhall:
[Browser test] WIP Headless test for VE verification on a fresh Mediawiki
install (as on Integration server).
https://gerrit.wikimedia.or
https://bugzilla.wikimedia.org/show_bug.cgi?id=53691
Gerrit Notification Bot changed:
What|Removed |Added
Status|ASSIGNED|PATCH_TO_REVIEW
--
You are
https://bugzilla.wikimedia.org/show_bug.cgi?id=53691
Jeff Hall changed:
What|Removed |Added
Status|NEW |ASSIGNED
--
You are receiving this mail b
https://bugzilla.wikimedia.org/show_bug.cgi?id=53691
--- Comment #24 from Gerrit Notification Bot ---
Change 102960 abandoned by Jhall:
[Browser test] WIP Modifications for PhantomJS compatibility
Reason:
Abandoning this patch since we have implemented support for headless browser
testing in the
https://bugzilla.wikimedia.org/show_bug.cgi?id=53691
--- Comment #23 from Jeff Hall ---
After some further investigation, we've decided to use the "headless" Rubygem
for headless browser testing, and we've decided to incorporate that support
into the mediawiki-selenium Rubygem so that it will be
https://bugzilla.wikimedia.org/show_bug.cgi?id=53691
Jeff Hall changed:
What|Removed |Added
Depends on||60584
--
You are receiving this mail beca
https://bugzilla.wikimedia.org/show_bug.cgi?id=53691
Jeff Hall changed:
What|Removed |Added
Depends on|60584 |
--
You are receiving this mail because:
https://bugzilla.wikimedia.org/show_bug.cgi?id=53691
Jeff Hall changed:
What|Removed |Added
Depends on||60584
--
You are receiving this mail beca
https://bugzilla.wikimedia.org/show_bug.cgi?id=53691
--- Comment #22 from Jeff Hall ---
Created attachment 14322
--> https://bugzilla.wikimedia.org/attachment.cgi?id=14322&action=edit
Scripts used to evaluate PhantomJS "bind" injection
After a pairing session with Željko, I went back to basics
https://bugzilla.wikimedia.org/show_bug.cgi?id=53691
Jeff Hall changed:
What|Removed |Added
Status|PATCH_TO_REVIEW |NEW
--- Comment #21 from Jeff Hall ---
Ch
https://bugzilla.wikimedia.org/show_bug.cgi?id=53691
--- Comment #20 from Gerrit Notification Bot ---
Change 102960 had a related patch set uploaded by Jhall:
[Browser test] WIP Modifications for PhantomJS compatibility
https://gerrit.wikimedia.org/r/102960
--
You are receiving this mail becau
https://bugzilla.wikimedia.org/show_bug.cgi?id=53691
--- Comment #19 from Jeff Hall ---
Timo pointed me in the right direction:
jeffrey-hall:browser jeffreyhall$ phantomjs
phantomjs> Function.prototype.bind
undefined
Turns out PhantomJS is built with an old version of JavaScriptCore that is
m
https://bugzilla.wikimedia.org/show_bug.cgi?id=53691
--- Comment #18 from Željko Filipin ---
Created attachment 14138
--> https://bugzilla.wikimedia.org/attachment.cgi?id=14138&action=edit
ve phantomjs
--
You are receiving this mail because:
You are on the CC list for the bug.
___
https://bugzilla.wikimedia.org/show_bug.cgi?id=53691
--- Comment #16 from Željko Filipin ---
Strange. I am pretty sure PhantomJS has JS. :)
But, this simple script takes screen shot that shows it can not load visual
editor.
require "watir-webdriver"
browser = Watir::Browser.new :phantomjs
brows
https://bugzilla.wikimedia.org/show_bug.cgi?id=53691
--- Comment #17 from Željko Filipin ---
Created attachment 14137
--> https://bugzilla.wikimedia.org/attachment.cgi?id=14137&action=edit
ve ff
--
You are receiving this mail because:
You are on the CC list for the bug.
__
https://bugzilla.wikimedia.org/show_bug.cgi?id=53691
James Forrester changed:
What|Removed |Added
CC||jforres...@wikimedia.org
--- Comment
https://bugzilla.wikimedia.org/show_bug.cgi?id=53691
--- Comment #14 from Jeff Hall ---
Ah, I believe Željko is correct - looks like VE has a whitelist in addition to
a blacklist. See section beginning on line 169 in this file:
https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FVisualEdito
https://bugzilla.wikimedia.org/show_bug.cgi?id=53691
--- Comment #13 from Željko Filipin ---
Created attachment 14130
--> https://bugzilla.wikimedia.org/attachment.cgi?id=14130&action=edit
phantomjs screen shot
--
You are receiving this mail because:
You are on the CC list for the bug.
__
https://bugzilla.wikimedia.org/show_bug.cgi?id=53691
--- Comment #12 from Željko Filipin ---
Looks like phantomjs is blacklisted (or not whitelisted). There is no visual
editor edit option (see screen shot).
--
You are receiving this mail because:
You are on the CC list for the bug.
___
https://bugzilla.wikimedia.org/show_bug.cgi?id=53691
--- Comment #11 from Jeff Hall ---
Looks like it's not a problem with PhantomJS being blacklisted, per the
VisualEditor browser blacklist which begins at line 890 of this file:
https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FVisualEdit
https://bugzilla.wikimedia.org/show_bug.cgi?id=53691
--- Comment #10 from Antoine "hashar" Musso ---
Could it be that phantomjs lack some javascript functionality that would cause
VisualEditor to disable itself ? Might be a browser whitelist as well.
Honestly, I have no clue how it is handled i
https://bugzilla.wikimedia.org/show_bug.cgi?id=53691
--- Comment #9 from Jeff Hall ---
Created attachment 14087
--> https://bugzilla.wikimedia.org/attachment.cgi?id=14087&action=edit
PhantomJS screenshot from VE editing mode URL
Thanks Željko. I tried modifying the "anon.feature" test to navi
https://bugzilla.wikimedia.org/show_bug.cgi?id=53691
--- Comment #8 from Željko Filipin ---
Created attachment 14080
--> https://bugzilla.wikimedia.org/attachment.cgi?id=14080&action=edit
phantomjs screen shot
--
You are receiving this mail because:
You are on the CC list for the bug.
___
https://bugzilla.wikimedia.org/show_bug.cgi?id=53691
--- Comment #7 from Željko Filipin ---
(In reply to comment #6)
> The test case currently does not work with PhantomJS, so I'll spend more time
> tomorrow trying to figure out why PhantomJS can't click into Visual Editor
> editing mode.
In pha
https://bugzilla.wikimedia.org/show_bug.cgi?id=53691
--- Comment #6 from Jeff Hall ---
I went ahead and amended the existing Gerrit ID:
https://gerrit.wikimedia.org/r/#/c/100797/
…with an additional anon test case that edits a random page (which will likely
always be the "Main Page" for a fresh
https://bugzilla.wikimedia.org/show_bug.cgi?id=53691
--- Comment #5 from Antoine "hashar" Musso ---
Jeff : sure, if you can get a test that roughly does:
- anonymous user
- go to main page
- press Edit (visual editor version)
- ensure visual editor is loaded
That would be a nice first step
https://bugzilla.wikimedia.org/show_bug.cgi?id=53691
--- Comment #4 from Jeff Hall ---
Sorry I wasn't able to get to work on this bug quickly Antoine - let me know if
you want me to work on creating a new browser test that will succeed in this
scenario (the existing anon test will fail since it p
https://bugzilla.wikimedia.org/show_bug.cgi?id=53691
--- Comment #3 from Antoine "hashar" Musso ---
And I manage to get VisualEditor + Parsoid to be setup automatically using
Jenkins. The related job configuration is pending in
https://gerrit.wikimedia.org/r/#/c/100800/ (need to be polished).
I
https://bugzilla.wikimedia.org/show_bug.cgi?id=53691
Gerrit Notification Bot changed:
What|Removed |Added
Status|NEW |PATCH_TO_REVIEW
--
You are
https://bugzilla.wikimedia.org/show_bug.cgi?id=53691
--- Comment #2 from Gerrit Notification Bot ---
Change 100797 had a related patch set uploaded by Hashar:
[browser test] cucumber default profile for CI
https://gerrit.wikimedia.org/r/100797
--
You are receiving this mail because:
You are on
https://bugzilla.wikimedia.org/show_bug.cgi?id=53691
Jeff Hall changed:
What|Removed |Added
Assignee|wikibugs-l@lists.wikimedia. |jh...@wikimedia.org
|org
https://bugzilla.wikimedia.org/show_bug.cgi?id=53691
Antoine "hashar" Musso changed:
What|Removed |Added
Blocks||53697
Depends on|5369
https://bugzilla.wikimedia.org/show_bug.cgi?id=53691
Antoine "hashar" Musso changed:
What|Removed |Added
See Also||https://bugzilla.wikimedia.
https://bugzilla.wikimedia.org/show_bug.cgi?id=53691
Antoine "hashar" Musso changed:
What|Removed |Added
Priority|Unprioritized |High
Summary|Trigg
40 matches
Mail list logo
