[Bug 55508] PHP CodeSniffer reports line length based on bytes, not on characters

2013-10-09 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=55508 --- Comment #1 from Antoine "hashar" Musso --- phpcs defaults to iso-8859-1 defined in PHP_CODESNIFFER_ENCODING CodeSniffer/Standards/Generic/Sniffs/Files/LineLengthSniff.php uses strlen(), whenever the encoding is not iso-8859-1 it would use:

[Bug 55508] PHP CodeSniffer reports line length based on bytes, not on characters

2013-10-09 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=55508 Siebrand Mazeland changed: What|Removed |Added CC||s.mazel...@xs4all.nl --- Comment #

[Bug 55508] PHP CodeSniffer reports line length based on bytes, not on characters

2013-10-09 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=55508 Gerrit Notification Bot changed: What|Removed |Added Status|NEW |PATCH_TO_REVIEW -- You are

[Bug 55508] PHP CodeSniffer reports line length based on bytes, not on characters

2013-10-09 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=55508 --- Comment #3 from Gerrit Notification Bot --- Change 88743 had a related patch set uploaded by Siebrand: Specify encoding of source files as utf-8 https://gerrit.wikimedia.org/r/88743 -- You are receiving this mail because: You are the ass

[Bug 55508] PHP CodeSniffer reports line length based on bytes, not on characters

2013-10-09 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=55508 --- Comment #4 from Gerrit Notification Bot --- Change 88743 merged by jenkins-bot: Specify encoding of source files as utf-8 https://gerrit.wikimedia.org/r/88743 -- You are receiving this mail because: You are the assignee for the bug. You

[Bug 55508] PHP CodeSniffer reports line length based on bytes, not on characters

2013-10-09 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=55508 --- Comment #5 from Krinkle --- Have the jobs been pushed? The change is merged but in https://integration.wikimedia.org/ci/job/mwext-VisualEditor-phpcs-HEAD/1524/console I don't see --encoding being passed. -- You are receiving this mail bec

[Bug 55508] PHP CodeSniffer reports line length based on bytes, not on characters

2013-10-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=55508 --- Comment #6 from Antoine "hashar" Musso --- (In reply to comment #5) > Have the jobs been pushed? The change is merged but in > https://integration.wikimedia.org/ci/job/mwext-VisualEditor-phpcs-HEAD/1524/ > console > I don't see --encoding b

[Bug 55508] PHP CodeSniffer reports line length based on bytes, not on characters

2013-10-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=55508 --- Comment #7 from Antoine "hashar" Musso --- All jobs got refreshed. That should fix the issue now, if that is actually the case I guess we can close the bug report. -- You are receiving this mail because: You are the assignee for the bug.

[Bug 55508] PHP CodeSniffer reports line length based on bytes, not on characters

2013-10-22 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=55508 Antoine "hashar" Musso changed: What|Removed |Added Status|PATCH_TO_REVIEW |RESOLVED Resolution|-

[Bug 55508] PHP CodeSniffer reports line length based on bytes, not on characters

2013-10-22 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=55508 Antoine "hashar" Musso changed: What|Removed |Added Priority|Unprioritized |Normal Assignee|wik