https://bugzilla.wikimedia.org/show_bug.cgi?id=57458
--- Comment #16 from Tisza Gergő gti...@wikimedia.org ---
*** Bug 66652 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugzilla.wikimedia.org/show_bug.cgi?id=57458
Gerrit Notification Bot gerritad...@wikimedia.org changed:
What|Removed |Added
Status|REOPENED
https://bugzilla.wikimedia.org/show_bug.cgi?id=57458
--- Comment #13 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 155901 had a related patch set uploaded by TheDJ:
TemplateParser: Fix whitespace trim
https://gerrit.wikimedia.org/r/155901
--
You are receiving this mail
https://bugzilla.wikimedia.org/show_bug.cgi?id=57458
--- Comment #14 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 155901 merged by jenkins-bot:
TemplateParser: Fix whitespace trim
https://gerrit.wikimedia.org/r/155901
--
You are receiving this mail because:
You are on the
https://bugzilla.wikimedia.org/show_bug.cgi?id=57458
Tisza Gergő gti...@wikimedia.org changed:
What|Removed |Added
Status|PATCH_TO_REVIEW |RESOLVED
https://bugzilla.wikimedia.org/show_bug.cgi?id=57458
Tisza Gergő gti...@wikimedia.org changed:
What|Removed |Added
CC|
https://bugzilla.wikimedia.org/show_bug.cgi?id=57458
--- Comment #9 from Lupo lupo.bugzi...@gmail.com ---
As stated in bug 69497, these newlines are in the license template, and the
code doing the HTML scraping there had better remove them.
--
You are receiving this mail because:
You are on the
https://bugzilla.wikimedia.org/show_bug.cgi?id=57458
--- Comment #10 from Tisza Gergő gti...@wikimedia.org ---
The code to remove is in
https://gerrit.wikimedia.org/r/#/c/120948/1/TemplateParser.php which at a
glance seems correct to me. Also, Lokal_Profil is right that the newline is not
always
https://bugzilla.wikimedia.org/show_bug.cgi?id=57458
--- Comment #11 from Lupo lupo.bugzi...@gmail.com ---
This code does _not_ look good. '/^\s+(.*)\s+$/' is wrong. It fails to trim if
there are no leading blanks (or no trailing blanks). And watch out for the
greedy (.*), that also looks wrong.
https://bugzilla.wikimedia.org/show_bug.cgi?id=57458
--- Comment #12 from Lupo lupo.bugzi...@gmail.com ---
(In reply to Tisza Gergő from comment #10)
Also, Lokal_Profil is right that the newline is
not always present in the HTML code. I'll test locally with the examples
mentioned here.
Not
https://bugzilla.wikimedia.org/show_bug.cgi?id=57458
--- Comment #7 from Lokal_Profil lokal_pro...@hotmail.com ---
Looking at the html source of the example above [1] there is no trace of these
newline characters. Hence it might not be a cleaning/trimming issue in the
TemplateParser but rather
https://bugzilla.wikimedia.org/show_bug.cgi?id=57458
Lokal_Profil lokal_pro...@hotmail.com changed:
What|Removed |Added
Status|RESOLVED|REOPENED
https://bugzilla.wikimedia.org/show_bug.cgi?id=57458
Lokal_Profil lokal_pro...@hotmail.com changed:
What|Removed |Added
See Also|
https://bugzilla.wikimedia.org/show_bug.cgi?id=57458
--- Comment #5 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 120948 merged by jenkins-bot:
Clean parsed HTML
https://gerrit.wikimedia.org/r/120948
--
You are receiving this mail because:
You are on the CC list for the
https://bugzilla.wikimedia.org/show_bug.cgi?id=57458
Tisza Gergő gti...@wikimedia.org changed:
What|Removed |Added
Status|PATCH_TO_REVIEW |RESOLVED
https://bugzilla.wikimedia.org/show_bug.cgi?id=57458
--- Comment #4 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 120948 had a related patch set uploaded by Gergő Tisza:
Clean parsed HTML
https://gerrit.wikimedia.org/r/120948
--
You are receiving this mail because:
You are
https://bugzilla.wikimedia.org/show_bug.cgi?id=57458
--- Comment #3 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 97743 abandoned by Gergő Tisza:
Trim HTML-based metadata values
Reason:
Abandoning this change since InformationParser has been completely rewritten in
the
https://bugzilla.wikimedia.org/show_bug.cgi?id=57458
Gerrit Notification Bot gerritad...@wikimedia.org changed:
What|Removed |Added
Status|ASSIGNED
https://bugzilla.wikimedia.org/show_bug.cgi?id=57458
--- Comment #2 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 97743 had a related patch set uploaded by Gergő Tisza:
Trim HTML-based metadata values
https://gerrit.wikimedia.org/r/97743
--
You are receiving this mail
https://bugzilla.wikimedia.org/show_bug.cgi?id=57458
Tisza Gergő gti...@wikimedia.org changed:
What|Removed |Added
Status|NEW |ASSIGNED
https://bugzilla.wikimedia.org/show_bug.cgi?id=57458
Jean-Fred jeanfrederic.w...@gmail.com changed:
What|Removed |Added
Summary|Incorrect URL for CC|'\n' are added
https://bugzilla.wikimedia.org/show_bug.cgi?id=57458
--- Comment #1 from Jean-Fred jeanfrederic.w...@gmail.com ---
Looking more around, '\n' are added to several values:
See
22 matches
Mail list logo
