https://bugzilla.wikimedia.org/show_bug.cgi?id=61440
Bartosz Dziewoński changed:
What|Removed |Added
CC||matma@gmail.com
--- Comment #
https://bugzilla.wikimedia.org/show_bug.cgi?id=61440
Gerrit Notification Bot changed:
What|Removed |Added
Status|NEW |PATCH_TO_REVIEW
--
You are
https://bugzilla.wikimedia.org/show_bug.cgi?id=61440
--- Comment #2 from Gerrit Notification Bot ---
Change 113667 had a related patch set uploaded by Nikerabbit:
Workaround for CSSJanus bug 61440
https://gerrit.wikimedia.org/r/113667
--
You are receiving this mail because:
You are the assigne
https://bugzilla.wikimedia.org/show_bug.cgi?id=61440
Niklas Laxström changed:
What|Removed |Added
Status|PATCH_TO_REVIEW |NEW
--
You are receiving this mail
https://bugzilla.wikimedia.org/show_bug.cgi?id=61440
--- Comment #3 from Gerrit Notification Bot ---
Change 113667 merged by jenkins-bot:
Workaround for CSSJanus bug 61440
https://gerrit.wikimedia.org/r/113667
--
You are receiving this mail because:
You are the assignee for the bug.
You are on
https://bugzilla.wikimedia.org/show_bug.cgi?id=61440
Andre Klapper changed:
What|Removed |Added
Priority|Unprioritized |Low
Version|unspecified
https://bugzilla.wikimedia.org/show_bug.cgi?id=61440
--- Comment #9 from Matthew Flaschen ---
Step 1 is done. It's fixed in the CSSJanus upstream node.js repository.
However, I realized we also need to do a node.js release and tag, since the PHP
version imports the tests by tag:
https://github.
https://bugzilla.wikimedia.org/show_bug.cgi?id=61440
Matthew Flaschen changed:
What|Removed |Added
CC||mflasc...@wikimedia.org
A
https://bugzilla.wikimedia.org/show_bug.cgi?id=61440
--- Comment #4 from Matthew Flaschen ---
Thanks, Bartosz. I submitted a fix
(https://github.com/cssjanus/php-cssjanus/pull/3) upstream using your regex
change. I also added a few tests.
--
You are receiving this mail because:
You are on the
https://bugzilla.wikimedia.org/show_bug.cgi?id=61440
Matthew Flaschen changed:
What|Removed |Added
Version|1.23.0 |1.25-git
--
You are receiving this
https://bugzilla.wikimedia.org/show_bug.cgi?id=61440
--- Comment #5 from Krinkle ---
Note that !important must never be used. It is a valid bug for upstream
CSSJanus (since it's valid CSS), but should not bare any relevance to code in
Wikimedia environments.
There is not a single valid use case
https://bugzilla.wikimedia.org/show_bug.cgi?id=61440
--- Comment #6 from Krinkle ---
Thanks Siebrand. I've put it here:
https://www.mediawiki.org/wiki/Manual:Coding_conventions/CSS#.21important
--
You are receiving this mail because:
You are on the CC list for the bug.
_
https://bugzilla.wikimedia.org/show_bug.cgi?id=61440
--- Comment #7 from Matthew Flaschen ---
(In reply to Krinkle from comment #5)
> To override a style, always use the same selector as the original style and
> you'll be fine.
That isn't appropriate in all cases. Say there are rules for a fooS
https://bugzilla.wikimedia.org/show_bug.cgi?id=61440
--- Comment #8 from Krinkle ---
(In reply to Matthew Flaschen from comment #7)
> (In reply to Krinkle from comment #5)
> > To override a style, always use the same selector as the original style and
> > you'll be fine.
>
> That isn't appropria
https://bugzilla.wikimedia.org/show_bug.cgi?id=61440
Kunal Mehta (Legoktm) changed:
What|Removed |Added
Keywords||upstream
CC|
https://bugzilla.wikimedia.org/show_bug.cgi?id=61440
Bartosz Dziewoński changed:
What|Removed |Added
See Also||https://github.com/cssjanus
16 matches
Mail list logo