[Bug 63742] Make the app pass checkstyle cleanly

2014-08-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=63742 --- Comment #73 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 126114 abandoned by Dbrant: Rename static variables to match ALL_CAPS_SHOUT https://gerrit.wikimedia.org/r/126114 -- You are receiving this mail because: You

[Bug 63742] Make the app pass checkstyle cleanly

2014-08-04 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=63742 Dmitry Brant dbr...@wikimedia.org changed: What|Removed |Added Status|PATCH_TO_REVIEW |RESOLVED

[Bug 63742] Make the app pass checkstyle cleanly

2014-05-20 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=63742 --- Comment #67 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 134365 had a related patch set uploaded by Anirudh24seven: Move + symbols to the next line. This will fix the OperatorWrapCheck warning.

[Bug 63742] Make the app pass checkstyle cleanly

2014-05-20 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=63742 --- Comment #68 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 134365 merged by jenkins-bot: Move + symbols to the next line. This will fix the OperatorWrapCheck warning. https://gerrit.wikimedia.org/r/134365 -- You are

[Bug 63742] Make the app pass checkstyle cleanly

2014-05-20 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=63742 --- Comment #69 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 134382 had a related patch set uploaded by Anirudh24seven: Use Java-style Array brackets https://gerrit.wikimedia.org/r/134382 -- You are receiving this mail

[Bug 63742] Make the app pass checkstyle cleanly

2014-05-20 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=63742 --- Comment #70 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 134381 had a related patch set uploaded by Yuvipanda: Remove unused imports https://gerrit.wikimedia.org/r/134381 -- You are receiving this mail because: You

[Bug 63742] Make the app pass checkstyle cleanly

2014-05-20 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=63742 --- Comment #71 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 134381 merged by jenkins-bot: Remove unused imports https://gerrit.wikimedia.org/r/134381 -- You are receiving this mail because: You are the assignee for the

[Bug 63742] Make the app pass checkstyle cleanly

2014-05-20 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=63742 --- Comment #72 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 134382 merged by jenkins-bot: Use Java-style Array brackets https://gerrit.wikimedia.org/r/134382 -- You are receiving this mail because: You are the assignee

[Bug 63742] Make the app pass checkstyle cleanly

2014-04-16 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=63742 --- Comment #63 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 126237 had a related patch set uploaded by Yuvipanda: Make magic numbers unmagical https://gerrit.wikimedia.org/r/126237 -- You are receiving this mail

[Bug 63742] Make the app pass checkstyle cleanly

2014-04-16 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=63742 --- Comment #64 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 126156 merged by Brion VIBBER: Fix FieldHidden warnings turn off warnings for params https://gerrit.wikimedia.org/r/126156 -- You are receiving this mail

[Bug 63742] Make the app pass checkstyle cleanly

2014-04-16 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=63742 --- Comment #65 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 126237 merged by Brion VIBBER: Make magic numbers unmagical https://gerrit.wikimedia.org/r/126237 -- You are receiving this mail because: You are the assignee

[Bug 63742] Make the app pass checkstyle cleanly

2014-04-16 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=63742 --- Comment #66 from Yuvi Panda yuvipa...@gmail.com --- Down to 50 errors!!1 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___

[Bug 63742] Make the app pass checkstyle cleanly

2014-04-15 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=63742 --- Comment #43 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 126068 had a related patch set uploaded by Yuvipanda: Do not enforce spacing around curly braces https://gerrit.wikimedia.org/r/126068 -- You are receiving

[Bug 63742] Make the app pass checkstyle cleanly

2014-04-15 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=63742 --- Comment #44 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 126068 merged by jenkins-bot: Do not enforce spacing around curly braces https://gerrit.wikimedia.org/r/126068 -- You are receiving this mail because: You are

[Bug 63742] Make the app pass checkstyle cleanly

2014-04-15 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=63742 --- Comment #45 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 126086 had a related patch set uploaded by Yuvipanda: Fix checkstyle.xml to work on older checkstyles https://gerrit.wikimedia.org/r/126086 -- You are

[Bug 63742] Make the app pass checkstyle cleanly

2014-04-15 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=63742 --- Comment #46 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 126086 merged by jenkins-bot: Fix checkstyle.xml to work on older checkstyles https://gerrit.wikimedia.org/r/126086 -- You are receiving this mail because: You

[Bug 63742] Make the app pass checkstyle cleanly

2014-04-15 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=63742 --- Comment #47 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 126112 had a related patch set uploaded by Yuvipanda: Add spaces where required to match checkstyle. https://gerrit.wikimedia.org/r/126112 -- You are receiving

[Bug 63742] Make the app pass checkstyle cleanly

2014-04-15 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=63742 --- Comment #48 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 126113 had a related patch set uploaded by Yuvipanda: Fix ordering of class definition modifier https://gerrit.wikimedia.org/r/126113 -- You are receiving this

[Bug 63742] Make the app pass checkstyle cleanly

2014-04-15 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=63742 --- Comment #49 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 126114 had a related patch set uploaded by Yuvipanda: Rename static variables to match ALL_CAPS_SHOUT https://gerrit.wikimedia.org/r/126114 -- You are

[Bug 63742] Make the app pass checkstyle cleanly

2014-04-15 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=63742 --- Comment #50 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 126116 had a related patch set uploaded by Yuvipanda: Make sure all switches have a default case https://gerrit.wikimedia.org/r/126116 -- You are receiving

[Bug 63742] Make the app pass checkstyle cleanly

2014-04-15 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=63742 --- Comment #51 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 126112 merged by Brion VIBBER: Add spaces where required to match checkstyle. https://gerrit.wikimedia.org/r/126112 -- You are receiving this mail because: You

[Bug 63742] Make the app pass checkstyle cleanly

2014-04-15 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=63742 --- Comment #52 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 126113 merged by Brion VIBBER: Fix ordering of class definition modifier https://gerrit.wikimedia.org/r/126113 -- You are receiving this mail because: You are

[Bug 63742] Make the app pass checkstyle cleanly

2014-04-15 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=63742 --- Comment #53 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 126120 had a related patch set uploaded by Yuvipanda: Ignore setter and constructors for HiddenFieldCheck https://gerrit.wikimedia.org/r/126120 -- You are

[Bug 63742] Make the app pass checkstyle cleanly

2014-04-15 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=63742 --- Comment #54 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 126128 had a related patch set uploaded by Yuvipanda: Don't count blocks as empty if they have comments in them https://gerrit.wikimedia.org/r/126128 -- You

[Bug 63742] Make the app pass checkstyle cleanly

2014-04-15 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=63742 --- Comment #55 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 126129 had a related patch set uploaded by Yuvipanda: Mark some uninheritable classes as final https://gerrit.wikimedia.org/r/126129 -- You are receiving this

[Bug 63742] Make the app pass checkstyle cleanly

2014-04-15 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=63742 --- Comment #57 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 126120 merged by Brion VIBBER: Ignore setter and constructors for HiddenFieldCheck https://gerrit.wikimedia.org/r/126120 -- You are receiving this mail

[Bug 63742] Make the app pass checkstyle cleanly

2014-04-15 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=63742 --- Comment #56 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 126116 merged by jenkins-bot: Make sure all switches have a default case https://gerrit.wikimedia.org/r/126116 -- You are receiving this mail because: You are

[Bug 63742] Make the app pass checkstyle cleanly

2014-04-15 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=63742 --- Comment #58 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 126135 had a related patch set uploaded by Yuvipanda: Refine Magic Number detection to ignore common numbers https://gerrit.wikimedia.org/r/126135 -- You are

[Bug 63742] Make the app pass checkstyle cleanly

2014-04-15 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=63742 --- Comment #59 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 126156 had a related patch set uploaded by Yuvipanda: Fix FieldHidden warnings turn off warnings for params https://gerrit.wikimedia.org/r/126156 -- You are

[Bug 63742] Make the app pass checkstyle cleanly

2014-04-15 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=63742 --- Comment #60 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 126128 merged by Brion VIBBER: Don't count blocks as empty if they have comments in them https://gerrit.wikimedia.org/r/126128 -- You are receiving this mail

[Bug 63742] Make the app pass checkstyle cleanly

2014-04-15 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=63742 --- Comment #61 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 126129 merged by Brion VIBBER: Mark some uninheritable classes as final https://gerrit.wikimedia.org/r/126129 -- You are receiving this mail because: You are

[Bug 63742] Make the app pass checkstyle cleanly

2014-04-15 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=63742 --- Comment #62 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 126135 merged by Brion VIBBER: Refine Magic Number detection to ignore common numbers https://gerrit.wikimedia.org/r/126135 -- You are receiving this mail

[Bug 63742] Make the app pass checkstyle cleanly

2014-04-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=63742 --- Comment #17 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 125002 merged by jenkins-bot: Ensure that there is always a space after a comma https://gerrit.wikimedia.org/r/125002 -- You are receiving this mail because:

[Bug 63742] Make the app pass checkstyle cleanly

2014-04-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=63742 --- Comment #19 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 124976 merged by jenkins-bot: Explicitly use braces everywhere https://gerrit.wikimedia.org/r/124976 -- You are receiving this mail because: You are the

[Bug 63742] Make the app pass checkstyle cleanly

2014-04-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=63742 --- Comment #18 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 124961 merged by jenkins-bot: Organize imports remove a redundant import https://gerrit.wikimedia.org/r/124961 -- You are receiving this mail because: You are

[Bug 63742] Make the app pass checkstyle cleanly

2014-04-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=63742 --- Comment #23 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 124988 merged by jenkins-bot: Make sure that all member variables are camelCase https://gerrit.wikimedia.org/r/124988 -- You are receiving this mail because:

[Bug 63742] Make the app pass checkstyle cleanly

2014-04-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=63742 --- Comment #20 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 124983 merged by jenkins-bot: Use Java style array declarations than C style https://gerrit.wikimedia.org/r/124983 -- You are receiving this mail because: You

[Bug 63742] Make the app pass checkstyle cleanly

2014-04-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=63742 --- Comment #22 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 124987 merged by jenkins-bot: Ensure that Utils class can't be instantiated https://gerrit.wikimedia.org/r/124987 -- You are receiving this mail because: You

[Bug 63742] Make the app pass checkstyle cleanly

2014-04-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=63742 --- Comment #21 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 124986 merged by jenkins-bot: Properly format multiline boolean checks to be more consistent https://gerrit.wikimedia.org/r/124986 -- You are receiving this

[Bug 63742] Make the app pass checkstyle cleanly

2014-04-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=63742 --- Comment #26 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 125000 merged by jenkins-bot: Ensure that all constants are named ALL_UPPERCASE https://gerrit.wikimedia.org/r/125000 -- You are receiving this mail because:

[Bug 63742] Make the app pass checkstyle cleanly

2014-04-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=63742 --- Comment #25 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 124996 merged by jenkins-bot: Remove redundant public and static modifiers https://gerrit.wikimedia.org/r/124996 -- You are receiving this mail because: You

[Bug 63742] Make the app pass checkstyle cleanly

2014-04-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=63742 --- Comment #24 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 124992 merged by jenkins-bot: Remove space inside array initializers https://gerrit.wikimedia.org/r/124992 -- You are receiving this mail because: You are the

[Bug 63742] Make the app pass checkstyle cleanly

2014-04-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=63742 --- Comment #27 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 125001 merged by jenkins-bot: Remove stray spaces inside parentheses https://gerrit.wikimedia.org/r/125001 -- You are receiving this mail because: You are the

[Bug 63742] Make the app pass checkstyle cleanly

2014-04-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=63742 --- Comment #28 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 125003 merged by jenkins-bot: Check that static variables are always all caps https://gerrit.wikimedia.org/r/125003 -- You are receiving this mail because: You

[Bug 63742] Make the app pass checkstyle cleanly

2014-04-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=63742 --- Comment #29 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 125109 had a related patch set uploaded by Yuvipanda: Fix checkstyle.xml to allow underscores in static var names https://gerrit.wikimedia.org/r/125109 -- You

[Bug 63742] Make the app pass checkstyle cleanly

2014-04-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=63742 --- Comment #30 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 125110 had a related patch set uploaded by Yuvipanda: Fix static variable names https://gerrit.wikimedia.org/r/125110 -- You are receiving this mail because:

[Bug 63742] Make the app pass checkstyle cleanly

2014-04-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=63742 --- Comment #31 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 125111 had a related patch set uploaded by Yuvipanda: Neuter stray whitespace before semicolon https://gerrit.wikimedia.org/r/125111 -- You are receiving this

[Bug 63742] Make the app pass checkstyle cleanly

2014-04-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=63742 --- Comment #32 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 125112 had a related patch set uploaded by Yuvipanda: Remove redundant 'final' qualifiers https://gerrit.wikimedia.org/r/125112 -- You are receiving this mail

[Bug 63742] Make the app pass checkstyle cleanly

2014-04-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=63742 --- Comment #33 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 125109 merged by jenkins-bot: Fix checkstyle.xml to allow underscores in static var names https://gerrit.wikimedia.org/r/125109 -- You are receiving this mail

[Bug 63742] Make the app pass checkstyle cleanly

2014-04-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=63742 --- Comment #34 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 125110 merged by jenkins-bot: Fix static variable names https://gerrit.wikimedia.org/r/125110 -- You are receiving this mail because: You are the assignee for

[Bug 63742] Make the app pass checkstyle cleanly

2014-04-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=63742 --- Comment #35 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 125111 merged by jenkins-bot: Neuter stray whitespace before semicolon https://gerrit.wikimedia.org/r/125111 -- You are receiving this mail because: You are

[Bug 63742] Make the app pass checkstyle cleanly

2014-04-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=63742 --- Comment #36 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 125114 had a related patch set uploaded by Yuvipanda: Remove redundant 'final' qualifiers https://gerrit.wikimedia.org/r/125114 -- You are receiving this mail

[Bug 63742] Make the app pass checkstyle cleanly

2014-04-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=63742 --- Comment #38 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 125112 abandoned by Addshore: Remove redundant 'final' qualifiers Reason: I live here now https://gerrit.wikimedia.org/r/#/c/125114/

[Bug 63742] Make the app pass checkstyle cleanly

2014-04-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=63742 --- Comment #37 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 125115 had a related patch set uploaded by Yuvipanda: Fix wider-than-necessary visibility https://gerrit.wikimedia.org/r/125115 -- You are receiving this mail

[Bug 63742] Make the app pass checkstyle cleanly

2014-04-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=63742 --- Comment #39 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 125114 merged by jenkins-bot: Remove redundant 'final' qualifiers https://gerrit.wikimedia.org/r/125114 -- You are receiving this mail because: You are the

[Bug 63742] Make the app pass checkstyle cleanly

2014-04-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=63742 --- Comment #40 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 125119 had a related patch set uploaded by Yuvipanda: Allow inline conditionals. https://gerrit.wikimedia.org/r/125119 -- You are receiving this mail because:

[Bug 63742] Make the app pass checkstyle cleanly

2014-04-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=63742 --- Comment #42 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 125119 merged by jenkins-bot: Allow inline conditionals. https://gerrit.wikimedia.org/r/125119 -- You are receiving this mail because: You are the assignee for

[Bug 63742] Make the app pass checkstyle cleanly

2014-04-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=63742 --- Comment #41 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 125115 merged by jenkins-bot: Fix wider-than-necessary visibility https://gerrit.wikimedia.org/r/125115 -- You are receiving this mail because: You are the

[Bug 63742] Make the app pass checkstyle cleanly

2014-04-09 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=63742 --- Comment #1 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 124914 had a related patch set uploaded by Yuvipanda: Remove sole tab character https://gerrit.wikimedia.org/r/124914 -- You are receiving this mail because:

[Bug 63742] Make the app pass checkstyle cleanly

2014-04-09 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=63742 Gerrit Notification Bot gerritad...@wikimedia.org changed: What|Removed |Added Status|NEW

[Bug 63742] Make the app pass checkstyle cleanly

2014-04-09 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=63742 --- Comment #2 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 124917 had a related patch set uploaded by Yuvipanda: Fix ordering of visibility modifiers to match JLS https://gerrit.wikimedia.org/r/124917 -- You are

[Bug 63742] Make the app pass checkstyle cleanly

2014-04-09 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=63742 --- Comment #3 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 124961 had a related patch set uploaded by Yuvipanda: Organize imports remove a redundant import https://gerrit.wikimedia.org/r/124961 -- You are receiving

[Bug 63742] Make the app pass checkstyle cleanly

2014-04-09 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=63742 --- Comment #4 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 124976 had a related patch set uploaded by Yuvipanda: Explicitly use braces everywhere https://gerrit.wikimedia.org/r/124976 -- You are receiving this mail

[Bug 63742] Make the app pass checkstyle cleanly

2014-04-09 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=63742 --- Comment #5 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 124983 had a related patch set uploaded by Yuvipanda: Use Java style array declarations than C style https://gerrit.wikimedia.org/r/124983 -- You are receiving

[Bug 63742] Make the app pass checkstyle cleanly

2014-04-09 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=63742 --- Comment #7 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 124987 had a related patch set uploaded by Yuvipanda: Ensure that Utils class can't be instantiated https://gerrit.wikimedia.org/r/124987 -- You are receiving

[Bug 63742] Make the app pass checkstyle cleanly

2014-04-09 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=63742 --- Comment #8 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 124988 had a related patch set uploaded by Yuvipanda: Make sure that all member variables are camelCase https://gerrit.wikimedia.org/r/124988 -- You are

[Bug 63742] Make the app pass checkstyle cleanly

2014-04-09 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=63742 --- Comment #9 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 124992 had a related patch set uploaded by Yuvipanda: Remove space inside array initializers https://gerrit.wikimedia.org/r/124992 -- You are receiving this

[Bug 63742] Make the app pass checkstyle cleanly

2014-04-09 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=63742 --- Comment #6 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 124986 had a related patch set uploaded by Yuvipanda: Properly format multiline boolean checks to be more consistent https://gerrit.wikimedia.org/r/124986 --

[Bug 63742] Make the app pass checkstyle cleanly

2014-04-09 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=63742 --- Comment #10 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 124996 had a related patch set uploaded by Yuvipanda: Remove redundant public and static modifiers https://gerrit.wikimedia.org/r/124996 -- You are receiving

[Bug 63742] Make the app pass checkstyle cleanly

2014-04-09 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=63742 --- Comment #11 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 125000 had a related patch set uploaded by Yuvipanda: Ensure that all constants are named ALL_UPPERCASE https://gerrit.wikimedia.org/r/125000 -- You are

[Bug 63742] Make the app pass checkstyle cleanly

2014-04-09 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=63742 --- Comment #12 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 125001 had a related patch set uploaded by Yuvipanda: Remove stray spaces inside parens https://gerrit.wikimedia.org/r/125001 -- You are receiving this mail

[Bug 63742] Make the app pass checkstyle cleanly

2014-04-09 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=63742 --- Comment #13 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 125002 had a related patch set uploaded by Yuvipanda: Ensure that there is always a space after a comma https://gerrit.wikimedia.org/r/125002 -- You are

[Bug 63742] Make the app pass checkstyle cleanly

2014-04-09 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=63742 --- Comment #14 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 125003 had a related patch set uploaded by Yuvipanda: Check that static variables are always all caps https://gerrit.wikimedia.org/r/125003 -- You are

[Bug 63742] Make the app pass checkstyle cleanly

2014-04-09 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=63742 --- Comment #15 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 124914 merged by jenkins-bot: Remove sole tab character https://gerrit.wikimedia.org/r/124914 -- You are receiving this mail because: You are the assignee for

[Bug 63742] Make the app pass checkstyle cleanly

2014-04-09 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=63742 --- Comment #16 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 124917 merged by jenkins-bot: Fix ordering of visibility modifiers to match JLS https://gerrit.wikimedia.org/r/124917 -- You are receiving this mail because: