https://bugzilla.wikimedia.org/show_bug.cgi?id=64595
--- Comment #29 from Gerrit Notification Bot ---
Change 132498 abandoned by Krinkle:
ResourceLoader: Allow individual modules to define their own additional less
import paths.
Reason:
Closing for now. bug 64595 was fixed and bug 60368 is an up
https://bugzilla.wikimedia.org/show_bug.cgi?id=64595
Bartosz Dziewoński changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
https://bugzilla.wikimedia.org/show_bug.cgi?id=64595
--- Comment #27 from Gerrit Notification Bot ---
Change 132441 merged by jenkins-bot:
Remove Vector from the default LESS import path
https://gerrit.wikimedia.org/r/132441
--
You are receiving this mail because:
You are the assignee for the
https://bugzilla.wikimedia.org/show_bug.cgi?id=64595
--- Comment #26 from Gerrit Notification Bot ---
Change 132440 abandoned by Bartosz Dziewoński:
Add Vector to the LESS import path from within VectorBeta
https://gerrit.wikimedia.org/r/132440
--
You are receiving this mail because:
You are t
https://bugzilla.wikimedia.org/show_bug.cgi?id=64595
--- Comment #25 from Krinkle ---
@Bartosz: However Ori and myself have been given push access to the
leafo/lessphp repo, so consider it open for patches just like MediaWiki itself.
Either through pull request directly (which we can review) or i
https://bugzilla.wikimedia.org/show_bug.cgi?id=64595
Krinkle changed:
What|Removed |Added
Status|PATCH_TO_REVIEW |NEW
--- Comment #24 from Krinkle ---
Upstre
https://bugzilla.wikimedia.org/show_bug.cgi?id=64595
Krinkle changed:
What|Removed |Added
Depends on||60368
See Also|https://bugzilla.wi
https://bugzilla.wikimedia.org/show_bug.cgi?id=64595
--- Comment #23 from Bartosz Dziewoński ---
Was lessc updated to fix the underlying issue?
What is the status of Daniel's patches
https://gerrit.wikimedia.org/r/#/c/132440/ and
https://gerrit.wikimedia.org/r/#/c/132441/ to undo VectorBeta hack
https://bugzilla.wikimedia.org/show_bug.cgi?id=64595
--- Comment #22 from Gerrit Notification Bot ---
Change 132812 merged by jenkins-bot:
Remove Vector from the default LESS import path
https://gerrit.wikimedia.org/r/132812
--
You are receiving this mail because:
You are the assignee for the
https://bugzilla.wikimedia.org/show_bug.cgi?id=64595
--- Comment #21 from Gerrit Notification Bot ---
Change 132812 had a related patch set uploaded by MarkAHershberger:
Remove Vector from the default LESS import path
https://gerrit.wikimedia.org/r/132812
--
You are receiving this mail because
https://bugzilla.wikimedia.org/show_bug.cgi?id=64595
--- Comment #20 from Gerrit Notification Bot ---
Change 132447 abandoned by Krinkle:
Backport Iee47bdc23630e02ccfcbd28496ec5268892eb629 to 1.23.
Reason:
Please maintain a useful summary and a matching Change-Id for the backport
commit. The eas
https://bugzilla.wikimedia.org/show_bug.cgi?id=64595
--- Comment #19 from Daniel Friesen ---
I've implemented per-module import paths that – among other things – allow
VectorBeta to import stuff from Vector without requiring extra co-operation
from core, pollution of global imports, or even requi
https://bugzilla.wikimedia.org/show_bug.cgi?id=64595
--- Comment #18 from Gerrit Notification Bot ---
Change 132498 had a related patch set uploaded by Daniel Friesen:
ResourceLoader: Allow individual modules to define their own additional less
import paths.
https://gerrit.wikimedia.org/r/132498
https://bugzilla.wikimedia.org/show_bug.cgi?id=64595
--- Comment #17 from Daniel Friesen ---
((Edit conflicted, but I'll post it anyways))
(In reply to Krinkle from comment #12)
> So removing it is imho not a logical fix and won't solve the actual problem
> (if you'd have a file that has the sam
https://bugzilla.wikimedia.org/show_bug.cgi?id=64595
--- Comment #16 from Mark A. Hershberger ---
(In reply to Krinkle from comment #15)
> Hoping Ori and I can get up to 24 hours tops to fix this "the right way".
Granted. You have 24 hours. The clock starts now.
--
You are receiving this mai
https://bugzilla.wikimedia.org/show_bug.cgi?id=64595
--- Comment #15 from Krinkle ---
So yeah, this is a bug in the leafo/lessphp implementation of LESS. It looks up
import path first, and if nothing is found it tries to resolve it as a relative
file name.
Both the official js implementation and
https://bugzilla.wikimedia.org/show_bug.cgi?id=64595
--- Comment #14 from Mark A. Hershberger ---
(In reply to Mark A. Hershberger from comment #13)
> ...if nothing else comes up.
I should clarify that I mean if there aren't any other issues raised.
--
You are receiving this mail because:
You
https://bugzilla.wikimedia.org/show_bug.cgi?id=64595
Mark A. Hershberger changed:
What|Removed |Added
CC||m...@everybody.org
--- Comment #
https://bugzilla.wikimedia.org/show_bug.cgi?id=64595
--- Comment #12 from Krinkle ---
The local path should always be used in preference to the global import path.
So while Vector should not be in MediaWiki's global import path, your
extensions module's directory should always be consulted first.
https://bugzilla.wikimedia.org/show_bug.cgi?id=64595
--- Comment #11 from Krinkle ---
Vector has no business being in the import path. It was added there as a hack
for the VectorBeta extension.
https://github.com/wikimedia/mediawiki-extensions-VectorBeta/blob/92ea3a6ce67ef/resources/typography/s
https://bugzilla.wikimedia.org/show_bug.cgi?id=64595
--- Comment #10 from Gerrit Notification Bot ---
Change 132447 had a related patch set uploaded by Daniel Friesen:
Backport Iee47bdc23630e02ccfcbd28496ec5268892eb629 to 1.23.
https://gerrit.wikimedia.org/r/132447
--
You are receiving this ma
https://bugzilla.wikimedia.org/show_bug.cgi?id=64595
--- Comment #9 from Gerrit Notification Bot ---
Change 132441 had a related patch set uploaded by Daniel Friesen:
Remove Vector from the default LESS import path
https://gerrit.wikimedia.org/r/132441
--
You are receiving this mail because:
Y
https://bugzilla.wikimedia.org/show_bug.cgi?id=64595
--- Comment #8 from Gerrit Notification Bot ---
Change 132440 had a related patch set uploaded by Daniel Friesen:
Add Vector to the LESS import path from within VectorBeta
https://gerrit.wikimedia.org/r/132440
--
You are receiving this mail
https://bugzilla.wikimedia.org/show_bug.cgi?id=64595
Gerrit Notification Bot changed:
What|Removed |Added
Status|NEW |PATCH_TO_REVIEW
--
You are
https://bugzilla.wikimedia.org/show_bug.cgi?id=64595
Andre Klapper changed:
What|Removed |Added
Priority|Unprioritized |High
--
You are receiving this mail b
https://bugzilla.wikimedia.org/show_bug.cgi?id=64595
--- Comment #7 from Daniel Friesen ---
While digging into this I found that part of this issues actually lies in a
poor choice of LESS parsing library:
https://www.mediawiki.org/wiki/Requests_for_comment/Change_LESS_compilation_library
We used
https://bugzilla.wikimedia.org/show_bug.cgi?id=64595
--- Comment #6 from Daniel Friesen ---
(In reply to Jon from comment #5)
> I think there is value in making the LESS variables of Vector available to
> extensions using that skin. Most extensions don't use LESS but we should be
> encouraging th
https://bugzilla.wikimedia.org/show_bug.cgi?id=64595
--- Comment #5 from Jon ---
I think there is value in making the LESS variables of Vector available to
extensions using that skin. Most extensions don't use LESS but we should be
encouraging them to do and to share variables and themes with sta
https://bugzilla.wikimedia.org/show_bug.cgi?id=64595
--- Comment #4 from Daniel Friesen ---
(In reply to Kevin Israel (PleaseStand) from comment #3)
> (In reply to Daniel Friesen from comment #2)
> > (In reply to Bartosz Dziewoński from comment #1)
> > > Sounds exactly like bug 60368.
>
> Yes, t
https://bugzilla.wikimedia.org/show_bug.cgi?id=64595
Kevin Israel (PleaseStand) changed:
What|Removed |Added
CC||jrob...@wikimedia.org,
https://bugzilla.wikimedia.org/show_bug.cgi?id=64595
--- Comment #2 from Daniel Friesen ---
(In reply to Bartosz Dziewoński from comment #1)
> Sounds exactly like bug 60368.
Maybe, if using "./variables" behaves like "variables" and doesn't bypass the
include path.
--
You are receiving this ma
https://bugzilla.wikimedia.org/show_bug.cgi?id=64595
Bartosz Dziewoński changed:
What|Removed |Added
See Also||https://bugzilla.wikimedia.
https://bugzilla.wikimedia.org/show_bug.cgi?id=64595
Bartosz Dziewoński changed:
What|Removed |Added
CC||matma@gmail.com
Ve
33 matches
Mail list logo
