[Bug 64960] Attempting to create a username with a hash in should throw an error

https://bugzilla.wikimedia.org/show_bug.cgi?id=64960 Dan Garry changed: What|Removed |Added Priority|Unprioritized |Normal Severity|normal

[Bug 64960] Attempting to create a username with a hash in should throw an error

https://bugzilla.wikimedia.org/show_bug.cgi?id=64960 Dan Garry changed: What|Removed |Added See Also||https://bugzilla.wikimedia.

[Bug 64960] Attempting to create a username with a hash in should throw an error

https://bugzilla.wikimedia.org/show_bug.cgi?id=64960 Dan Garry changed: What|Removed |Added See Also||https://bugzilla.wikimedia.

[Bug 64960] Attempting to create a username with a hash in should throw an error

https://bugzilla.wikimedia.org/show_bug.cgi?id=64960 --- Comment #2 from Dan Garry --- (In reply to Liangent from comment #1) > (In reply to Dan Garry from comment #0) > > This means the user ends up creating a username that is different > > from what they typed in, which is suboptimal from a pro

[Bug 64960] Attempting to create a username with a hash in should throw an error

https://bugzilla.wikimedia.org/show_bug.cgi?id=64960 --- Comment #1 from Liangent --- (In reply to Dan Garry from comment #0) > This means the user ends up creating a username that is different > from what they typed in, which is suboptimal from a product perspective. Truncation is just a part o

[Bug 64960] Attempting to create a username with a hash in should throw an error

https://bugzilla.wikimedia.org/show_bug.cgi?id=64960 --- Comment #3 from Liangent --- Well using a user name with extra #foobar works in wikilinks and URL: #foobar is just considered page fragment. I guess it's the just the cause of this bug that "#" starts a fragment: they use class Title to no

[Bug 64960] Attempting to create a username with a hash in should throw an error

https://bugzilla.wikimedia.org/show_bug.cgi?id=64960 Umherirrender changed: What|Removed |Added CC||matma@gmail.com,

[Bug 64960] Attempting to create a username with a hash in should throw an error

https://bugzilla.wikimedia.org/show_bug.cgi?id=64960 --- Comment #5 from Bartosz Dziewoński --- (In reply to Liangent from comment #1) > And in practice, I saw some rename requests about 'I tried to create > "foobar" but the system gave me "Foobar" but I still want "foobar".' and > after rejectio

[Bug 64960] Attempting to create a username with a hash in should throw an error

https://bugzilla.wikimedia.org/show_bug.cgi?id=64960 --- Comment #6 from Bartosz Dziewoński --- (In reply to Umherirrender from comment #4) > Possible caused by Gerrit change #115329 where a Title call was added Ugh, sounds likely. We should probably check the the object returned by Title::makeT

[Bug 64960] Attempting to create a username with a hash in should throw an error

https://bugzilla.wikimedia.org/show_bug.cgi?id=64960 --- Comment #7 from Umherirrender --- (In reply to Bartosz Dziewoński from comment #6) > (In reply to Umherirrender from comment #4) > > Possible caused by Gerrit change #115329 where a Title call was added > > Ugh, sounds likely. We should pr

[Bug 64960] Attempting to create a username with a hash in should throw an error

https://bugzilla.wikimedia.org/show_bug.cgi?id=64960 --- Comment #8 from Bartosz Dziewoński --- User::getCanonicalName( …, 'creatable' ) (or User::isCreatableName( … ) that calls internally) is very strict and will reject, for example, a username like "User " (with a *trailing space*). -- You a

[Bug 64960] Attempting to create a username with a hash in should throw an error

https://bugzilla.wikimedia.org/show_bug.cgi?id=64960 --- Comment #9 from Bartosz Dziewoński --- Actually, we can't even check for the fragment reliably, because "User:Foo#" (trailing hash sign) will be considered as having no fragment part. I say we just explicitly check for a '#' in text there

[Bug 64960] Attempting to create a username with a hash in should throw an error

https://bugzilla.wikimedia.org/show_bug.cgi?id=64960 --- Comment #10 from Gerrit Notification Bot --- Change 132584 had a related patch set uploaded by Bartosz Dziewoński: SpecialUserlogin: Error out when attempting to create a username with a '#' https://gerrit.wikimedia.org/r/132584 -- You a

[Bug 64960] Attempting to create a username with a hash in should throw an error

https://bugzilla.wikimedia.org/show_bug.cgi?id=64960 Gerrit Notification Bot changed: What|Removed |Added Status|NEW |PATCH_TO_REVIEW -- You are

[Bug 64960] Attempting to create a username with a hash in should throw an error

https://bugzilla.wikimedia.org/show_bug.cgi?id=64960 --- Comment #11 from Dan Garry --- Thanks for working on this Bartosz! I'll try to get an engineer to review your patch. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___

[Bug 64960] Attempting to create a username with a hash in should throw an error

https://bugzilla.wikimedia.org/show_bug.cgi?id=64960 --- Comment #12 from Gerrit Notification Bot --- Change 132584 merged by Brion VIBBER: SpecialUserlogin: Error out when attempting to create a username with a '#' https://gerrit.wikimedia.org/r/132584 -- You are receiving this mail because:

[Bug 64960] Attempting to create a username with a hash in should throw an error

https://bugzilla.wikimedia.org/show_bug.cgi?id=64960 Bartosz Dziewoński changed: What|Removed |Added Status|PATCH_TO_REVIEW |RESOLVED Resolution|---

[Bug 64960] Attempting to create a username with a hash in should throw an error

https://bugzilla.wikimedia.org/show_bug.cgi?id=64960 Bartosz Dziewoński changed: What|Removed |Added Blocks||65005 -- You are receiving this

[Bug 64960] Attempting to create a username with a hash in should throw an error

https://bugzilla.wikimedia.org/show_bug.cgi?id=64960 Yuvi Panda changed: What|Removed |Added CC||yuvipa...@gmail.com --- Comment #14 from