https://bugzilla.wikimedia.org/show_bug.cgi?id=66143
--- Comment #22 from Bawolff (Brian Wolff) ---
> This might be more appropriate for a separate bug - in that case, sorry for
> the offtopic discussion.
Yeah it is kind of something that should be a separate bug.
I started on I6f3316477175634
https://bugzilla.wikimedia.org/show_bug.cgi?id=66143
--- Comment #21 from Bawolff (Brian Wolff) ---
> However, when I tried this out, reusing the HTML (from this wiki page:
> https://meta.wikimedia.org/w/index.php?title=Wikimedia_Blog/Drafts/
> A_Look_Back_at_Wikimania_2013&oldid=9276912 ) in a
https://bugzilla.wikimedia.org/show_bug.cgi?id=66143
--- Comment #20 from Tilman Bayer ---
(In reply to Bawolff (Brian Wolff) from comment #18)
> >
> > Yes, it was changed as a workaround for this bug last week. But that's
> > actually the way we most often use for videos on the blog (e.g.
> > h
https://bugzilla.wikimedia.org/show_bug.cgi?id=66143
--- Comment #19 from Tisza Gergő ---
(In reply to Bawolff (Brian Wolff) from comment #18)
> I don't think there's a bug for that, but its been on my mind that there
> should be a method of specifying the thumbtime via iframe.
There is now: bug
https://bugzilla.wikimedia.org/show_bug.cgi?id=66143
--- Comment #18 from Bawolff (Brian Wolff) ---
>
> Yes, it was changed as a workaround for this bug last week. But that's
> actually the way we most often use for videos on the blog (e.g.
> https://blog.wikimedia.org/2014/05/26/happy-birthday
https://bugzilla.wikimedia.org/show_bug.cgi?id=66143
--- Comment #17 from Tilman Bayer ---
(In reply to Tisza Gergő from comment #16)
> Fix deployed to Commons, seems to work now. Thanks, Bawolff!
>
Great, works for me too now. Thanks a lot everyone, in particular Bawolff!
> (The first video in
https://bugzilla.wikimedia.org/show_bug.cgi?id=66143
Tisza Gergő changed:
What|Removed |Added
Status|PATCH_TO_REVIEW |RESOLVED
Resolution|---
https://bugzilla.wikimedia.org/show_bug.cgi?id=66143
--- Comment #15 from Gerrit Notification Bot ---
Change 142149 merged by jenkins-bot:
Update TimedMediaHandler with embed breakage fixes
https://gerrit.wikimedia.org/r/142149
--
You are receiving this mail because:
You are the assignee for t
https://bugzilla.wikimedia.org/show_bug.cgi?id=66143
--- Comment #14 from Gerrit Notification Bot ---
Change 142149 had a related patch set uploaded by Gergő Tisza:
Update TimedMediaHandler with embed breakage fixes
https://gerrit.wikimedia.org/r/142149
--
You are receiving this mail because:
https://bugzilla.wikimedia.org/show_bug.cgi?id=66143
--- Comment #13 from Gerrit Notification Bot ---
Change 142132 merged by jenkins-bot:
Do not break iframes in the iframe output of TMH
https://gerrit.wikimedia.org/r/142132
--
You are receiving this mail because:
You are the assignee for the
https://bugzilla.wikimedia.org/show_bug.cgi?id=66143
--- Comment #12 from Gerrit Notification Bot ---
Change 142132 had a related patch set uploaded by Gergő Tisza:
Do not break iframes in the iframe output of TMH
https://gerrit.wikimedia.org/r/142132
--
You are receiving this mail because:
Yo
https://bugzilla.wikimedia.org/show_bug.cgi?id=66143
--- Comment #11 from Gerrit Notification Bot ---
Change 142085 merged by jenkins-bot:
Do not break iframes in the iframe output of TMH
https://gerrit.wikimedia.org/r/142085
--
You are receiving this mail because:
You are the assignee for the
https://bugzilla.wikimedia.org/show_bug.cgi?id=66143
--- Comment #10 from Bawolff (Brian Wolff) ---
(In reply to Bawolff (Brian Wolff) from comment #8)
> Ok, what's happening is that $wgBreakFrames = true is on production. My last
> change that used MW's default loader, caused this code to become
https://bugzilla.wikimedia.org/show_bug.cgi?id=66143
Gerrit Notification Bot changed:
What|Removed |Added
Status|NEW |PATCH_TO_REVIEW
--
You are
https://bugzilla.wikimedia.org/show_bug.cgi?id=66143
--- Comment #9 from Gerrit Notification Bot ---
Change 142085 had a related patch set uploaded by Brian Wolff:
Do not break iframes in the iframe output of TMH
https://gerrit.wikimedia.org/r/142085
--
You are receiving this mail because:
You
https://bugzilla.wikimedia.org/show_bug.cgi?id=66143
--- Comment #8 from Bawolff (Brian Wolff) ---
Ok, what's happening is that $wgBreakFrames = true is on production. My last
change that used MW's default loader, caused this code to become active for
embedplayer=yes
--
You are receiving this m
https://bugzilla.wikimedia.org/show_bug.cgi?id=66143
--- Comment #7 from Bawolff (Brian Wolff) ---
(In reply to Tisza Gergő from comment #6)
> This seems to have made things worse, the blog posts are completely
> unreadable now.
Oh wow. That's not good.
Hmm, so this doesn't happen to me l
https://bugzilla.wikimedia.org/show_bug.cgi?id=66143
Tisza Gergő changed:
What|Removed |Added
Status|PATCH_TO_REVIEW |NEW
--- Comment #6 from Tisza Gergő ---
https://bugzilla.wikimedia.org/show_bug.cgi?id=66143
--- Comment #5 from Bawolff (Brian Wolff) ---
This should hopefully start working again come june 24.
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
__
https://bugzilla.wikimedia.org/show_bug.cgi?id=66143
--- Comment #4 from Gerrit Notification Bot ---
Change 137529 merged by jenkins-bot:
Fix ?embedplayer=yes mode, which is currently totally broken
https://gerrit.wikimedia.org/r/137529
--
You are receiving this mail because:
You are the assig
https://bugzilla.wikimedia.org/show_bug.cgi?id=66143
Bawolff (Brian Wolff) changed:
What|Removed |Added
CC||kn.bugzi...@gmail.com
--- Comm
https://bugzilla.wikimedia.org/show_bug.cgi?id=66143
Andre Klapper changed:
What|Removed |Added
Priority|Unprioritized |High
--
You are receiving this mail b
https://bugzilla.wikimedia.org/show_bug.cgi?id=66143
Bawolff (Brian Wolff) changed:
What|Removed |Added
Keywords||need-integration-test
--
You
https://bugzilla.wikimedia.org/show_bug.cgi?id=66143
--- Comment #2 from Bawolff (Brian Wolff) ---
Ugh. Really need to figure out how to do automated testing of this (selenium?)
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
https://bugzilla.wikimedia.org/show_bug.cgi?id=66143
Gerrit Notification Bot changed:
What|Removed |Added
Status|NEW |PATCH_TO_REVIEW
--
You are
https://bugzilla.wikimedia.org/show_bug.cgi?id=66143
--- Comment #1 from Gerrit Notification Bot ---
Change 137529 had a related patch set uploaded by Brian Wolff:
Fix ?embedplayer=yes mode, which is currently totally broken
https://gerrit.wikimedia.org/r/137529
--
You are receiving this mail
26 matches
Mail list logo
