[Bug 68565] SnakUnserializer must not fail on mismatching hashes

2014-07-25 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=68565 Daniel Kinzler changed: What|Removed |Added Priority|Unprioritized |High CC|

[Bug 68565] SnakUnserializer must not fail on mismatching hashes

2014-07-25 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=68565 Lydia Pintscher changed: What|Removed |Added CC||jeroen_ded...@yahoo.com,

[Bug 68565] SnakUnserializer must not fail on mismatching hashes

2014-07-25 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=68565 Lydia Pintscher changed: What|Removed |Added Status|NEW |ASSIGNED Whiteboard|u=dev c=

[Bug 68565] SnakUnserializer must not fail on mismatching hashes

2014-07-25 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=68565 --- Comment #2 from Jeroen De Dauw --- The hash is not part of the value, this should never have been done by the deserializer. Killed by https://github.com/wmde/WikibaseDataModelSerialization/pull/72 -- You are receiving this mail because:

[Bug 68565] SnakUnserializer must not fail on mismatching hashes

2014-07-25 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=68565 --- Comment #3 from Jeroen De Dauw --- Wow, this has 8 points? Nice. That means I can now take a day off I guess :) -- You are receiving this mail because: You are on the CC list for the bug. ___ Wi

[Bug 68565] SnakUnserializer must not fail on mismatching hashes

2014-07-25 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=68565 --- Comment #4 from Jeroen De Dauw --- While this fixes the issue at hand, the way the snak hash is implemented sucks. Created a ticket https://github.com/wmde/WikibaseDataModel/issues/130 -- You are receiving this mail because: You are on th

[Bug 68565] SnakUnserializer must not fail on mismatching hashes

2014-07-25 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=68565 Jeroen De Dauw changed: What|Removed |Added Status|ASSIGNED|PATCH_TO_REVIEW -- You are receiving

[Bug 68565] SnakUnserializer must not fail on mismatching hashes

2014-07-27 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=68565 Jeroen De Dauw changed: What|Removed |Added Status|PATCH_TO_REVIEW |RESOLVED Resolution|---

[Bug 68565] SnakUnserializer must not fail on mismatching hashes

2014-07-28 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=68565 --- Comment #5 from Daniel Kinzler --- (In reply to Jeroen De Dauw from comment #3) > Wow, this has 8 points? Nice. That means I can now take a day off I guess :) Well, just killing it makes it a lot easier, the 8 was considering the option to

[Bug 68565] SnakUnserializer must not fail on mismatching hashes

2014-07-29 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=68565 --- Comment #6 from Gerrit Notification Bot --- Change 150202 had a related patch set uploaded by Thiemo Mättig (WMDE): Add UnDeserializableValue to DataModelSerializationRoundtripTest https://gerrit.wikimedia.org/r/150202 -- You are receivi

[Bug 68565] SnakUnserializer must not fail on mismatching hashes

2014-07-29 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=68565 Gerrit Notification Bot changed: What|Removed |Added Status|RESOLVED|PATCH_TO_REVIEW Reso

[Bug 68565] SnakUnserializer must not fail on mismatching hashes

2014-07-29 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=68565 --- Comment #7 from Gerrit Notification Bot --- Change 150202 merged by jenkins-bot: Add UnDeserializableValue to DataModelSerializationRoundtripTest https://gerrit.wikimedia.org/r/150202 -- You are receiving this mail because: You are on th

[Bug 68565] SnakUnserializer must not fail on mismatching hashes

2014-07-29 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=68565 tobias.gritschac...@wikimedia.de changed: What|Removed |Added Status|PATCH_TO_REVIEW |RESOLVED