[Wikidata-bugs] [Maniphest] [Edited] T66315: Move "Data item" link outside of sidebar toolbox

Lydia_Pintscher updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T66315 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lydia_Pintscher Cc: Soluvo, Addshore, TerraCodes, Izno, Aklapper, Nemo_bis, Ricordisamoa, MZMcBride,

[Wikidata-bugs] [Maniphest] [Updated] T223994: Add service to turn term IDs back into terms

Lucas_Werkmeister_WMDE added a parent task: T221706: Implement PropertyTermStore wikibase-term-store using MW DBAL. TASK DETAIL https://phabricator.wikimedia.org/T223994 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc:

[Wikidata-bugs] [Maniphest] [Updated] T221706: Implement PropertyTermStore wikibase-term-store using MW DBAL

Lucas_Werkmeister_WMDE added a subtask: T223994: Add service to turn term IDs back into terms. TASK DETAIL https://phabricator.wikimedia.org/T221706 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: alaa_wmde, Lucas_Werkmeister_WMDE Cc: Aklapper,

[Wikidata-bugs] [Maniphest] [Claimed] T223994: Add service to turn term IDs back into terms

Lucas_Werkmeister_WMDE claimed this task. Lucas_Werkmeister_WMDE moved this task from Backlog to In Progress on the Wikidata wb_terms Trailblazing board. TASK DETAIL https://phabricator.wikimedia.org/T223994 WORKBOARD https://phabricator.wikimedia.org/project/board/3972/ EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Created] T223994: Add service to turn term IDs back into terms

Lucas_Werkmeister_WMDE created this task. Lucas_Werkmeister_WMDE added projects: Wikidata, Wikidata wb_terms Trailblazing. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION If the `PropertyTermStore` implementation will live in Wikibase, and Wikibase isn’t supposed to know

[Wikidata-bugs] [Maniphest] [Edited] T223986: Create user preference repository

Pablo-WMDE updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T223986 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Aklapper, Pablo-WMDE, darthmon_wmde, alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic,

[Wikidata-bugs] [Maniphest] [Commented On] T219499: [Problem] `Special:SetAliases`, `Special:NewItem` and `Special:NewProperty` separates aliases with | character but have no way to make a | part of o

alaa_wmde added a comment. Waiting on iteration 1 https://phabricator.wikimedia.org/T223270 to be completed and enough time to pass for data collection TASK DETAIL https://phabricator.wikimedia.org/T219499 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T223776: Create Wikidata autocomplete gadget for external entities

Pintoch added a comment. That's great! Is there a list of the supported external ids? TASK DETAIL https://phabricator.wikimedia.org/T223776 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Danmichaelo, Pintoch Cc: Pintoch, Lea_Lacroix_WMDE,

[Wikidata-bugs] [Maniphest] [Retitled] T223985: Use checkbox in AnonEditWarning

Pablo-WMDE renamed this task from "Persist preference" to "Use checkbox in AnonEditWarning". Pablo-WMDE updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T223985 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE

[Wikidata-bugs] [Maniphest] [Retitled] T223987: Use user preference value to avoid "You are not logged in" overlay

Pablo-WMDE renamed this task from "Create user preference value to avoid "You are not logged in" overlay" to "Use user preference value to avoid "You are not logged in" overlay". TASK DETAIL https://phabricator.wikimedia.org/T223987 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Created] T223987: Create user preference value to avoid "You are not logged in" overlay

Pablo-WMDE created this task. Pablo-WMDE added projects: Wikidata, Wikidata-Termbox-Iteration-16. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION TASK DETAIL https://phabricator.wikimedia.org/T223987 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Created] T223986: Create user preference repository

Pablo-WMDE created this task. Pablo-WMDE added projects: Wikidata, Wikidata-Termbox-Iteration-16. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION TASK DETAIL https://phabricator.wikimedia.org/T223986 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Created] T223985: Persist preference

Pablo-WMDE created this task. Pablo-WMDE added projects: Wikidata, Wikidata-Termbox-Iteration-16. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION - given the checkbox is unchecked - when either of the buttons is clicked - then the user preference is persisted

[Wikidata-bugs] [Maniphest] [Edited] T223982: Create custom checkbox component

Pablo-WMDE updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T223982 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Aklapper, Pablo-WMDE, darthmon_wmde, alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic,

[Wikidata-bugs] [Maniphest] [Edited] T223982: Create custom checkbox component

Pablo-WMDE updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T223982 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Aklapper, Pablo-WMDE, darthmon_wmde, alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic,

[Wikidata-bugs] [Maniphest] [Commented On] T223544: WMHack19: The native language name for [sms] Skolt Sami should be changed from "sää´mǩiõll" and "sääʹmǩiõll" to "nuõrttsääʹmǩiõll"

Yupik added a comment. For the name of the language, go to the Language Board and select the illative version of the language (//nuõrttsääʹmǩiõʹlle//) and convert it to the nominative form (//nuõrttsääʹmǩiõll//). As can been seen from the Skolt pages, both

[Wikidata-bugs] [Maniphest] [Created] T223982: Create custom checkbox component

Pablo-WMDE created this task. Pablo-WMDE added projects: Wikidata, Wikidata-Termbox-Iteration-16. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION - mark-up - style - storybook Info - current hope is that we will later (in a future task inside the same story)

[Wikidata-bugs] [Maniphest] [Commented On] T221651: Define wmgUseWikibaseSchema variable in mediawiki/config (default false)

Stashbot added a comment. Mentioned in SAL (#wikimedia-operations) [2019-05-21T11:10:50Z] Synchronized wmf-config/CommonSettings.php: SWAT: [[gerrit:505816|Define wmgUseEntitySchema (T221651 )]], part II (duration: 00m 49s) TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T221651: Define wmgUseWikibaseSchema variable in mediawiki/config (default false)

Stashbot added a comment. Mentioned in SAL (#wikimedia-operations) [2019-05-21T11:08:13Z] Synchronized wmf-config/InitialiseSettings.php: SWAT: [[gerrit:505816|Define wmgUseEntitySchema (T221651 )]], part I (duration: 00m 50s) TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T221651: Define wmgUseWikibaseSchema variable in mediawiki/config (default false)

gerritbot added a comment. Change 505816 **merged** by jenkins-bot: [operations/mediawiki-config@master] Define wmgUseEntitySchema https://gerrit.wikimedia.org/r/505816 TASK DETAIL https://phabricator.wikimedia.org/T221651 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Updated] T223542: Focus modal CTAs instead of publish button

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.6; 2019-05-21). TASK DETAIL https://phabricator.wikimedia.org/T223542 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Matthias_Geisler_WMDE, ReleaseTaggerBot Cc: Aklapper, Pablo-WMDE,

[Wikidata-bugs] [Maniphest] [Edited] T223963: Implement normalized Terms storage logic

alaa_wmde updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T223963 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: alaa_wmde Cc: Aklapper, alaa_wmde, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden,

[Wikidata-bugs] [Maniphest] [Commented On] T223524: WMHack19: Add Saami + Romani languages to Wikidata

Amire80 added a comment. Thank you. An email from linguists who are familiar with these languages will be perfect. TASK DETAIL https://phabricator.wikimedia.org/T223524 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Yupik, Amire80 Cc: Amire80,

[Wikidata-bugs] [Maniphest] [Commented On] T223542: Focus modal CTAs instead of publish button

gerritbot added a comment. Change 511450 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] termbox: use latest https://gerrit.wikimedia.org/r/511450 TASK DETAIL https://phabricator.wikimedia.org/T223542 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T221647: Port WikibaseLexeme senses.feature Selenium tests from Ruby to Node.js

gerritbot added a comment. Change 511679 had a related patch set uploaded (by Noa wmde; owner: Greta Doçi): [mediawiki/extensions/WikibaseLexeme@master] Remove sense.feature scenario file after tests were ported to node.js https://gerrit.wikimedia.org/r/511679 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T223524: WMHack19: Add Saami + Romani languages to Wikidata

Yupik added a comment. Ok, thanks. If I had realized the issues with the Romani languages last week already, it could have been as simple as going to the Department of Linguistics in Prague and

[Wikidata] Weekly Summary #365

*Here's your quick overview of what has been happening around Wikidata over the last week.* Discussions - New request for comments: Talk pages consultation 2019, phase 2 Events

[Wikidata-bugs] [Maniphest] [Commented On] T223524: WMHack19: Add Saami + Romani languages to Wikidata

Amire80 added a comment. I didn't //remove// any, but I had questions about the autonyms. See my comments at https://github.com/wikimedia/language-data/pull/53 Again, I don't really want to block it just because of the autonyms. I understand that these are very small, dead, or poorly

[Wikidata-bugs] [Maniphest] [Commented On] T223310: Investigate increase in tx bandwidth usage for mc1033

gerritbot added a comment. Change 511659 **merged** by Giuseppe Lavagetto: [operations/puppet@production] mediawiki::php: bump the APC shm size on php7 https://gerrit.wikimedia.org/r/511659 TASK DETAIL https://phabricator.wikimedia.org/T223310 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T223524: WMHack19: Add Saami + Romani languages to Wikidata

Yupik added a comment. In T223524#5199703 , @siebrand wrote: > I've retracted the patch to the language data on GitHub. There is too much debate on autonyms, and there is not the right place. All proposed autonyms here should first be

[Wikidata-bugs] [Maniphest] [Commented On] T223946: Wikidata wdtn:P214 values (VIAF) seem to be corrupt

Jheald added a comment. @Tagishsimon the WDQS tag is appropriate though, as it includes the pipeline for getting statements into the WDQS triplestore, and also any corruption issues happening there. Thanks for creating the ticket! # The LoC data does indeed seem to be clean - compare

[Wikidata-bugs] [Maniphest] [Created] T223968: Split Wikibase tests into unit and integration tests

Michael created this task. Michael added projects: Wikidata-Campsite (Wikidata-Campsite (TechDebt-Maintenance-∞)), Wikidata. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION Rather than our current setup in which all tests are bundled in a single directory split the unit

[Wikidata-bugs] [Maniphest] [Commented On] T223310: Investigate increase in tx bandwidth usage for mc1033

gerritbot added a comment. Change 511659 had a related patch set uploaded (by Giuseppe Lavagetto; owner: Giuseppe Lavagetto): [operations/puppet@production] mediawiki::php: bump the APC shm size on php7 https://gerrit.wikimedia.org/r/511659 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T220402: Introduce wikidata termbox SSR to kubernetes

Tarrow added a comment. @mobrovac and @akosiaris Sorry to drop in late to the conversation but I've been on holiday and then at the hackathon. I wanted to check a couple of things: In T220402#5186782 , @mobrovac wrote: >

[Wikidata-bugs] [Maniphest] [Updated] T223946: Wikidata wdtn:P214 values (VIAF) seem to be corrupt

Tagishsimon added a subscriber: matej_suchanek. Tagishsimon added a comment. Seems more likely it's a data input issue than a query issue @matej_suchanek, given that WDQS doesn't exhibit the same sort of error for analagous wdtn:, such as wdtn:P244

[Wikidata-bugs] [Maniphest] [Commented On] T223524: WMHack19: Add Saami + Romani languages to Wikidata

siebrand added a comment. I've retracted the patch to the language data on GitHub. There is too much debate on autonyms, and there is not the right place. All proposed autonyms here should first be fully sourced and approved by @Nikerabbit or @Amire80 before I'll create a patch. TASK

[Wikidata-bugs] [Maniphest] [Created] T223963: Implement normalized Terms storage logic

alaa_wmde created this task. alaa_wmde added projects: Wikidata wb_terms Trailblazing, Wikidata. TASK DESCRIPTION TASK DETAIL https://phabricator.wikimedia.org/T223963 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: alaa_wmde Cc: Aklapper,

[Wikidata-bugs] [Maniphest] [Commented On] T220219: Wikidata property statistics service

JeanFred added a comment. See also #tool-integraality TASK DETAIL https://phabricator.wikimedia.org/T220219 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: JeanFred Cc: Kpjas, agray,

[Wikidata-bugs] [Maniphest] [Updated] T209349: Importing the SPARQL2 template into a Wikibase instance from Wikidata

Tarrow added a comment. For the avoidance of confusion in order to make this work in the Wikibase-Containers environment we'll need to add Scributo so that these kind of templates work. For this there is a long standing task: T197649 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Edited] T223959: Add EntitySchema to bundle

Tarrow updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T223959 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tarrow Cc: Aklapper, Tarrow, darthmon_wmde, alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden,

[Wikidata-bugs] [Maniphest] [Created] T223959: Add EntitySchema to bundle

Tarrow created this task. Tarrow added a project: Wikibase-Containers. Restricted Application added a subscriber: Aklapper. Restricted Application added a project: Wikidata. TASK DESCRIPTION TASK DETAIL https://phabricator.wikimedia.org/T223959 WORKBOARD

[Wikidata-bugs] [Maniphest] [Commented On] T223310: Investigate increase in tx bandwidth usage for mc1033

elukey added a comment. Would it be possible to deploy https://gerrit.wikimedia.org/r/511612 before the weekly train? TASK DETAIL https://phabricator.wikimedia.org/T223310 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: elukey Cc: Tarrow,

[Wikidata-bugs] [Maniphest] [Updated] T223946: Wikidata wdtn:P214 values (VIAF) seem to be corrupt

matej_suchanek added a project: Wikidata-Query-Service. TASK DETAIL https://phabricator.wikimedia.org/T223946 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: matej_suchanek Cc: Aklapper, Tagishsimon, darthmon_wmde, alaa_wmde, Nandana, Lahi, Gq86,

[Wikidata-bugs] [Maniphest] [Updated] T223524: WMHack19: Add Saami + Romani languages to Wikidata

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.6; 2019-05-21). TASK DETAIL https://phabricator.wikimedia.org/T223524 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Yupik, ReleaseTaggerBot Cc: Amire80, jeblad, Lucas_Werkmeister_WMDE,

Re: [Wikidata-tech] [Wikidata] Shape Expressions arrive on Wikidata on May 28th

In other words: the benefits of standardized schemata but with less gatekeeping and exclusivity. Cheers! On Sun, May 19, 2019 at 3:32 PM Léa Lacroix wrote: > Hello all, > > After several months of development and testing together with the WikiProject > ShEx

[Wikidata-bugs] [Maniphest] [Commented On] T223524: WMHack19: Add Saami + Romani languages to Wikidata

gerritbot added a comment. Change 511054 **merged** by jenkins-bot: [mediawiki/core@master] Correct autonym for rmy (Vlax Romani) https://gerrit.wikimedia.org/r/511054 TASK DETAIL https://phabricator.wikimedia.org/T223524 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T223310: Investigate increase in tx bandwidth usage for mc1033

Joe added a comment. So, after turning off php7 this morning we saw no modification in the rate of requests to mc1033. It seems extremely probable that the switch of larger wikis to .wmf3 is what caused this regression. TASK DETAIL https://phabricator.wikimedia.org/T223310 EMAIL

[Wikidata-bugs] [Maniphest] [Updated] T192967: UX/UI suggestions towards a new "query helper/query builder" interface

waldyrious added a comment. In T192967#5196778 , @Jan_Dittrich wrote: > Great! Were there any overall findings that could help us in future designs? (For example, it seems that repeatedly, the UIs suggested to start with a property,

[Wikidata-bugs] [Maniphest] [Edited] T223524: WMHack19: Add Saami + Romani languages to Wikidata

siebrand updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T223524 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Yupik, siebrand Cc: Amire80, jeblad, Lucas_Werkmeister_WMDE, Trondtr, Nikerabbit, jhsoby-WMNO, Susannaanas,

[Wikidata-bugs] [Maniphest] [Edited] T223852: Collect information on SPARQL query builders

waldyrious updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T223852 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: waldyrious Cc: Bene, MichaelSchoenitzer_WMDE, MichaelSchoenitzer, Charlie_WMDE, Jakob_WMDE, waldyrious,

[Wikidata-bugs] [Maniphest] [Commented On] T223310: Investigate increase in tx bandwidth usage for mc1033

Joe added a comment. @kostajh for now I'm switching off php7 for other investigations, so we will know immediately if the additional traffic is due to that or not. TASK DETAIL https://phabricator.wikimedia.org/T223310 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Edited] T223853: Conduct usability experiments of SPARQL query builders

waldyrious updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T223853 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: waldyrious Cc: Jakob_WMDE, Charlie_WMDE, waldyrious, Aklapper, darthmon_wmde, alaa_wmde, Ferenczy,

[Wikidata-bugs] [Maniphest] [Edited] T223858: Bring Bene's sparql tool back to life

waldyrious updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T223858 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: waldyrious Cc: Charlie_WMDE, Lydia_Pintscher, Chicocvenancio, Aklapper, Jakob_WMDE, waldyrious, Bene,

[Wikidata-bugs] [Maniphest] [Edited] T223859: Bring the ppp-sparql tool back to life

waldyrious updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T223859 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: waldyrious Cc: Tpt, Aklapper, Jakob_WMDE, waldyrious, darthmon_wmde, alaa_wmde, Ferenczy, sarhan.alaa,

[Wikidata-bugs] [Maniphest] [Edited] T223853: Conduct usability experiments of SPARQL query builders

waldyrious updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T223853 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: waldyrious Cc: Jakob_WMDE, Charlie_WMDE, waldyrious, Aklapper, darthmon_wmde, alaa_wmde, Ferenczy,

[Wikidata-bugs] [Maniphest] [Edited] T223859: Bring the ppp-sparql tool back to life

waldyrious updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T223859 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: waldyrious Cc: Tpt, Aklapper, Jakob_WMDE, waldyrious, darthmon_wmde, alaa_wmde, Ferenczy, sarhan.alaa,

[Wikidata-bugs] [Maniphest] [Edited] T223858: Bring Bene's sparql tool back to life

waldyrious updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T223858 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: waldyrious Cc: Charlie_WMDE, Lydia_Pintscher, Chicocvenancio, Aklapper, Jakob_WMDE, waldyrious, Bene,

[Wikidata-bugs] [Maniphest] [Updated] T223858: Bring Bene's sparql tool back to life

waldyrious added a subscriber: Charlie_WMDE. waldyrious added a comment. @Lydia_Pintscher agreed. The reason I wanted these tools to be live was to allow them to be experimented on, and allow identifying the good design choices and UX patterns, to help build the default builder. T223852

[Wikidata-bugs] [Maniphest] [Commented On] T223856: Improve documentation for WMDE's Wikibase Docker images repository

waldyrious added a comment. PR #83 has been merged as well. I'll leave this open until @alaa_wmde voices his thoughts. TASK DETAIL https://phabricator.wikimedia.org/T223856 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: waldyrious Cc: Aklapper,

[Wikidata-bugs] [Maniphest] [Commented On] T223310: Investigate increase in tx bandwidth usage for mc1033

kostajh added a comment. > @kostajh @Catrope Could you rule out whether it's probably that the SpecialHomepage may have caused an increase in uncached Varnish traffic (e.g. anons starting sessions via edits or by viewing user sign-up page), or some other very chatty or large-value use of

<    1   2