[Wikidata-bugs] [Maniphest] [Reopened] T75380: [Task] Introduce factory for JS views

2015-10-04 Thread adrianheine
adrianheine reopened this task as "Open". adrianheine added a comment. There's much more to be done here. TASK DETAIL https://phabricator.wikimedia.org/T75380 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: Aklapper, Wik

[Wikidata-bugs] [Maniphest] [Commented On] T75380: [Task] Introduce factory for JS views

2015-10-01 Thread adrianheine
adrianheine added a comment. Second change: https://gerrit.wikimedia.org/r/#/c/242823/ TASK DETAIL https://phabricator.wikimedia.org/T75380 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: Aklapper, Wikidata-bugs, adrianheine

[Wikidata-bugs] [Maniphest] [Changed Subscribers] T92619: [Task] investigate failing Wikidata browsertests on jenkins

2015-10-01 Thread adrianheine
adrianheine added a subscriber: adrianheine. TASK DETAIL https://phabricator.wikimedia.org/T92619 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: adrianheine, Ricordisamoa, aude, JanZerebecki, hoo, dduvall, Liuxinyu970226

[Wikidata-bugs] [Maniphest] [Updated] T76216: [Epic] Language fallback

2015-09-30 Thread adrianheine
adrianheine removed a blocking task: T102295: [Bug] Language fallback seems to apply even when not requested. TASK DETAIL https://phabricator.wikimedia.org/T76216 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: Ricordisamoa, Aklapper

[Wikidata-bugs] [Maniphest] [Updated] T102295: [Bug] Language fallback seems to apply even when not requested

2015-09-30 Thread adrianheine
adrianheine removed a blocked task: T76216: [Epic] Language fallback. TASK DETAIL https://phabricator.wikimedia.org/T102295 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: Addshore, Ricordisamoa, daniel, Aklapper, Danmichaelo

[Wikidata-bugs] [Maniphest] [Commented On] T102295: [Bug] Language fallback seems to apply even when not requested

2015-09-30 Thread adrianheine
adrianheine added a subscriber: adrianheine. adrianheine added a comment. I removed it from the language fallback epic since this is about a related, but different feature. TASK DETAIL https://phabricator.wikimedia.org/T102295 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings

[Wikidata-bugs] [Maniphest] [Changed Project Column] T75380: Introduce factory for JS views

2015-09-30 Thread adrianheine
adrianheine moved this task to Review on the Wikidata-Sprint-2015-09-29 workboard. TASK DETAIL https://phabricator.wikimedia.org/T75380 WORKBOARD https://phabricator.wikimedia.org/project/board/1540/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences

[Wikidata-bugs] [Maniphest] [Commented On] T92387: expand in other languages box by default

2015-09-29 Thread adrianheine
adrianheine added a comment. The issue I mentioned would be resolved with https://gerrit.wikimedia.org/r/242084/. TASK DETAIL https://phabricator.wikimedia.org/T92387 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: Sjoerddebruin

[Wikidata-bugs] [Maniphest] [Raised Priority] T111015: [Task] change configuration to redirect users on mobile devices to the mobile site

2015-09-29 Thread adrianheine
adrianheine moved this task to Done on the Wikidata-Sprint-2015-09-15 workboard. adrianheine raised the priority of this task from "Normal" to "High". TASK DETAIL https://phabricator.wikimedia.org/T111015 WORKBOARD https://phabricator.wikimedia.org/project/board/1502

[Wikidata-bugs] [Maniphest] [Lowered Priority] T111015: [Task] change configuration to redirect users on mobile devices to the mobile site

2015-09-29 Thread adrianheine
adrianheine lowered the priority of this task from "High" to "Normal". TASK DETAIL https://phabricator.wikimedia.org/T111015 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tobi_WMDE_SW, adrianheine Cc: Tobi_WMDE_SW, Jan

[Wikidata-bugs] [Maniphest] [Commented On] T75380: Introduce factory for JS views

2015-09-29 Thread adrianheine
adrianheine added a comment. First change in a long chain: https://gerrit.wikimedia.org/r/#/c/242337 TASK DETAIL https://phabricator.wikimedia.org/T75380 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: Aklapper, Wikidata-bugs

[Wikidata-bugs] [Maniphest] [Edited] T75380: Introduce factory for JS views

2015-09-29 Thread adrianheine
adrianheine edited the task description. TASK DETAIL https://phabricator.wikimedia.org/T75380 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: Aklapper, Wikidata-bugs, adrianheine, Lydia_Pintscher, aude

[Wikidata-bugs] [Maniphest] [Changed Subscribers] T113665: SitesModuleWorker::getSitesHash() is slow

2015-09-27 Thread adrianheine
adrianheine added a subscriber: adrianheine. TASK DETAIL https://phabricator.wikimedia.org/T113665 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: adrianheine, Krenair, MaxSem, JeroenDeDauw, daniel, hoo, aude, ori, Aklapper, Wikidata

[Wikidata-bugs] [Maniphest] [Created] T113573: [Bug] PHP and JS disagree about which languages I'm interested in

2015-09-24 Thread adrianheine
adrianheine created this task. adrianheine added a subscriber: adrianheine. adrianheine added a project: MediaWiki-extensions-WikibaseRepository. Herald added a subscriber: Aklapper. Herald added a project: Wikidata. TASK DESCRIPTION **Use case 1** Steps to reproduce: * Log

[Wikidata-bugs] [Maniphest] [Changed Subscribers] T113573: [Bug] PHP and JS disagree about which languages I'm interested in

2015-09-24 Thread adrianheine
adrianheine added a subscriber: Bene. TASK DETAIL https://phabricator.wikimedia.org/T113573 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: Bene, Aklapper, adrianheine, Wikidata-bugs, aude

[Wikidata-bugs] [Maniphest] [Changed Subscribers] T113215: Allow adding more interlanguage link to articles that already have some links without going to the item page in the repo

2015-09-21 Thread adrianheine
adrianheine added a subscriber: adrianheine. TASK DETAIL https://phabricator.wikimedia.org/T113215 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: adrianheine, Lydia_Pintscher, daniel, Nemo_bis, Amire80, Aklapper, Wikidata-bugs, aude

[Wikidata-bugs] [Maniphest] [Updated] T112120: [Task] Move ValueView repository from github to gerrit

2015-09-16 Thread adrianheine
adrianheine added a comment. As I recently wrote in https://phabricator.wikimedia.org/T75020#1629613: > Even if some component does not depend on MediaWiki, I'd still consider it a > MediaWiki extension if it optionally provides MediaWiki integration. > Currently, all our resourc

[Wikidata-bugs] [Maniphest] [Commented On] T110811: [RFC] Unify our JS codestyle with the MW codestyle

2015-09-15 Thread adrianheine
adrianheine added a comment. I don't feel strongly about the coding style change. In the long run it probably makes sense to have Wikibase PHP and Wikibase JS as well as Wikibase JS and MediaWiki JS follow the same coding style. I'm not looking forward to the merge conflicts this will give us

[Wikidata-bugs] [Maniphest] [Commented On] T88422: Make language fallback indicators optional in EntityIdHtmlLinkFormatter

2015-09-14 Thread adrianheine
adrianheine added a subscriber: adrianheine. adrianheine added a comment. I suggest that we continue this discussion in tickets for the mentioned stories instead of on the ticket for the technical task. TASK DETAIL https://phabricator.wikimedia.org/T88422 EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] [Block] T76216: [Epic] Language fallback

2015-09-14 Thread adrianheine
adrianheine reopened blocking task T87754: Apply language fallbacks in JavaScript-formatted entity ids as "Open". TASK DETAIL https://phabricator.wikimedia.org/T76216 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: Ri

[Wikidata-bugs] [Maniphest] [Commented On] T90707: [Task] Implement deferred deserialization of Entity

2015-09-14 Thread adrianheine
adrianheine added a subscriber: adrianheine. adrianheine added a comment. In https://phabricator.wikimedia.org/T90707#1632816, @daniel wrote: > @Lydia_Pintscher we can only benchmark it after we implemented it. We could > profile the current code to identify hotspots, but we don't reall

[Wikidata-bugs] [Maniphest] [Commented On] T75020: [Task] Move JS and PHP view code to separate repo

2015-09-11 Thread adrianheine
adrianheine added a comment. Even if some component does not depend on MediaWiki, I'd still consider it a MediaWiki extension if it optionally provides MediaWiki integration. Currently, all our resource loading happens through `ResourceLoader`, and that won't change soon. TASK DETAIL https

[Wikidata-bugs] [Maniphest] [Commented On] T87754: Apply language fallbacks in JavaScript-formatted entity ids

2015-09-10 Thread adrianheine
adrianheine added a comment. How is this done? It's part of https://gerrit.wikimedia.org/r/#/c/201182/ (not done, not merged yet). TASK DETAIL https://phabricator.wikimedia.org/T87754 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc

[Wikidata-bugs] [Maniphest] [Commented On] T98208: [Bug] Widget to edit badges should use language fallback

2015-09-10 Thread adrianheine
adrianheine added a comment. Sure, why shouldn't it? Up until a working https://gerrit.wikimedia.org/r/#/c/201182/ is merged, there are no language fallbacks at all in front-end generated links. Dunno why https://phabricator.wikimedia.org/T87754 is closed either. TASK DETAIL https

[Wikidata-bugs] [Maniphest] [Commented On] T111343: [Bug] wikibase phpunit failures

2015-09-09 Thread adrianheine
adrianheine added a subscriber: adrianheine. adrianheine added a comment. I also get the `Wikibase\Tests\RepoHooksTest::testImportHandleRevisionXMLTag_hook` failure. TASK DETAIL https://phabricator.wikimedia.org/T111343 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel

[Wikidata-bugs] [Maniphest] [Commented On] T103086: Add "always fail" feature to WikibaseJavaScriptApi for testing purposes

2015-09-08 Thread adrianheine
adrianheine added a comment. There are obviously a lot of different fail cases: - Endpoints that return a failure - Endpoints that return something which triggers a failure (for example a parse error) in JS - Endpoints that don't return anything You can simulate all of them by passing

[Wikidata-bugs] [Maniphest] [Updated] T98208: [Bug] Widget to edit badges should use language fallback

2015-09-07 Thread adrianheine
adrianheine added a blocked task: T76216: language fallback. TASK DETAIL https://phabricator.wikimedia.org/T98208 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: adrianheine, Liuxinyu970226, daniel, thiemowmde, Lydia_Pintscher, Bene

[Wikidata-bugs] [Maniphest] [Updated] T98208: [Bug] Widget to edit badges should use language fallback

2015-09-07 Thread adrianheine
adrianheine removed a blocking task: T87754: Apply language fallbacks in JavaScript-formatted entity ids. TASK DETAIL https://phabricator.wikimedia.org/T98208 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: adrianheine

[Wikidata-bugs] [Maniphest] [Updated] T98208: [Bug] Widget to edit badges should use language fallback

2015-09-07 Thread adrianheine
adrianheine added a blocking task: T87754: Apply language fallbacks in JavaScript-formatted entity ids. TASK DETAIL https://phabricator.wikimedia.org/T98208 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: adrianheine, Liuxinyu970226

[Wikidata-bugs] [Maniphest] [Updated] T87754: Apply language fallbacks in JavaScript-formatted entity ids

2015-09-07 Thread adrianheine
adrianheine removed a blocked task: T98208: [Bug] Widget to edit badges should use language fallback. TASK DETAIL https://phabricator.wikimedia.org/T87754 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: Aklapper, Wikidata-bugs, aude

[Wikidata-bugs] [Maniphest] [Updated] T87754: Apply language fallbacks in JavaScript-formatted entity ids

2015-09-07 Thread adrianheine
adrianheine added a blocked task: T98208: [Bug] Widget to edit badges should use language fallback. TASK DETAIL https://phabricator.wikimedia.org/T87754 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: Aklapper, Wikidata-bugs, aude

[Wikidata-bugs] [Maniphest] [Updated] T76216: language fallback

2015-09-07 Thread adrianheine
adrianheine added a blocking task: T98208: [Bug] Widget to edit badges should use language fallback. TASK DETAIL https://phabricator.wikimedia.org/T76216 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine Cc: Ricordisamoa, Aklapper, He7d3r

[Wikidata-bugs] [Maniphest] [Updated] T98208: [Bug] Widget to edit badges should use language fallback

2015-09-07 Thread adrianheine
adrianheine added a comment. I think after https://gerrit.wikimedia.org/r/#/c/199296 this would be the same as https://phabricator.wikimedia.org/T87754. It's probably somewhere in that commit chain. TASK DETAIL https://phabricator.wikimedia.org/T98208 EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] [Commented On] T87579: investigate solutions for items with a large number of aliases

2015-04-20 Thread adrianheine
adrianheine added a comment. @Lydia_Pintscher I'm in favor of that approach, too. In practice (i. e., entity suggesters), labels and aliases identify items, not descriptions. Also, as you said, they are of the same kind, while label and description just serve the same purpose

[Wikidata-bugs] [Maniphest] [Commented On] T87579: investigate solutions for items with a large number of aliases

2015-04-20 Thread adrianheine
adrianheine added a comment. @Lydia_Pintscher I'm in favor of that approach, too. In practice (i. e., entity suggesters), labels and aliases identify items, not descriptions. Also, as you said, they are of the same kind, while label and description just serve the same purpose

[Wikidata-bugs] [Maniphest] [Updated] T93745: Move view related code into separate directory

2015-04-01 Thread adrianheine
adrianheine added a project: Patch-For-Review. adrianheine added a comment. https://gerrit.wikimedia.org/r/#/c/201175/ and parent changes. TASK DETAIL https://phabricator.wikimedia.org/T93745 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign

[Wikidata-bugs] [Maniphest] [Changed Project Column] T93745: Move view related code into separate directory

2015-04-01 Thread adrianheine
adrianheine moved this task to Review on the § Wikidata-Sprint-2015-03-24 workboard. TASK DETAIL https://phabricator.wikimedia.org/T93745 WORKBOARD https://phabricator.wikimedia.org/project/board/1128/ REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim

[Wikidata-bugs] [Maniphest] [Commented On] T70380: Factor dispatch logic out of maintenance script

2015-03-31 Thread adrianheine
adrianheine added a subscriber: adrianheine. adrianheine added a comment. Why is this in review? TASK DETAIL https://phabricator.wikimedia.org/T70380 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] [Changed Project Column] T93745: Move view related code into separate directory

2015-03-31 Thread adrianheine
adrianheine moved this task to Doing on the § Wikidata-Sprint-2015-03-24 workboard. TASK DETAIL https://phabricator.wikimedia.org/T93745 WORKBOARD https://phabricator.wikimedia.org/project/board/1128/ REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe

[Wikidata-bugs] [Maniphest] [Changed Project Column] T94552: Add language fallback for badge labels

2015-03-31 Thread adrianheine
adrianheine moved this task to Review on the § Wikidata-Sprint-2015-03-24 workboard. TASK DETAIL https://phabricator.wikimedia.org/T94552 WORKBOARD https://phabricator.wikimedia.org/project/board/1128/ REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim

[Wikidata-bugs] [Maniphest] [Updated] T94552: Add language fallback for badge labels

2015-03-31 Thread adrianheine
adrianheine added a project: § Wikidata-Sprint-2015-03-24. TASK DETAIL https://phabricator.wikimedia.org/T94552 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel

[Wikidata-bugs] [Maniphest] [Changed Project Column] T94552: Add language fallback for badge labels

2015-03-31 Thread adrianheine
adrianheine moved this task to Doing on the § Wikidata-Sprint-2015-03-24 workboard. TASK DETAIL https://phabricator.wikimedia.org/T94552 WORKBOARD https://phabricator.wikimedia.org/project/board/1128/ REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe

[Wikidata-bugs] [Maniphest] [Created] T94552: Add language fallback for badge labels

2015-03-31 Thread adrianheine
adrianheine created this task. adrianheine claimed this task. adrianheine added projects: Wikidata, MediaWiki-extensions-WikibaseRepository. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION TASK DETAIL https://phabricator.wikimedia.org/T94552 REPLY HANDLER ACTIONS

[Wikidata-bugs] [Maniphest] [Created] T94563: Support language fallbacks in wbformatvalue

2015-03-31 Thread adrianheine
adrianheine created this task. adrianheine added a subscriber: daniel. adrianheine added projects: Wikidata, MediaWiki-extensions-WikibaseRepository. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION Currently, only one language can be passed via `lang` option. The API

[Wikidata-bugs] [Maniphest] [Commented On] T94159: Put lastrevid of linked entities in mw.config.values.wbUsedEntities

2015-03-30 Thread adrianheine
adrianheine added a comment. That sounds great :) I think you can and should use `wbgetentities`. If you set `props=claims|info`, you only get the claims and meta data, which shouldn't be to expensive. TASK DETAIL https://phabricator.wikimedia.org/T94159 REPLY HANDLER ACTIONS Reply

[Wikidata-bugs] [Maniphest] [Changed Project Column] T89300: Add qualifier button should automatically focus text box

2015-03-30 Thread adrianheine
adrianheine moved this task to Review on the § Wikidata-Sprint-2015-03-24 workboard. TASK DETAIL https://phabricator.wikimedia.org/T89300 WORKBOARD https://phabricator.wikimedia.org/project/board/1128/ REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim

[Wikidata-bugs] [Maniphest] [Updated] T94393: Switch wikidata qunit jobs from qunit to qunit-karma

2015-03-30 Thread adrianheine
adrianheine added a project: § Wikidata-Sprint-2015-03-24. TASK DETAIL https://phabricator.wikimedia.org/T94393 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel

[Wikidata-bugs] [Maniphest] [Updated] T94394: Remove explicit jquery.qunit loading from DataValuesJavaScript

2015-03-30 Thread adrianheine
adrianheine added a project: § Wikidata-Sprint-2015-03-24. TASK DETAIL https://phabricator.wikimedia.org/T94394 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel

[Wikidata-bugs] [Maniphest] [Updated] T94395: Remove explicit jquery.qunit loading from ValueView

2015-03-30 Thread adrianheine
adrianheine added a project: § Wikidata-Sprint-2015-03-24. TASK DETAIL https://phabricator.wikimedia.org/T94395 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel

[Wikidata-bugs] [Maniphest] [Changed Project Column] T94395: Remove explicit jquery.qunit loading from ValueView

2015-03-30 Thread adrianheine
adrianheine moved this task to Review on the § Wikidata-Sprint-2015-03-24 workboard. TASK DETAIL https://phabricator.wikimedia.org/T94395 WORKBOARD https://phabricator.wikimedia.org/project/board/1128/ REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim

[Wikidata-bugs] [Maniphest] [Created] T94394: Remove explicit jquery.qunit loading from DataValuesJavaScript

2015-03-30 Thread adrianheine
adrianheine created this task. adrianheine claimed this task. adrianheine added projects: Wikidata, DataValues-JavaScript. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION TASK DETAIL https://phabricator.wikimedia.org/T94394 REPLY HANDLER ACTIONS Reply to comment

[Wikidata-bugs] [Maniphest] [Created] T94395: Remove explicit jquery.qunit loading from ValueView

2015-03-30 Thread adrianheine
adrianheine created this task. adrianheine claimed this task. adrianheine added projects: Wikidata, ValueView. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION TASK DETAIL https://phabricator.wikimedia.org/T94395 REPLY HANDLER ACTIONS Reply to comment or attach files

[Wikidata-bugs] [Maniphest] [Updated] T94393: Switch wikidata qunit jobs from qunit to qunit-karma

2015-03-30 Thread adrianheine
adrianheine added a blocking task: T94395: Remove explicit jquery.qunit loading from ValueView. TASK DETAIL https://phabricator.wikimedia.org/T94393 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] [Updated] T94395: Remove explicit jquery.qunit loading from ValueView

2015-03-30 Thread adrianheine
adrianheine added a blocked task: T94393: Switch wikidata qunit jobs from qunit to qunit-karma. TASK DETAIL https://phabricator.wikimedia.org/T94395 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] [Updated] T94395: Remove explicit jquery.qunit loading from ValueView

2015-03-30 Thread adrianheine
adrianheine added a project: Patch-For-Review. adrianheine added a comment. https://github.com/wmde/ValueView/pull/167 TASK DETAIL https://phabricator.wikimedia.org/T94395 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL

[Wikidata-bugs] [Maniphest] [Changed Project Column] T94394: Remove explicit jquery.qunit loading from DataValuesJavaScript

2015-03-30 Thread adrianheine
adrianheine moved this task to Review on the § Wikidata-Sprint-2015-03-24 workboard. TASK DETAIL https://phabricator.wikimedia.org/T94394 WORKBOARD https://phabricator.wikimedia.org/project/board/1128/ REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim

[Wikidata-bugs] [Maniphest] [Changed Project Column] T94393: Switch wikidata qunit jobs from qunit to qunit-karma

2015-03-30 Thread adrianheine
adrianheine moved this task to Review on the § Wikidata-Sprint-2015-03-24 workboard. TASK DETAIL https://phabricator.wikimedia.org/T94393 WORKBOARD https://phabricator.wikimedia.org/project/board/1128/ REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim

[Wikidata-bugs] [Maniphest] [Updated] T94394: Remove explicit jquery.qunit loading from DataValuesJavaScript

2015-03-30 Thread adrianheine
adrianheine added a project: Patch-For-Review. adrianheine added a comment. https://github.com/wmde/DataValuesJavascript/pull/75 TASK DETAIL https://phabricator.wikimedia.org/T94394 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username

[Wikidata-bugs] [Maniphest] [Commented On] T94159: Put lastrevid of linked entities in mw.config.values.wbUsedEntities

2015-03-27 Thread adrianheine
adrianheine added a subscriber: adrianheine. adrianheine added a comment. I'm currently working on removing wbUsedEntities, see https://gerrit.wikimedia.org/r/#/c/197290/. You would have to do an API request then, anyways. As for the current page, `wgCurRevisionId` gives you the revid, but I

[Wikidata-bugs] [Maniphest] [Lowered Priority] T62341: Load widgets on demand

2015-03-27 Thread adrianheine
adrianheine lowered the priority of this task from High to Low. adrianheine added a comment. Currently we are trying to do less on page load within the current architecture, but we are not planning to completely defer initialization. TASK DETAIL https://phabricator.wikimedia.org/T62341

[Wikidata-bugs] [Maniphest] [Updated] T88428: Drop referenced entities from JS config

2015-03-27 Thread adrianheine
adrianheine removed a blocking task: T88426: Server-side rendering for all property links in the JS UI. TASK DETAIL https://phabricator.wikimedia.org/T88428 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Updated] T88426: Server-side rendering for all property links in the JS UI

2015-03-27 Thread adrianheine
adrianheine removed a blocked task: T88428: Drop referenced entities from JS config. TASK DETAIL https://phabricator.wikimedia.org/T88426 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] [Commented On] T94159: Put lastrevid of linked entities in mw.config.values.wbUsedEntities

2015-03-27 Thread adrianheine
adrianheine added a comment. Can you give me a use-case for editing an entity referenced by the entity you're currently on? I think it makes more sense to provide the lastrevid with `wbgetclaims`, and I think you definitely should run `wbgetclaims` before doing `wbsetclaims`, otherwise you

[Wikidata-bugs] [Maniphest] [Commented On] T93863: order in other language box by order of babel boxes

2015-03-25 Thread adrianheine
adrianheine added a comment. Afaik they are not cached, but injected afterwards with the TextInjector. So, no issue with caching. TASK DETAIL https://phabricator.wikimedia.org/T93863 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign

[Wikidata-bugs] [Maniphest] [Updated] T93809: CommonsMedia gadget broken

2015-03-25 Thread adrianheine
adrianheine added a comment. I suppose https://phabricator.wikimedia.org/rEWBA00145a8dcbdb548216a39b69ccc713734d37bdfe introduced that. The ValueView appears to not be rendered anymore on snakview initialization. A maybe related issue is that the valueview never switches `valueview-ineditmode

[Wikidata-bugs] [Maniphest] [Changed Project Column] T93073: When entering new statement + qualifier, the qualifier is not rendered on save

2015-03-24 Thread adrianheine
adrianheine moved this task to Done on the § Wikidata-Sprint-2015-03-11 workboard. TASK DETAIL https://phabricator.wikimedia.org/T93073 WORKBOARD https://phabricator.wikimedia.org/project/board/1095/ REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe

[Wikidata-bugs] [Maniphest] [Closed] T93073: When entering new statement + qualifier, the qualifier is not rendered on save

2015-03-24 Thread adrianheine
adrianheine closed this task as Resolved. adrianheine claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T93073 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org

[Wikidata-bugs] [Maniphest] [Commented On] T93741: Create place to put common Wikibase services

2015-03-24 Thread adrianheine
adrianheine added a subscriber: adrianheine. adrianheine added a comment. I think the following interfaces might be candidates for moving there - Wikibase\Lib\EntityIdFormatter - Wikibase\Lib\SnakFormatter - Wikibase\Lib\Store\EntityLookup - Wikibase\Lib\Store\LabelLookup TASK DETAIL https

[Wikidata-bugs] [Maniphest] [Commented On] T93773: Remove wbUserCanEdit and wbUserIsBlocked config variables

2015-03-24 Thread adrianheine
adrianheine added a subscriber: adrianheine. adrianheine added a comment. I agree. It would be great if the toolbar controller would just initialize on top of existing toolbars and not add missing ones on the fly. We would need to add empty toolbars for statements to the static HTML

[Wikidata-bugs] [Maniphest] [Closed] T93183: Narrow fields in Special:NewItem and Special:NewProperty

2015-03-24 Thread adrianheine
adrianheine closed this task as Resolved. adrianheine added a subscriber: adrianheine. TASK DETAIL https://phabricator.wikimedia.org/T93183 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] [Changed Project Column] T93183: Narrow fields in Special:NewItem and Special:NewProperty

2015-03-24 Thread adrianheine
adrianheine moved this task to Done on the § Wikidata-Sprint-2015-03-11 workboard. TASK DETAIL https://phabricator.wikimedia.org/T93183 WORKBOARD https://phabricator.wikimedia.org/project/board/1095/ REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe

[Wikidata-bugs] [Maniphest] [Unblock] T77991: File based caching: Decide on file format

2015-03-24 Thread adrianheine
adrianheine closed blocking task T77990: File based caching: Split of site lookup for readonly access as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T77991 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL

[Wikidata-bugs] [Maniphest] [Closed] T77990: File based caching: Split of site lookup for readonly access

2015-03-24 Thread adrianheine
adrianheine closed this task as Resolved. adrianheine added a subscriber: adrianheine. TASK DETAIL https://phabricator.wikimedia.org/T77990 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] [Unblock] T47532: Add file-based cached implementation of SiteStore

2015-03-24 Thread adrianheine
adrianheine closed blocking task T77990: File based caching: Split of site lookup for readonly access as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T47532 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T93773: Remove wbUserCanEdit and wbUserIsBlocked config variables

2015-03-24 Thread adrianheine
adrianheine added a comment. Adrian_WMDE: aude: We could also replace the config var with a $( '.wikibase-toolbar' ).length 0 check Adrian_WMDE: That would be pretty crude, but work TASK DETAIL https://phabricator.wikimedia.org/T93773 REPLY HANDLER ACTIONS Reply to comment

[Wikidata-bugs] [Maniphest] [Changed Subscribers] T50143: Implement complete RDF mapping for entities (tracking)

2015-03-23 Thread adrianheine
adrianheine removed a subscriber: adrianheine. TASK DETAIL https://phabricator.wikimedia.org/T50143 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel

[Wikidata-bugs] [Maniphest] [Commented On] T92949: No javascript loaded on test.wikidata

2015-03-19 Thread adrianheine
adrianheine added a subscriber: adrianheine. adrianheine added a comment. Why is this in done? TASK DETAIL https://phabricator.wikimedia.org/T92949 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] [Lowered Priority] T87759: Allow simultaneous editing of mainsnak and references

2015-03-19 Thread adrianheine
adrianheine moved this task to Doing on the § Wikidata-Sprint-2015-03-11 workboard. adrianheine lowered the priority of this task from High to Normal. TASK DETAIL https://phabricator.wikimedia.org/T87759 WORKBOARD https://phabricator.wikimedia.org/project/board/1095/ REPLY HANDLER ACTIONS

[Wikidata-bugs] [Maniphest] [Commented On] T92949: No javascript loaded on test.wikidata

2015-03-19 Thread adrianheine
adrianheine added a comment. Ok, cool. I suppose the linked change is fixing the underlying issue? TASK DETAIL https://phabricator.wikimedia.org/T92949 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] [Commented On] T63601: DataTypes should pass jshint

2015-03-19 Thread adrianheine
adrianheine added a comment. In https://phabricator.wikimedia.org/T63601#1125148, @hashar wrote: @adrianheine should we delete in Gerrit the mediawiki/extensions/DataTypes repository ? Yeah, we should. It doesn't even mirror the current HEAD. TASK DETAIL https

[Wikidata-bugs] [Maniphest] [Changed Subscribers] T93207: Better namespace URI for the wikibase ontology

2015-03-19 Thread adrianheine
adrianheine added a subscriber: adrianheine. TASK DETAIL https://phabricator.wikimedia.org/T93207 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel

[Wikidata-bugs] [Maniphest] [Changed Project Column] T88425: Frontend JS should not re-render qualifiers and references upon load.

2015-03-17 Thread adrianheine
adrianheine moved this task to Done on the § Wikidata-Sprint-2015-03-11 workboard. TASK DETAIL https://phabricator.wikimedia.org/T88425 WORKBOARD https://phabricator.wikimedia.org/project/board/1095/ REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe

[Wikidata-bugs] [Maniphest] [Closed] T88425: Frontend JS should not re-render qualifiers and references upon load.

2015-03-17 Thread adrianheine
adrianheine closed this task as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T88425 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences

[Wikidata-bugs] [Maniphest] [Commented On] T88275: No language fallback applied for property labels on qualifiers and references in JS UI.

2015-03-17 Thread adrianheine
adrianheine added a comment. We can indeed skip 3. I removed `wbUsedEntities` in https://gerrit.wikimedia.org/r/#/c/197290/. TASK DETAIL https://phabricator.wikimedia.org/T88275 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username

[Wikidata-bugs] [Maniphest] [Commented On] T66084: Time data-type inconsistently zero-pads year value (dates earlier than year 1000?)

2015-03-17 Thread adrianheine
adrianheine added a subscriber: adrianheine. adrianheine added a comment. Only https://github.com/wmde/DataValuesJavascript/pull/71 is still open. TASK DETAIL https://phabricator.wikimedia.org/T66084 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe

[Wikidata-bugs] [Maniphest] [Changed Project Column] T78526: Special:GoToLinkedPage should support redirects

2015-03-17 Thread adrianheine
adrianheine moved this task to Doing on the § Wikidata-Sprint-2015-03-11 workboard. TASK DETAIL https://phabricator.wikimedia.org/T78526 WORKBOARD https://phabricator.wikimedia.org/project/board/1095/ REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe

[Wikidata-bugs] [Maniphest] [Unblock] T74184: fix the qunit tests for wikidata: mwext-Wikibase-qunit

2015-03-16 Thread adrianheine
adrianheine closed blocking task T91376: Make ValueView qunit tests independent of focus. as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T74184 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Closed] T91376: Make ValueView qunit tests independent of focus.

2015-03-16 Thread adrianheine
adrianheine closed this task as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T91376 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences

[Wikidata-bugs] [Maniphest] [Changed Project Column] T91376: Make ValueView qunit tests independent of focus.

2015-03-16 Thread adrianheine
adrianheine moved this task to Done on the § Wikidata-Sprint-2015-03-11 workboard. TASK DETAIL https://phabricator.wikimedia.org/T91376 WORKBOARD https://phabricator.wikimedia.org/project/board/1095/ REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe

[Wikidata-bugs] [Maniphest] [Commented On] T74184: fix the qunit tests for wikidata: mwext-Wikibase-qunit

2015-03-16 Thread adrianheine
adrianheine added a comment. QUnit tests passed for me for the first time in https://gerrit.wikimedia.org/r/#/c/196241/. TASK DETAIL https://phabricator.wikimedia.org/T74184 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username

[Wikidata-bugs] [Maniphest] [Commented On] T74666: Unify view-implementations in JS frontend

2015-03-16 Thread adrianheine
adrianheine added a comment. Sorta. Henning did a great work leveling our widget implementations, but he didn't really do what I lined out here. I still think that would make sense. TASK DETAIL https://phabricator.wikimedia.org/T74666 REPLY HANDLER ACTIONS Reply to comment or attach files

[Wikidata-bugs] [Maniphest] [Commented On] T91376: Make ValueView qunit tests independent of focus.

2015-03-16 Thread adrianheine
adrianheine added a comment. https://github.com/wmde/ValueView/pull/166 TASK DETAIL https://phabricator.wikimedia.org/T91376 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org

[Wikidata-bugs] [Maniphest] [Commented On] T75306: Inject variationsFactory into snakview

2015-03-16 Thread adrianheine
adrianheine added a comment. Still reasonable to do, but not holding us back in any way currently. TASK DETAIL https://phabricator.wikimedia.org/T75306 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] [Commented On] T92387: expand in other languages box by default

2015-03-12 Thread adrianheine
adrianheine added a comment. A slightly related thing: Currently you cannot expand without JS enabled, which means if you don't have working JS, the box might just not be there. If it's collapsed by default, you might not even now that there should be something. If it's shown by default, you

[Wikidata-bugs] [Maniphest] [Commented On] T87640: Wikidata edits do not update page watched icon

2015-03-12 Thread adrianheine
adrianheine added a comment. Could someone verify? TASK DETAIL https://phabricator.wikimedia.org/T87640 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel

[Wikidata-bugs] [Maniphest] [Commented On] T74184: fix the qunit tests for wikidata: mwext-Wikibase-qunit

2015-03-12 Thread adrianheine
adrianheine added a comment. Two of the last three qunit jobs failed with database locked errors: https://integration.wikimedia.org/ci/job/mwext-Wikibase-qunit/7692/ https://integration.wikimedia.org/ci/job/mwext-Wikibase-qunit/7691/ One failed with the usual 0/0 assertions warning aka resource

[Wikidata-bugs] [Maniphest] [Commented On] T55849: Migrate current selenium tests to cucumber

2015-03-12 Thread adrianheine
adrianheine added a comment. In https://phabricator.wikimedia.org/T55849#1103629, @adrianheine wrote: Are there still unmigrated tests? Yes, there are. They are at https://github.com/wmde/WikidataBrowserTestsRSpec. TASK DETAIL https://phabricator.wikimedia.org/T55849 REPLY HANDLER

[Wikidata-bugs] [Maniphest] [Commented On] T44510: Code coverage extremely low - technical debt

2015-03-12 Thread adrianheine
adrianheine added a subscriber: adrianheine. adrianheine added a comment. PHPUnit just gave me 79.18% code lines coverage on client. Worst offenders are UpdateRepo/, modules/, recentchanges/. TASK DETAIL https://phabricator.wikimedia.org/T44510 REPLY HANDLER ACTIONS Reply to comment

[Wikidata-bugs] [Maniphest] [Commented On] T74184: fix the qunit tests for wikidata: mwext-Wikibase-qunit

2015-03-12 Thread adrianheine
adrianheine added a comment. Sorry. It's way done in the mw-debug-www.log build artifact. TASK DETAIL https://phabricator.wikimedia.org/T74184 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] [Changed Subscribers] T92505: Wikidata architecture review and feedback

2015-03-12 Thread adrianheine
adrianheine added a subscriber: adrianheine. TASK DETAIL https://phabricator.wikimedia.org/T92505 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel

<    3   4   5   6   7   8   9   10   11   12   >