adrianheine reopened this task as "Open".
adrianheine added a comment.
There's much more to be done here.
TASK DETAIL
https://phabricator.wikimedia.org/T75380
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: adrianheine
Cc: Aklapper, Wik
adrianheine added a comment.
Second change: https://gerrit.wikimedia.org/r/#/c/242823/
TASK DETAIL
https://phabricator.wikimedia.org/T75380
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: adrianheine
Cc: Aklapper, Wikidata-bugs, adrianheine
adrianheine added a subscriber: adrianheine.
TASK DETAIL
https://phabricator.wikimedia.org/T92619
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: adrianheine
Cc: adrianheine, Ricordisamoa, aude, JanZerebecki, hoo, dduvall,
Liuxinyu970226
adrianheine removed a blocking task: T102295: [Bug] Language fallback seems to
apply even when not requested.
TASK DETAIL
https://phabricator.wikimedia.org/T76216
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: adrianheine
Cc: Ricordisamoa, Aklapper
adrianheine removed a blocked task: T76216: [Epic] Language fallback.
TASK DETAIL
https://phabricator.wikimedia.org/T102295
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: adrianheine
Cc: Addshore, Ricordisamoa, daniel, Aklapper, Danmichaelo
adrianheine added a subscriber: adrianheine.
adrianheine added a comment.
I removed it from the language fallback epic since this is about a related, but
different feature.
TASK DETAIL
https://phabricator.wikimedia.org/T102295
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings
adrianheine moved this task to Review on the Wikidata-Sprint-2015-09-29
workboard.
TASK DETAIL
https://phabricator.wikimedia.org/T75380
WORKBOARD
https://phabricator.wikimedia.org/project/board/1540/
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences
adrianheine added a comment.
The issue I mentioned would be resolved with
https://gerrit.wikimedia.org/r/242084/.
TASK DETAIL
https://phabricator.wikimedia.org/T92387
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: adrianheine
Cc: Sjoerddebruin
adrianheine moved this task to Done on the Wikidata-Sprint-2015-09-15 workboard.
adrianheine raised the priority of this task from "Normal" to "High".
TASK DETAIL
https://phabricator.wikimedia.org/T111015
WORKBOARD
https://phabricator.wikimedia.org/project/board/1502
adrianheine lowered the priority of this task from "High" to "Normal".
TASK DETAIL
https://phabricator.wikimedia.org/T111015
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Tobi_WMDE_SW, adrianheine
Cc: Tobi_WMDE_SW, Jan
adrianheine added a comment.
First change in a long chain: https://gerrit.wikimedia.org/r/#/c/242337
TASK DETAIL
https://phabricator.wikimedia.org/T75380
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: adrianheine
Cc: Aklapper, Wikidata-bugs
adrianheine edited the task description.
TASK DETAIL
https://phabricator.wikimedia.org/T75380
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: adrianheine
Cc: Aklapper, Wikidata-bugs, adrianheine, Lydia_Pintscher, aude
adrianheine added a subscriber: adrianheine.
TASK DETAIL
https://phabricator.wikimedia.org/T113665
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: adrianheine
Cc: adrianheine, Krenair, MaxSem, JeroenDeDauw, daniel, hoo, aude, ori,
Aklapper, Wikidata
adrianheine created this task.
adrianheine added a subscriber: adrianheine.
adrianheine added a project: MediaWiki-extensions-WikibaseRepository.
Herald added a subscriber: Aklapper.
Herald added a project: Wikidata.
TASK DESCRIPTION
**Use case 1**
Steps to reproduce:
* Log
adrianheine added a subscriber: Bene.
TASK DETAIL
https://phabricator.wikimedia.org/T113573
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: adrianheine
Cc: Bene, Aklapper, adrianheine, Wikidata-bugs, aude
adrianheine added a subscriber: adrianheine.
TASK DETAIL
https://phabricator.wikimedia.org/T113215
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: adrianheine
Cc: adrianheine, Lydia_Pintscher, daniel, Nemo_bis, Amire80, Aklapper,
Wikidata-bugs, aude
adrianheine added a comment.
As I recently wrote in https://phabricator.wikimedia.org/T75020#1629613:
> Even if some component does not depend on MediaWiki, I'd still consider it a
> MediaWiki extension if it optionally provides MediaWiki integration.
> Currently, all our resourc
adrianheine added a comment.
I don't feel strongly about the coding style change. In the long run it
probably makes sense to have Wikibase PHP and Wikibase JS as well as Wikibase
JS and MediaWiki JS follow the same coding style. I'm not looking forward to
the merge conflicts this will give us
adrianheine added a subscriber: adrianheine.
adrianheine added a comment.
I suggest that we continue this discussion in tickets for the mentioned stories
instead of on the ticket for the technical task.
TASK DETAIL
https://phabricator.wikimedia.org/T88422
EMAIL PREFERENCES
https
adrianheine reopened blocking task T87754: Apply language fallbacks in
JavaScript-formatted entity ids as "Open".
TASK DETAIL
https://phabricator.wikimedia.org/T76216
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: adrianheine
Cc: Ri
adrianheine added a subscriber: adrianheine.
adrianheine added a comment.
In https://phabricator.wikimedia.org/T90707#1632816, @daniel wrote:
> @Lydia_Pintscher we can only benchmark it after we implemented it. We could
> profile the current code to identify hotspots, but we don't reall
adrianheine added a comment.
Even if some component does not depend on MediaWiki, I'd still consider it a
MediaWiki extension if it optionally provides MediaWiki integration. Currently,
all our resource loading happens through `ResourceLoader`, and that won't
change soon.
TASK DETAIL
https
adrianheine added a comment.
How is this done? It's part of https://gerrit.wikimedia.org/r/#/c/201182/ (not
done, not merged yet).
TASK DETAIL
https://phabricator.wikimedia.org/T87754
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: adrianheine
Cc
adrianheine added a comment.
Sure, why shouldn't it? Up until a working
https://gerrit.wikimedia.org/r/#/c/201182/ is merged, there are no language
fallbacks at all in front-end generated links. Dunno why
https://phabricator.wikimedia.org/T87754 is closed either.
TASK DETAIL
https
adrianheine added a subscriber: adrianheine.
adrianheine added a comment.
I also get the
`Wikibase\Tests\RepoHooksTest::testImportHandleRevisionXMLTag_hook` failure.
TASK DETAIL
https://phabricator.wikimedia.org/T111343
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel
adrianheine added a comment.
There are obviously a lot of different fail cases:
- Endpoints that return a failure
- Endpoints that return something which triggers a failure (for example a parse
error) in JS
- Endpoints that don't return anything
You can simulate all of them by passing
adrianheine added a blocked task: T76216: language fallback.
TASK DETAIL
https://phabricator.wikimedia.org/T98208
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: adrianheine
Cc: adrianheine, Liuxinyu970226, daniel, thiemowmde, Lydia_Pintscher, Bene
adrianheine removed a blocking task: T87754: Apply language fallbacks in
JavaScript-formatted entity ids.
TASK DETAIL
https://phabricator.wikimedia.org/T98208
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: adrianheine
Cc: adrianheine
adrianheine added a blocking task: T87754: Apply language fallbacks in
JavaScript-formatted entity ids.
TASK DETAIL
https://phabricator.wikimedia.org/T98208
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: adrianheine
Cc: adrianheine, Liuxinyu970226
adrianheine removed a blocked task: T98208: [Bug] Widget to edit badges should
use language fallback.
TASK DETAIL
https://phabricator.wikimedia.org/T87754
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: adrianheine
Cc: Aklapper, Wikidata-bugs, aude
adrianheine added a blocked task: T98208: [Bug] Widget to edit badges should
use language fallback.
TASK DETAIL
https://phabricator.wikimedia.org/T87754
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: adrianheine
Cc: Aklapper, Wikidata-bugs, aude
adrianheine added a blocking task: T98208: [Bug] Widget to edit badges should
use language fallback.
TASK DETAIL
https://phabricator.wikimedia.org/T76216
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: adrianheine
Cc: Ricordisamoa, Aklapper, He7d3r
adrianheine added a comment.
I think after https://gerrit.wikimedia.org/r/#/c/199296 this would be the same
as https://phabricator.wikimedia.org/T87754. It's probably somewhere in that
commit chain.
TASK DETAIL
https://phabricator.wikimedia.org/T98208
EMAIL PREFERENCES
https
adrianheine added a comment.
@Lydia_Pintscher I'm in favor of that approach, too. In practice (i. e., entity
suggesters), labels and aliases identify items, not descriptions. Also, as you
said, they are of the same kind, while label and description just serve the
same purpose
adrianheine added a comment.
@Lydia_Pintscher I'm in favor of that approach, too. In practice (i. e., entity
suggesters), labels and aliases identify items, not descriptions. Also, as you
said, they are of the same kind, while label and description just serve the
same purpose
adrianheine added a project: Patch-For-Review.
adrianheine added a comment.
https://gerrit.wikimedia.org/r/#/c/201175/ and parent changes.
TASK DETAIL
https://phabricator.wikimedia.org/T93745
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign
adrianheine moved this task to Review on the § Wikidata-Sprint-2015-03-24
workboard.
TASK DETAIL
https://phabricator.wikimedia.org/T93745
WORKBOARD
https://phabricator.wikimedia.org/project/board/1128/
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim
adrianheine added a subscriber: adrianheine.
adrianheine added a comment.
Why is this in review?
TASK DETAIL
https://phabricator.wikimedia.org/T70380
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign
username.
EMAIL PREFERENCES
https
adrianheine moved this task to Doing on the § Wikidata-Sprint-2015-03-24
workboard.
TASK DETAIL
https://phabricator.wikimedia.org/T93745
WORKBOARD
https://phabricator.wikimedia.org/project/board/1128/
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe
adrianheine moved this task to Review on the § Wikidata-Sprint-2015-03-24
workboard.
TASK DETAIL
https://phabricator.wikimedia.org/T94552
WORKBOARD
https://phabricator.wikimedia.org/project/board/1128/
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim
adrianheine added a project: § Wikidata-Sprint-2015-03-24.
TASK DETAIL
https://phabricator.wikimedia.org/T94552
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign
username.
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel
adrianheine moved this task to Doing on the § Wikidata-Sprint-2015-03-24
workboard.
TASK DETAIL
https://phabricator.wikimedia.org/T94552
WORKBOARD
https://phabricator.wikimedia.org/project/board/1128/
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe
adrianheine created this task.
adrianheine claimed this task.
adrianheine added projects: Wikidata, MediaWiki-extensions-WikibaseRepository.
Restricted Application added a subscriber: Aklapper.
TASK DESCRIPTION
TASK DETAIL
https://phabricator.wikimedia.org/T94552
REPLY HANDLER ACTIONS
adrianheine created this task.
adrianheine added a subscriber: daniel.
adrianheine added projects: Wikidata, MediaWiki-extensions-WikibaseRepository.
Restricted Application added a subscriber: Aklapper.
TASK DESCRIPTION
Currently, only one language can be passed via `lang` option. The API
adrianheine added a comment.
That sounds great :) I think you can and should use `wbgetentities`. If you set
`props=claims|info`, you only get the claims and meta data, which shouldn't be
to expensive.
TASK DETAIL
https://phabricator.wikimedia.org/T94159
REPLY HANDLER ACTIONS
Reply
adrianheine moved this task to Review on the § Wikidata-Sprint-2015-03-24
workboard.
TASK DETAIL
https://phabricator.wikimedia.org/T89300
WORKBOARD
https://phabricator.wikimedia.org/project/board/1128/
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim
adrianheine added a project: § Wikidata-Sprint-2015-03-24.
TASK DETAIL
https://phabricator.wikimedia.org/T94393
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign
username.
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel
adrianheine added a project: § Wikidata-Sprint-2015-03-24.
TASK DETAIL
https://phabricator.wikimedia.org/T94394
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign
username.
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel
adrianheine added a project: § Wikidata-Sprint-2015-03-24.
TASK DETAIL
https://phabricator.wikimedia.org/T94395
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign
username.
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel
adrianheine moved this task to Review on the § Wikidata-Sprint-2015-03-24
workboard.
TASK DETAIL
https://phabricator.wikimedia.org/T94395
WORKBOARD
https://phabricator.wikimedia.org/project/board/1128/
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim
adrianheine created this task.
adrianheine claimed this task.
adrianheine added projects: Wikidata, DataValues-JavaScript.
Restricted Application added a subscriber: Aklapper.
TASK DESCRIPTION
TASK DETAIL
https://phabricator.wikimedia.org/T94394
REPLY HANDLER ACTIONS
Reply to comment
adrianheine created this task.
adrianheine claimed this task.
adrianheine added projects: Wikidata, ValueView.
Restricted Application added a subscriber: Aklapper.
TASK DESCRIPTION
TASK DETAIL
https://phabricator.wikimedia.org/T94395
REPLY HANDLER ACTIONS
Reply to comment or attach files
adrianheine added a blocking task: T94395: Remove explicit jquery.qunit loading
from ValueView.
TASK DETAIL
https://phabricator.wikimedia.org/T94393
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign
username.
EMAIL PREFERENCES
https
adrianheine added a blocked task: T94393: Switch wikidata qunit jobs from qunit
to qunit-karma.
TASK DETAIL
https://phabricator.wikimedia.org/T94395
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign
username.
EMAIL PREFERENCES
https
adrianheine added a project: Patch-For-Review.
adrianheine added a comment.
https://github.com/wmde/ValueView/pull/167
TASK DETAIL
https://phabricator.wikimedia.org/T94395
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign
username.
EMAIL
adrianheine moved this task to Review on the § Wikidata-Sprint-2015-03-24
workboard.
TASK DETAIL
https://phabricator.wikimedia.org/T94394
WORKBOARD
https://phabricator.wikimedia.org/project/board/1128/
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim
adrianheine moved this task to Review on the § Wikidata-Sprint-2015-03-24
workboard.
TASK DETAIL
https://phabricator.wikimedia.org/T94393
WORKBOARD
https://phabricator.wikimedia.org/project/board/1128/
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim
adrianheine added a project: Patch-For-Review.
adrianheine added a comment.
https://github.com/wmde/DataValuesJavascript/pull/75
TASK DETAIL
https://phabricator.wikimedia.org/T94394
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign
username
adrianheine added a subscriber: adrianheine.
adrianheine added a comment.
I'm currently working on removing wbUsedEntities, see
https://gerrit.wikimedia.org/r/#/c/197290/. You would have to do an API request
then, anyways. As for the current page, `wgCurRevisionId` gives you the revid,
but I
adrianheine lowered the priority of this task from High to Low.
adrianheine added a comment.
Currently we are trying to do less on page load within the current
architecture, but we are not planning to completely defer initialization.
TASK DETAIL
https://phabricator.wikimedia.org/T62341
adrianheine removed a blocking task: T88426: Server-side rendering for all
property links in the JS UI.
TASK DETAIL
https://phabricator.wikimedia.org/T88428
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign
username.
EMAIL PREFERENCES
adrianheine removed a blocked task: T88428: Drop referenced entities from JS
config.
TASK DETAIL
https://phabricator.wikimedia.org/T88426
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign
username.
EMAIL PREFERENCES
https
adrianheine added a comment.
Can you give me a use-case for editing an entity referenced by the entity
you're currently on? I think it makes more sense to provide the lastrevid with
`wbgetclaims`, and I think you definitely should run `wbgetclaims` before doing
`wbsetclaims`, otherwise you
adrianheine added a comment.
Afaik they are not cached, but injected afterwards with the TextInjector. So,
no issue with caching.
TASK DETAIL
https://phabricator.wikimedia.org/T93863
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign
adrianheine added a comment.
I suppose
https://phabricator.wikimedia.org/rEWBA00145a8dcbdb548216a39b69ccc713734d37bdfe
introduced that. The ValueView appears to not be rendered anymore on snakview
initialization. A maybe related issue is that the valueview never switches
`valueview-ineditmode
adrianheine moved this task to Done on the § Wikidata-Sprint-2015-03-11
workboard.
TASK DETAIL
https://phabricator.wikimedia.org/T93073
WORKBOARD
https://phabricator.wikimedia.org/project/board/1095/
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe
adrianheine closed this task as Resolved.
adrianheine claimed this task.
TASK DETAIL
https://phabricator.wikimedia.org/T93073
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign
username.
EMAIL PREFERENCES
https://phabricator.wikimedia.org
adrianheine added a subscriber: adrianheine.
adrianheine added a comment.
I think the following interfaces might be candidates for moving there
- Wikibase\Lib\EntityIdFormatter
- Wikibase\Lib\SnakFormatter
- Wikibase\Lib\Store\EntityLookup
- Wikibase\Lib\Store\LabelLookup
TASK DETAIL
https
adrianheine added a subscriber: adrianheine.
adrianheine added a comment.
I agree. It would be great if the toolbar controller would just initialize on
top of existing toolbars and not add missing ones on the fly. We would need to
add empty toolbars for statements to the static HTML
adrianheine closed this task as Resolved.
adrianheine added a subscriber: adrianheine.
TASK DETAIL
https://phabricator.wikimedia.org/T93183
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign
username.
EMAIL PREFERENCES
https
adrianheine moved this task to Done on the § Wikidata-Sprint-2015-03-11
workboard.
TASK DETAIL
https://phabricator.wikimedia.org/T93183
WORKBOARD
https://phabricator.wikimedia.org/project/board/1095/
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe
adrianheine closed blocking task T77990: File based caching: Split of site
lookup for readonly access as Resolved.
TASK DETAIL
https://phabricator.wikimedia.org/T77991
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign
username.
EMAIL
adrianheine closed this task as Resolved.
adrianheine added a subscriber: adrianheine.
TASK DETAIL
https://phabricator.wikimedia.org/T77990
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign
username.
EMAIL PREFERENCES
https
adrianheine closed blocking task T77990: File based caching: Split of site
lookup for readonly access as Resolved.
TASK DETAIL
https://phabricator.wikimedia.org/T47532
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign
username.
EMAIL
adrianheine added a comment.
Adrian_WMDE: aude: We could also replace the config var with a $(
'.wikibase-toolbar' ).length 0 check
Adrian_WMDE: That would be pretty crude, but work
TASK DETAIL
https://phabricator.wikimedia.org/T93773
REPLY HANDLER ACTIONS
Reply to comment
adrianheine removed a subscriber: adrianheine.
TASK DETAIL
https://phabricator.wikimedia.org/T50143
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign
username.
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel
adrianheine added a subscriber: adrianheine.
adrianheine added a comment.
Why is this in done?
TASK DETAIL
https://phabricator.wikimedia.org/T92949
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign
username.
EMAIL PREFERENCES
https
adrianheine moved this task to Doing on the § Wikidata-Sprint-2015-03-11
workboard.
adrianheine lowered the priority of this task from High to Normal.
TASK DETAIL
https://phabricator.wikimedia.org/T87759
WORKBOARD
https://phabricator.wikimedia.org/project/board/1095/
REPLY HANDLER ACTIONS
adrianheine added a comment.
Ok, cool. I suppose the linked change is fixing the underlying issue?
TASK DETAIL
https://phabricator.wikimedia.org/T92949
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign
username.
EMAIL PREFERENCES
https
adrianheine added a comment.
In https://phabricator.wikimedia.org/T63601#1125148, @hashar wrote:
@adrianheine should we delete in Gerrit the mediawiki/extensions/DataTypes
repository ?
Yeah, we should. It doesn't even mirror the current HEAD.
TASK DETAIL
https
adrianheine added a subscriber: adrianheine.
TASK DETAIL
https://phabricator.wikimedia.org/T93207
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign
username.
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel
adrianheine moved this task to Done on the § Wikidata-Sprint-2015-03-11
workboard.
TASK DETAIL
https://phabricator.wikimedia.org/T88425
WORKBOARD
https://phabricator.wikimedia.org/project/board/1095/
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe
adrianheine closed this task as Resolved.
TASK DETAIL
https://phabricator.wikimedia.org/T88425
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign
username.
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences
adrianheine added a comment.
We can indeed skip 3. I removed `wbUsedEntities` in
https://gerrit.wikimedia.org/r/#/c/197290/.
TASK DETAIL
https://phabricator.wikimedia.org/T88275
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign
username
adrianheine added a subscriber: adrianheine.
adrianheine added a comment.
Only https://github.com/wmde/DataValuesJavascript/pull/71 is still open.
TASK DETAIL
https://phabricator.wikimedia.org/T66084
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe
adrianheine moved this task to Doing on the § Wikidata-Sprint-2015-03-11
workboard.
TASK DETAIL
https://phabricator.wikimedia.org/T78526
WORKBOARD
https://phabricator.wikimedia.org/project/board/1095/
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe
adrianheine closed blocking task T91376: Make ValueView qunit tests independent
of focus. as Resolved.
TASK DETAIL
https://phabricator.wikimedia.org/T74184
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign
username.
EMAIL PREFERENCES
adrianheine closed this task as Resolved.
TASK DETAIL
https://phabricator.wikimedia.org/T91376
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign
username.
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences
adrianheine moved this task to Done on the § Wikidata-Sprint-2015-03-11
workboard.
TASK DETAIL
https://phabricator.wikimedia.org/T91376
WORKBOARD
https://phabricator.wikimedia.org/project/board/1095/
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe
adrianheine added a comment.
QUnit tests passed for me for the first time in
https://gerrit.wikimedia.org/r/#/c/196241/.
TASK DETAIL
https://phabricator.wikimedia.org/T74184
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign
username
adrianheine added a comment.
Sorta. Henning did a great work leveling our widget implementations, but he
didn't really do what I lined out here. I still think that would make sense.
TASK DETAIL
https://phabricator.wikimedia.org/T74666
REPLY HANDLER ACTIONS
Reply to comment or attach files
adrianheine added a comment.
https://github.com/wmde/ValueView/pull/166
TASK DETAIL
https://phabricator.wikimedia.org/T91376
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign
username.
EMAIL PREFERENCES
https://phabricator.wikimedia.org
adrianheine added a comment.
Still reasonable to do, but not holding us back in any way currently.
TASK DETAIL
https://phabricator.wikimedia.org/T75306
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign
username.
EMAIL PREFERENCES
https
adrianheine added a comment.
A slightly related thing: Currently you cannot expand without JS enabled, which
means if you don't have working JS, the box might just not be there. If it's
collapsed by default, you might not even now that there should be something. If
it's shown by default, you
adrianheine added a comment.
Could someone verify?
TASK DETAIL
https://phabricator.wikimedia.org/T87640
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign
username.
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel
adrianheine added a comment.
Two of the last three qunit jobs failed with database locked errors:
https://integration.wikimedia.org/ci/job/mwext-Wikibase-qunit/7692/
https://integration.wikimedia.org/ci/job/mwext-Wikibase-qunit/7691/
One failed with the usual 0/0 assertions warning aka resource
adrianheine added a comment.
In https://phabricator.wikimedia.org/T55849#1103629, @adrianheine wrote:
Are there still unmigrated tests?
Yes, there are. They are at https://github.com/wmde/WikidataBrowserTestsRSpec.
TASK DETAIL
https://phabricator.wikimedia.org/T55849
REPLY HANDLER
adrianheine added a subscriber: adrianheine.
adrianheine added a comment.
PHPUnit just gave me 79.18% code lines coverage on client. Worst offenders are
UpdateRepo/, modules/, recentchanges/.
TASK DETAIL
https://phabricator.wikimedia.org/T44510
REPLY HANDLER ACTIONS
Reply to comment
adrianheine added a comment.
Sorry. It's way done in the mw-debug-www.log build artifact.
TASK DETAIL
https://phabricator.wikimedia.org/T74184
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign
username.
EMAIL PREFERENCES
https
adrianheine added a subscriber: adrianheine.
TASK DETAIL
https://phabricator.wikimedia.org/T92505
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign
username.
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel
701 - 800 of 1136 matches
Mail list logo