gerritbot added a comment.
Change 454032 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Show lemmas and gloss in sense entity selector
https://gerrit.wikimedia.org/r/454032TASK
WMDE-leszek added a comment.
Should only start once T189129 is finished.TASK DETAILhttps://phabricator.wikimedia.org/T201605EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszekCc: WMDE-leszek, Lydia_Pintscher, Mringgaard, Lahi, Gq86, GoranSMilovanovic,
WMDE-leszek added subscribers: Addshore, WMDE-leszek.WMDE-leszek added a comment.
Might possibly be considered a duplicate of T196298.TASK DETAILhttps://phabricator.wikimedia.org/T199896EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszekCc:
WMDE-leszek updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...**Acceptance Criteria**:
**Given**:
**When**:
**Then**:**Given**: Lexeme L1 exists
**When**: I send a change request to wbeditentity API that contains change to Sense data and references L1
**Then**: Lexeme L1
Cparle created this task.Cparle added projects: Wikidata, Multimedia, Structured-Data-Commons, Multimedia-Team-Working-Board, Epic.
TASK DESCRIPTIONUpdate the first attempt at a SDoC File page with the new design (which implies OOUI-ifying the interface)TASK
Cparle claimed this task.Cparle added a subscriber: MarkTraceur.
TASK DETAILhttps://phabricator.wikimedia.org/T202287EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: CparleCc: MarkTraceur, Aklapper, Ramsey-WMF, PDrouin-WMF, Cparle, Lahi, Gq86, E1presidente,
WMDE-leszek closed this task as "Resolved".WMDE-leszek claimed this task.WMDE-leszek added a comment.
Per both sub elements done, closing this as resolved.TASK DETAILhttps://phabricator.wikimedia.org/T196295EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To:
Lea_Lacroix_WMDE created this task.Lea_Lacroix_WMDE added a project: Lexicographical data.Restricted Application added a project: Wikidata.
TASK DESCRIPTIONAs a Wikidata Lexeme editor, I want to generate Forms automatically in order to create Lexemes more efficiently.
Problem: A lot of words have
Lucas_Werkmeister_WMDE claimed this task.Lucas_Werkmeister_WMDE added a project: Wikidata-Senses-Iteration3.
TASK DETAILhttps://phabricator.wikimedia.org/T201000EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Denny,
Addshore added a project: User-Addshore.
TASK DETAILhttps://phabricator.wikimedia.org/T202260EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: Addshore, WMDE-leszek, Lydia_Pintscher, Lea_Lacroix_WMDE, Mringgaard, Lahi, Gq86, GoranSMilovanovic,
Addshore added a comment.
I went ahead and looked at this for 2 mins.
Using https://wikidata.beta.wmflabs.org/wiki/Lexeme:L1 and L1-S5 as an example
I noticed that the property P730 was pretty old, originally being created in 2014.
I edited the label
Addshore added a project: wikidata-tech-focus.
TASK DETAILhttps://phabricator.wikimedia.org/T198396EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: Bugreporter, Liuxinyu970226, Addshore, Aklapper, Multichill, Ladsgroup, Lahi, Gq86,
Addshore added a project: wikidata-tech-focus.
TASK DETAILhttps://phabricator.wikimedia.org/T201150EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: Addshore, Jonas, Aklapper, Lahi, Gq86, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, EBjune,
Jonas updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION... [x ] [[ https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Wikibase/+/454012/ | Add documentation about hooks in the code (/docs/hooks.txt) ]]...TASK DETAILhttps://phabricator.wikimedia.org/T169775EMAIL
Jonas updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION... [ ]x] [[ https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Wikibase/+/454012/ | Add documentation about hooks in the code (/docs/hooks.txt) ]]
[ ] Add a section about JS hook to Stable Interface Policy on
gerritbot added a project: Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T169775EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jonas, gerritbotCc: gerritbot, Jonas, WMDE-leszek, Addshore, Lea_Lacroix_WMDE, Aleksey_WMDE,
gerritbot added a comment.
Change 454012 had a related patch set uploaded (by Jonas Kress (WMDE); owner: Jonas Kress (WMDE)):
[mediawiki/extensions/Wikibase@master] Add documentation about _javascript_ hooks
https://gerrit.wikimedia.org/r/454012TASK
ReleaseTaggerBot added a project: MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)).
TASK DETAILhttps://phabricator.wikimedia.org/T201360EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: EBernhardson, ReleaseTaggerBotCc: gerritbot, debt, Aklapper,
ReleaseTaggerBot added a project: MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)).
TASK DETAILhttps://phabricator.wikimedia.org/T198261EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Cparle, ReleaseTaggerBotCc: gerritbot, Abit, Ramsey-WMF,
gerritbot added a comment.
Change 453537 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Search: transform and createEmpty must return same type
https://gerrit.wikimedia.org/r/453537TASK DETAILhttps://phabricator.wikimedia.org/T201360EMAIL
gerritbot added a comment.
Change 453533 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Add warning when requesting results beyond the supported limit
https://gerrit.wikimedia.org/r/453533TASK DETAILhttps://phabricator.wikimedia.org/T201360EMAIL
gerritbot added a comment.
Change 451625 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Make statement qualifier enclosing characters accessible
https://gerrit.wikimedia.org/r/451625TASK DETAILhttps://phabricator.wikimedia.org/T198261EMAIL
Addshore claimed this task.Restricted Application added a project: User-Addshore.
TASK DETAILhttps://phabricator.wikimedia.org/T200983EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: Ladsgroup, Bugreporter, RazShuty, WMDE-leszek, Addshore,
Tgr added a comment.
Handling this in Vagrant is not hard, but Vagrant is not the only one using separate composer install commands per extension; some wikifarms do that due to composer being unwieldy with lots of dependencies. So it would be better if Wikibase supported that pattern, or
WMDE-leszek updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...The WMDEF is no longer supporting the ruby framework so if it does break we will be on our own and then forced to make fixes / migrate before Lexeme development can continueTASK
WMDE-leszek added a comment.
Looks like a bug of some sort, yes. Purging the cache wouldn't make the label show up.TASK DETAILhttps://phabricator.wikimedia.org/T202260EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszekCc: WMDE-leszek, Lydia_Pintscher,
Lucas_Werkmeister_WMDE added a comment.
This should be fixed with Ieea56a7686 , probably deployed on Wednesday.TASK DETAILhttps://phabricator.wikimedia.org/T173026EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: gerritbot,
Lucas_Werkmeister_WMDE added a comment.
Well, it was blocked for a while on SparqlHelper, which can’t trivially be made into a service because it’s sometimes null.
The result of the discussion on Discourse was that there are two ways forward:
Hack: Add some kind of DummySparqlHelper which we
gerritbot added a comment.
Change 449737 abandoned by Lucas Werkmeister (WMDE):
Update data-values/geo to 2.1.2
Reason:
Obsoleted by Ieea56a7686.
https://gerrit.wikimedia.org/r/449737TASK DETAILhttps://phabricator.wikimedia.org/T173026EMAIL
Addshore added a comment.
In T196264#4513783, @Lydia_Pintscher wrote:
Léa and I just tried to save a statement linking to a Sense. We got an error :(
F25164113: Screenshot_20180820_102508.png
Need to clear the local storage of your browser D:TASK
gerritbot added a comment.
Change 453939 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] use ::class for class_exists checks instead of string
https://gerrit.wikimedia.org/r/453939TASK DETAILhttps://phabricator.wikimedia.org/T183096EMAIL
daniel closed subtask T194729: Allow Wikibase Entities to be stored in alternative slots [MCR] as "Resolved".
TASK DETAILhttps://phabricator.wikimedia.org/T159708EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Jdforrester-WMF, Addshore,
daniel closed subtask T194729: Allow Wikibase Entities to be stored in alternative slots [MCR] as "Resolved".
TASK DETAILhttps://phabricator.wikimedia.org/T180981EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: gerritbot, Lydia_Pintscher, Aklapper,
daniel closed this task as "Resolved".
TASK DETAILhttps://phabricator.wikimedia.org/T194729EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Jdforrester-WMF, Addshore, Cparle, daniel, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985,
Addshore updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...One problem I saw: There is an index named tmp1 over term_language, term_type, term_entity_type, term_search_key in the table wb_terms, which is not in the source.
TODO check for other diferencesTASK
Addshore added a comment.
The only sub task is currently for tmp1, the next step for this task would be to go through all of the other schemas and check for other differences.TASK DETAILhttps://phabricator.wikimedia.org/T85414EMAIL
Addshore updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION... - A comment next to the index should be added pointing to this ticket so it can easily be found if a developer looks at the code in 2 years time.
**SQL Details**
As of 20/08/2018
```
MariaDB [wikidatawiki]>
hashar added a comment.
@Addshore you are a true hero.TASK DETAILhttps://phabricator.wikimedia.org/T201336EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Addshore, hasharCc: hashar, gerritbot, Addshore, Mringgaard, Gaboe420, Versusxo, Majesticalreaper22,
Pablo-WMDE added a comment.
by-catch when running (quibble) set-up with the math extension:
Creating tables for enabled extensions
PHP Warning: array_map(): Argument #2 should be an array in /workspace/src/extensions/Math/src/MathRenderer.php on line 671
PHP Warning: in_array() expects
Addshore renamed this task from "Add 'tmp1' index that is in WMF production to the wikibase install SQL files" to "Add 'tmp1' index that is in WMF production to the Wikibase install SQL files".Addshore updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTIONAs a WMF DBA I want the
Marostegui added a comment.
Sounds good to me!
Thanks @AddshoreTASK DETAILhttps://phabricator.wikimedia.org/T197854EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MarosteguiCc: Addshore, Ladsgroup, Aklapper, Marostegui, WMDE-leszek, AndyTan, Lahi, Gq86,
Addshore triaged this task as "High" priority.
TASK DETAILhttps://phabricator.wikimedia.org/T202265EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: Ladsgroup, Addshore, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs,
Addshore closed this task as "Declined".
TASK DETAILhttps://phabricator.wikimedia.org/T197854EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: Addshore, Ladsgroup, Aklapper, Marostegui, WMDE-leszek, AndyTan, Lahi, Gq86, GoranSMilovanovic, QZanden,
Addshore added a comment.
I have created T202265 to add the current index to our SQL files.
We will hold off on renaming for now, the plan is for this whole table to die, hopefully in the not to distant future, so spending weeks renaming seems like a waste.
I also marked T194273 as stalled based
Jonas updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION... [ x] Add documentation about hooks to mediawiki.org. https://www.mediawiki.org/wiki/Extension:Wikibase_Repository...TASK DETAILhttps://phabricator.wikimedia.org/T169775EMAIL
Addshore added a parent task: T85414: synchronize schema on production with what is created on install.
TASK DETAILhttps://phabricator.wikimedia.org/T202265EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: Ladsgroup, Addshore, Aklapper, Lahi, Gq86,
Addshore added a project: wikidata-tech-focus.
TASK DETAILhttps://phabricator.wikimedia.org/T85414EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: hoo, Ladsgroup, JanZerebecki, aude, Aklapper, daniel, AndyTan, Lahi, Gq86, GoranSMilovanovic,
Addshore added projects: Wikidata, wikidata-tech-focus.
TASK DETAILhttps://phabricator.wikimedia.org/T202265EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: Ladsgroup, Addshore, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer,
Addshore added a subtask: T202265: Add 'tmp1' index that is in WMF production to the wikibase install SQL files.
TASK DETAILhttps://phabricator.wikimedia.org/T85414EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: hoo, Ladsgroup, JanZerebecki, aude,
Addshore changed the status of subtask T194273: Clean up indexes of wb_terms table from "Open" to "Stalled".
TASK DETAILhttps://phabricator.wikimedia.org/T188992EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: jcrespo, Jonas,
Addshore changed the task status from "Open" to "Stalled".Addshore added a comment.
Marking as stalled as this is on HoldTASK DETAILhttps://phabricator.wikimedia.org/T194273EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, AddshoreCc: Addshore,
Addshore added a comment.
In T99531#4513194, @abian wrote:
In T99531#4411395, @abian wrote:
wikiba.se is a bit unstable. Today it has been down for some hours (from ~1:00 UTC to ~5:30 UTC). Last issues were detected on 31 May (~0:00 UTC), 24 May (~19:00-20:00 UTC), 10 May (~11:15 UTC) and 9 May
Jonas updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION... [ ] Add documentation about hooks to mediawiki.org. !!TODO: definehttps://www.mediawiki.org/wiki/Extension:Wikibase_Repository
[ ] Add documentation about hooks in the page!!code (/docs/hooks.txt)
[ ] Add a section
Jonas claimed this task.
TASK DETAILhttps://phabricator.wikimedia.org/T169775EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: JonasCc: Jonas, WMDE-leszek, Addshore, Lea_Lacroix_WMDE, Aleksey_WMDE, Lucas_Werkmeister_WMDE, Aklapper, Lahi, Gq86,
Jonas updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION[DESCRIPTION]
Patch:
https://github.com/wmde/wikibase-docker-yml-gui/pull/24TASK DETAILhttps://phabricator.wikimedia.org/T201923EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To:
Pablo-WMDE added a comment.
Trying to reproduce in local quibble and see if changing NonTempTableTestCase to see if running its custom tear down on tearDown instead of tearDownAfterClass will help.TASK DETAILhttps://phabricator.wikimedia.org/T202223EMAIL
Jonas added a comment.
@Matthias_Geisler_WMDE please add a description and a link to the patch next time.TASK DETAILhttps://phabricator.wikimedia.org/T201923EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Matthias_Geisler_WMDE, JonasCc: Jonas, RazShuty,
Lea_Lacroix_WMDE added a comment.
Hey @WMDE-leszek, while testing stuff for Senses we encountered this weird bug. Could you have a look?TASK DETAILhttps://phabricator.wikimedia.org/T202260EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lea_Lacroix_WMDECc:
Lea_Lacroix_WMDE created this task.Lea_Lacroix_WMDE added a project: Lexicographical data.Restricted Application added a project: Wikidata.
TASK DESCRIPTIONWhen testing Senses, some property labels are not displayed, instead the Pnumber is displayed.
Example on L1-F3, L1-S4, the reference on
Lydia_Pintscher closed this task as "Resolved".Lydia_Pintscher moved this task from Test (Product Review) to Done on the Wikidata-Senses-Iteration3 board.Lydia_Pintscher added a comment.
\o/TASK
Lydia_Pintscher closed subtask T196290: See summary of edit including Senses as "Resolved".
TASK DETAILhttps://phabricator.wikimedia.org/T196288EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lydia_PintscherCc: WMDE-leszek, RazShuty, Mringgaard, Lahi, Gq86,
Lydia_Pintscher closed this task as "Resolved".Lydia_Pintscher moved this task from Test (Product Review) to Done on the Wikidata-Senses-Iteration3 board.Lydia_Pintscher added a comment.
\o/TASK
Pablo-WMDE claimed this task.Pablo-WMDE added a project: Wikidata-Editor-Experience-Improvements-Iteration5.
TASK DETAILhttps://phabricator.wikimedia.org/T202223EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Pablo-WMDECc: MarcoAurelio, Pablo-WMDE, Addshore,
Lydia_Pintscher closed subtask T196269: Select a Sense as value in statement as "Resolved".
TASK DETAILhttps://phabricator.wikimedia.org/T196263EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lydia_PintscherCc: Addshore, WMDE-leszek, RazShuty, Mringgaard,
Lydia_Pintscher closed this task as "Resolved".Lydia_Pintscher moved this task from Test (Product Review) to Done on the Wikidata-Senses-Iteration3 board.Lydia_Pintscher added a comment.
\o/TASK
Lydia_Pintscher closed subtask T196296: Request for Lexeme data including Sense data as "Resolved".
TASK DETAILhttps://phabricator.wikimedia.org/T196295EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lydia_PintscherCc: WMDE-leszek, RazShuty, Mringgaard, Lahi,
Lydia_Pintscher closed this task as "Resolved".Lydia_Pintscher moved this task from Test (Product Review) to Done on the Wikidata-Senses-Iteration3 board.Lydia_Pintscher claimed this task.Lydia_Pintscher added a comment.
\o/TASK
Lydia_Pintscher closed this task as "Resolved".Lydia_Pintscher moved this task from Test (Product Review) to Done on the Wikidata-Senses-Iteration3 board.
TASK DETAILhttps://phabricator.wikimedia.org/T200980WORKBOARDhttps://phabricator.wikimedia.org/project/board/3527/EMAIL
Lydia_Pintscher added a comment.
\o/TASK DETAILhttps://phabricator.wikimedia.org/T200980EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, Lydia_PintscherCc: gerritbot, Lydia_Pintscher, Mringgaard, Gaboe420, Versusxo, Majesticalreaper22,
Lydia_Pintscher closed subtask T196297: Request data for a particular Sense via API as "Resolved".
TASK DETAILhttps://phabricator.wikimedia.org/T196295EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lydia_PintscherCc: WMDE-leszek, RazShuty, Mringgaard, Lahi,
Lydia_Pintscher closed this task as "Resolved".Lydia_Pintscher moved this task from Test (Product Review) to Done on the Wikidata-Senses-Iteration3 board.Lydia_Pintscher claimed this task.
TASK
Lydia_Pintscher closed this task as "Resolved".Lydia_Pintscher moved this task from Test (Product Review) to Done on the Wikidata-Senses-Iteration3 board.Lydia_Pintscher added a comment.
\o/TASK
Lydia_Pintscher closed subtask T201173: Ability to save several statements on a Sense without reloading the page as "Resolved".
TASK DETAILhttps://phabricator.wikimedia.org/T196270EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lydia_PintscherCc: WMDE-leszek,
Lydia_Pintscher closed this task as "Resolved".Lydia_Pintscher moved this task from Test (Product Review) to Done on the Wikidata-Senses-Iteration3 board.Lydia_Pintscher claimed this task.
TASK
Lydia_Pintscher added a comment.
Léa and I just tried to save a statement linking to a Sense. We got an error :(
F25164113: Screenshot_20180820_102508.pngTASK DETAILhttps://phabricator.wikimedia.org/T196264EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To:
Addshore updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...```
09:50:1500:18:52.022 Fatal error: Uncaught exception 'Wikimedia\Rdbms\DBQueryError' with message 'A database query error has occurred. Did you forget to run your application's database schema updater after
Addshore added a comment.
Patches exist for any other occurrences that I spotted.
I'll leave this open until they are reviewed and land in Wikibase.
I have created T87892 for CirrusSearch.TASK DETAILhttps://phabricator.wikimedia.org/T183096EMAIL
Addshore claimed this task.Restricted Application added a project: User-Addshore.
TASK DETAILhttps://phabricator.wikimedia.org/T183096EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: TheDJ, gerritbot, Ebe123, Aklapper, TerraCodes, aude, hoo,
Addshore triaged this task as "Normal" priority.Addshore changed the task status from "Open" to "Stalled".Addshore added a comment.
Stalled as T87892 needs to be done firstTASK DETAILhttps://phabricator.wikimedia.org/T202254EMAIL
Addshore created this task.Addshore added projects: Wikidata, wikidata-tech-focus.Restricted Application added a subscriber: Aklapper.
TASK DESCRIPTIONDetails
Created as the one remaining part of T183096: Use ExtensionRegistry instead of class_exists to check for enabled extensions.
This is
Addshore added a subtask: T87892: Convert CirrusSearch to use extension registration.
TASK DETAILhttps://phabricator.wikimedia.org/T202254EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: Addshore, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden,
thiemowmde added a comment.
Sorry, I confused two ideas:
Yes, we certainly can create a sniff that forbids class_exists( 'string' ).
To make a sniff understand if a class_exists can be replaced with an ExtensionRegistry check, the sniff would need to know which class belongs to which extension,
gerritbot added a comment.
Change 453941 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/Wikibase@master] Use ExtensionRegistry check for Echo in tests instead of class_exists
https://gerrit.wikimedia.org/r/453941TASK
gerritbot added a comment.
Change 453939 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/Wikibase@master] use ::class for class_exists checks instead of string
https://gerrit.wikimedia.org/r/453939TASK DETAILhttps://phabricator.wikimedia.org/T183096EMAIL
Addshore added a comment.
In T183096#4513119, @thiemowmde wrote:
I wish there would be a way to automatically forbid problematic class_exists, while still allowing non-problematic ones, but I can't think of a way.
That sounds like it should be possible in code sniffer.
I suggest to close this
Bencemac added a comment.
@srishakatux Isn't this solved by DuplicateReferences gadget?TASK DETAILhttps://phabricator.wikimedia.org/T159191EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: BencemacCc: Bencemac, Aklapper, srishakatux, Lahi, Gq86,
ReleaseTaggerBot added a project: MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)).
TASK DETAILhttps://phabricator.wikimedia.org/T200884EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jakob_WMDE, ReleaseTaggerBotCc: Liuxinyu970226, gerritbot,
gerritbot added a comment.
Change 451639 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Make entity redirects configurable per entity type
https://gerrit.wikimedia.org/r/451639TASK DETAILhttps://phabricator.wikimedia.org/T200884EMAIL
101 - 188 of 188 matches
Mail list logo
