[Wikidata-bugs] [Maniphest] [Updated] T225350: Maplink (via Wikidata) shows only empty window without map on all wikipedias

2020-02-14 Thread Evad37
Evad37 added a comment. This seems similar to T227402: White screen with red dot shown instead of map when using geoline/geoshape with specified coordinates TASK DETAIL https://phabricator.wikimedia.org/T225350 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Updated] T241422: Wikidata forms without statements use empty JSON array instead of empty JSON object

2020-02-14 Thread DannyS712
DannyS712 added a project: User-DannyS712. DannyS712 added a comment. The tests had an issue. From https://integration.wikimedia.org/ci/job/wmf-quibble-core-vendor-mysql-php72-docker/15551/console 19:30:45 The data provider specified for

[Wikidata-bugs] [Maniphest] [Commented On] T241422: Wikidata forms without statements use empty JSON array instead of empty JSON object

2020-02-14 Thread gerritbot
gerritbot added a comment. Change 572397 had a related patch set uploaded (by DannyS712; owner: DannyS712): [mediawiki/extensions/Wikibase@master] Fix testEmptyLists https://gerrit.wikimedia.org/r/572397 TASK DETAIL https://phabricator.wikimedia.org/T241422 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Updated] T241422: Wikidata forms without statements use empty JSON array instead of empty JSON object

2020-02-14 Thread gerritbot
gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T241422 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: Addshore, Pintoch, Un1tY, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild,

[Wikidata-bugs] [Maniphest] [Updated] T244039: Api tests: Hard deprecate $this->doLogin, remove calls in favor of passing a user where needed

2020-02-14 Thread ReleaseTaggerBot
ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.20; 2020-02-18); removed MW-1.35-notes (1.35.0-wmf.19; 2020-02-11). TASK DETAIL https://phabricator.wikimedia.org/T244039 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: DannyS712,

[Wikidata-bugs] [Maniphest] [Triaged] T244039: Api tests: Hard deprecate $this->doLogin, remove calls in favor of passing a user where needed

2020-02-14 Thread DannyS712
DannyS712 triaged this task as "Medium" priority. TASK DETAIL https://phabricator.wikimedia.org/T244039 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: DannyS712 Cc: Pchelolo, DannyS712, Aklapper, Daimona, Un1tY, Hook696, Adidsone1, Falcopragati,

[Wikidata-bugs] [Maniphest] [Edited] T244039: Api tests: Hard deprecate $this->doLogin, remove calls in favor of passing a user where needed

2020-02-14 Thread DannyS712
DannyS712 updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T244039 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: DannyS712 Cc: Pchelolo, DannyS712, Aklapper, Daimona, Un1tY, Hook696, Adidsone1, Falcopragati, Daryl-TTMG,

[Wikidata-bugs] [Maniphest] [Commented On] T244039: Api tests: Hard deprecate $this->doLogin, remove calls in favor of passing a user where needed

2020-02-14 Thread gerritbot
gerritbot added a comment. Change 572379 had a related patch set uploaded (by DannyS712; owner: DannyS712): [mediawiki/core@master] Hard deprecate ApiTestCase::doLogin https://gerrit.wikimedia.org/r/572379 TASK DETAIL https://phabricator.wikimedia.org/T244039 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T244039: Api tests: Hard deprecate $this->doLogin, remove calls in favor of passing a user where needed

2020-02-14 Thread gerritbot
gerritbot added a comment. Change 570526 **merged** by jenkins-bot: [mediawiki/extensions/ORES@master] Remove use of ApiTestCase::doLogin https://gerrit.wikimedia.org/r/570526 TASK DETAIL https://phabricator.wikimedia.org/T244039 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T244039: Api tests: Hard deprecate $this->doLogin, remove calls in favor of passing a user where needed

2020-02-14 Thread gerritbot
gerritbot added a comment. Change 569572 **merged** by jenkins-bot: [mediawiki/extensions/Thanks@master] Remove use of ApiTestCase::doLogin https://gerrit.wikimedia.org/r/569572 TASK DETAIL https://phabricator.wikimedia.org/T244039 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Updated] T245305: Termbox uses reserved log parameter 'message'

2020-02-14 Thread Maintenance_bot
Maintenance_bot removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T245305 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Maintenance_bot Cc: Aklapper, Reedy, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic,

[Wikidata-bugs] [Maniphest] [Closed] T245305: Termbox uses reserved log parameter 'message'

2020-02-14 Thread Reedy
Reedy closed this task as "Resolved". Reedy claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T245305 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Reedy Cc: Aklapper, Reedy, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic,

[Wikidata-bugs] [Maniphest] [Commented On] T244039: Api tests: Hard deprecate $this->doLogin, remove calls in favor of passing a user where needed

2020-02-14 Thread Pchelolo
Pchelolo added a comment. All uses have been eliminated. TASK DETAIL https://phabricator.wikimedia.org/T244039 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: DannyS712, Pchelolo Cc: Pchelolo, DannyS712, Aklapper, Daimona, Un1tY, Hook696,

[Wikidata-bugs] [Maniphest] [Updated] T245305: Termbox uses reserved log parameter 'message'

2020-02-14 Thread ReleaseTaggerBot
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.20; 2020-02-18). TASK DETAIL https://phabricator.wikimedia.org/T245305 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ReleaseTaggerBot Cc: Aklapper, Reedy, Un1tY, Hook696, Daryl-TTMG,

[Wikidata-bugs] [Maniphest] [Commented On] T245305: Termbox uses reserved log parameter 'message'

2020-02-14 Thread gerritbot
gerritbot added a comment. Change 572333 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Don't use logging reserved word message https://gerrit.wikimedia.org/r/572333 TASK DETAIL https://phabricator.wikimedia.org/T245305 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T244929: Hard deprecate Title::getUserPermissionsErrors

2020-02-14 Thread DannyS712
DannyS712 added a comment. Doing the core patches separately because they sometimes include other changes, and to ease review / avoid merge conflicts TASK DETAIL https://phabricator.wikimedia.org/T244929 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T244929: Hard deprecate Title::getUserPermissionsErrors

2020-02-14 Thread gerritbot
gerritbot added a comment. Change 572370 had a related patch set uploaded (by DannyS712; owner: DannyS712): [mediawiki/core@master] Article: Remove use of Title::getUserPermissionsErrors (part 3) https://gerrit.wikimedia.org/r/572370 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Triaged] T244929: Hard deprecate Title::getUserPermissionsErrors

2020-02-14 Thread DannyS712
DannyS712 triaged this task as "Medium" priority. TASK DETAIL https://phabricator.wikimedia.org/T244929 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: DannyS712 Cc: Aklapper, DannyS712, Un1tY, Hook696, Adidsone1, Daryl-TTMG, RomaAmorRoma,

[Wikidata-bugs] [Maniphest] [Commented On] T245144: Increase Retry-After header for Wikidata

2020-02-14 Thread Urbanecm
Urbanecm added a comment. In T245144#5884781 , @Ladsgroup wrote: > I have been thinking about this. Originally I thought it would help but the more I think I feel it would be very similar to the increasing factor. The oscillation will

[Wikidata-bugs] [Maniphest] [Retitled] T245144: Increase Retry-After header for Wikidata

2020-02-14 Thread Urbanecm
Urbanecm renamed this task from "Increase Retry-Time header for Wikidata" to "Increase Retry-After header for Wikidata". TASK DETAIL https://phabricator.wikimedia.org/T245144 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Urbanecm Cc: Ladsgroup,

[Wikidata-bugs] [Maniphest] [Closed] T237746: page ID accessed from Lua by calling "mw.title.getCurrentTitle().id" ocassionally returns "0"

2020-02-14 Thread Anomie
Anomie closed this task as "Resolved". Anomie added a comment. The fix should be deployed with 1.35.0-wmf.20. If you empty the category after that version is deployed, and it starts filling up again, feel free to reopen. TASK DETAIL https://phabricator.wikimedia.org/T237746 EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T245305: Termbox uses reserved log parameter 'message'

2020-02-14 Thread gerritbot
gerritbot added a comment. Change 572333 had a related patch set uploaded (by Reedy; owner: Reedy): [mediawiki/extensions/Wikibase@master] Don't use logging reserved word message https://gerrit.wikimedia.org/r/572333 TASK DETAIL https://phabricator.wikimedia.org/T245305 EMAIL

[Wikidata-bugs] [Maniphest] [Updated] T245305: Termbox uses reserved log parameter 'message'

2020-02-14 Thread gerritbot
gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T245305 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: Aklapper, Reedy, Un1tY, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild,

[Wikidata-bugs] [Maniphest] [Created] T245305: Termbox uses reserved log parameter 'message'

2020-02-14 Thread Reedy
Reedy created this task. Reedy added projects: Wikidata-Termbox, Wikidata-Campsite. Restricted Application added a project: Wikidata. TASK DESCRIPTION Termbox uses reserved log parameter 'message' { "_index": "logstash-mediawiki-2020.02.14", "_type": "mediawiki", "_id":

[Wikidata-bugs] [Maniphest] [Commented On] T245144: Increase Retry-Time header for Wikidata

2020-02-14 Thread Multichill
Multichill added a comment. This is one of those bugs where you should just lookup the relevant chapter in a book like http://barbie.uta.edu/~jli/Resources/MapReduce/Distributed%20Systems%20Principles%20and%20Paradigms.pdf and look at the possible solutions. TASK DETAIL

[Wikidata-bugs] [Maniphest] [Updated] T244856: Prefer relevant unit suggestions over other entities

2020-02-14 Thread Multichill
Multichill added projects: MediaWiki-extensions-PropertySuggester, Wikidata. Multichill added a comment. F31552245 is a nice mock up. When adding a unit, we want to have suggestions that make sense. That makes me think of

[Wikidata-bugs] [Maniphest] [Commented On] T239474: [M] Units support for quantity datatype

2020-02-14 Thread Multichill
Multichill added a comment. I agree, let's continue in the other task about that part. TASK DETAIL https://phabricator.wikimedia.org/T239474 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: matthiasmullie, Multichill Cc: Jarekt, Addshore,

[Wikidata-bugs] [Maniphest] [Closed] T245062: Double ?uselang= passed to a file results in "Cache key contains characters that are not allowed: `P180_1101514477_fr?uselang=fr_label`"

2020-02-14 Thread Jdforrester-WMF
Jdforrester-WMF closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T245062 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tarrow, Jdforrester-WMF Cc: Rosalie_WMDE, Tarrow, Agusbou2015, Ladsgroup, hoo, Jakob_WMDE,

[Wikidata-bugs] [Maniphest] [Commented On] T245062: Double ?uselang= passed to a file results in "Cache key contains characters that are not allowed: `P180_1101514477_fr?uselang=fr_label`"

2020-02-14 Thread Jdforrester-WMF
Jdforrester-WMF added a comment. I deployed this just now, and the error has gone. Thanks, all. Filing a follow-up for the `class@anonymous` logging bug. TASK DETAIL https://phabricator.wikimedia.org/T245062 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T245062: Double ?uselang= passed to a file results in "Cache key contains characters that are not allowed: `P180_1101514477_fr?uselang=fr_label`"

2020-02-14 Thread Stashbot
Stashbot added a comment. Mentioned in SAL (#wikimedia-operations) [2020-02-14T19:09:59Z] Synchronized php-1.35.0-wmf.19/extensions/Wikibase: T245062 Prevent invalid term languages from cached PrefetchingTermLookup (duration: 01m 09s) TASK

[Wikidata-bugs] [Maniphest] [Updated] T245062: Double ?uselang= passed to a file results in "Cache key contains characters that are not allowed: `P180_1101514477_fr?uselang=fr_label`"

2020-02-14 Thread ReleaseTaggerBot
ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.20; 2020-02-18); removed MW-1.35-notes (1.35.0-wmf.19; 2020-02-11). TASK DETAIL https://phabricator.wikimedia.org/T245062 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tarrow,

[Wikidata-bugs] [Maniphest] [Updated] T245245: Message Wikibase-error-ui-no-external-page shows literal $1 and $2 instead of values

2020-02-14 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added subscribers: Silvan_WMDE, Addshore, Jakob_WMDE, Lucas_Werkmeister_WMDE. Lucas_Werkmeister_WMDE added a comment. Reverting rEWBA66bcfe6704a8: Add errorformat parameter to wikibase API requests

[Wikidata-bugs] [Maniphest] [Commented On] T245062: Double ?uselang= passed to a file results in "Cache key contains characters that are not allowed: `P180_1101514477_fr?uselang=fr_label`"

2020-02-14 Thread gerritbot
gerritbot added a comment. Change 572228 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Prevent invalid term languages from cached PrefetchingTermLookup https://gerrit.wikimedia.org/r/572228 TASK DETAIL https://phabricator.wikimedia.org/T245062 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T245062: Double ?uselang= passed to a file results in "Cache key contains characters that are not allowed: `P180_1101514477_fr?uselang=fr_label`"

2020-02-14 Thread Jdforrester-WMF
Jdforrester-WMF added a comment. OK, this works OK, but SRE vetoed deploying to production this late on a holiday Friday, so I'll sync it out early on Tuesday SF time. TASK DETAIL https://phabricator.wikimedia.org/T245062 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Updated] T245062: Double ?uselang= passed to a file results in "Cache key contains characters that are not allowed: `P180_1101514477_fr?uselang=fr_label`"

2020-02-14 Thread ReleaseTaggerBot
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.19; 2020-02-11). TASK DETAIL https://phabricator.wikimedia.org/T245062 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tarrow, ReleaseTaggerBot Cc: Rosalie_WMDE, Tarrow, Agusbou2015,

[Wikidata-bugs] [Maniphest] [Updated] T245245: Message Wikibase-error-ui-no-external-page shows literal $1 and $2 instead of values

2020-02-14 Thread Reedy
Reedy added a project: I18n. Reedy updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T245245 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Reedy Cc: Aklapper, Raymond, Kaleem-Bhatti, darthmon_wmde, Nandana, Lahi, Gq86,

[Wikidata-bugs] [Maniphest] [Commented On] T245062: Double ?uselang= passed to a file results in "Cache key contains characters that are not allowed: `P180_1101514477_fr?uselang=fr_label`"

2020-02-14 Thread Stashbot
Stashbot added a comment. Mentioned in SAL (#wikimedia-operations) [2020-02-14T17:37:00Z] Unlocked for deployment [ALL REPOSITORIES]: Testing T245062 fix on mwdebug1001 (duration: 03m 05s) TASK DETAIL https://phabricator.wikimedia.org/T245062

[Wikidata-bugs] [Maniphest] [Commented On] T241975: entitysources: Remove old MultiRepository & PerRepository Service containers and config

2020-02-14 Thread gerritbot
gerritbot added a comment. Change 572284 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek): [mediawiki/extensions/Wikibase@master] Removed not needed "non-entity-source" logic in HtmlPageLinkRendererBeginHookHandler https://gerrit.wikimedia.org/r/572284 TASK

[Wikidata-bugs] [Maniphest] [Commented On] T245062: Double ?uselang= passed to a file results in "Cache key contains characters that are not allowed: `P180_1101514477_fr?uselang=fr_label`"

2020-02-14 Thread Stashbot
Stashbot added a comment. Mentioned in SAL (#wikimedia-operations) [2020-02-14T17:33:54Z] Locking from deployment [ALL REPOSITORIES]: Testing T245062 fix on mwdebug1001 (planned duration: 60m 00s) TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T245062: Double ?uselang= passed to a file results in "Cache key contains characters that are not allowed: `P180_1101514477_fr?uselang=fr_label`"

2020-02-14 Thread gerritbot
gerritbot added a comment. Change 572264 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@wmf/1.35.0-wmf.19] Prevent invalid term languages from cached PrefetchingTermLookup https://gerrit.wikimedia.org/r/572264 TASK DETAIL https://phabricator.wikimedia.org/T245062 EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T241975: entitysources: Remove old MultiRepository & PerRepository Service containers and config

2020-02-14 Thread gerritbot
gerritbot added a comment. Change 572280 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek): [mediawiki/extensions/Wikibase@master] Removed "non-entity-source" conditional logic in WikiPageEntityStore https://gerrit.wikimedia.org/r/572280 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T241975: entitysources: Remove old MultiRepository & PerRepository Service containers and config

2020-02-14 Thread gerritbot
gerritbot added a comment. Change 572279 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek): [mediawiki/extensions/Wikibase@master] Removed "non-entity-source" conditional logic in EntityContentFactory https://gerrit.wikimedia.org/r/572279 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T241975: entitysources: Remove old MultiRepository & PerRepository Service containers and config

2020-02-14 Thread gerritbot
gerritbot added a comment. Change 572278 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek): [mediawiki/extensions/Wikibase@master] Removed "non-entity-source" conditional logic in WikiPageEntityMetaDataLookup https://gerrit.wikimedia.org/r/572278 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T228857: Step 1: Investigate common.js bundle content/size

2020-02-14 Thread Michael
Michael added a comment. In T228857#5885189 , @Pablo-WMDE wrote: > https://gerrit.wikimedia.org/r/571482 is an attempt at reducing the size, but without changing the content. "Tree shaking" (e.g.

[Wikidata-bugs] [Maniphest] [Commented On] T244990: An attempt at visual regression testing

2020-02-14 Thread Tonina_Zhelyazkova_WMDE
Tonina_Zhelyazkova_WMDE added a comment. This looks promising: https://github.com/americanexpress/jest-image-snapshot TASK DETAIL https://phabricator.wikimedia.org/T244990 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tonina_Zhelyazkova_WMDE

[Wikidata-bugs] [Maniphest] [Commented On] T228857: Step 1: Investigate common.js bundle content/size

2020-02-14 Thread Pablo-WMDE
Pablo-WMDE added a comment. https://gerrit.wikimedia.org/r/571482 is an attempt at reducing the size, but without changing the content. "Tree shaking" (e.g. https://github.com/indutny/webpack-common-shake/) is a much harder problem, and - if it were added - would have to come as an earlier

[Wikidata-bugs] [Maniphest] [Edited] T228857: Step 1: Investigate common.js bundle content/size

2020-02-14 Thread Pablo-WMDE
Pablo-WMDE updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T228857 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: WMDE-leszek, Lucas_Werkmeister_WMDE, Michael, Matthias_Geisler_WMDE, Aklapper, Pablo-WMDE,

[Wikidata-bugs] [Maniphest] [Updated] T239421: Step 1: mobile fixes (impact: medium)

2020-02-14 Thread Michael
Michael added a comment. List of things left Todo from the last pairing session: [ ] The button on the bailout screen should have a font-size of 14px, a total height of 32 px, with a margin-top of 4px and a margin-bottom of 5px [ ] The color of the button icons should be `#222` ->

[Wikidata-bugs] [Maniphest] [Commented On] T241975: entitysources: Remove old MultiRepository & PerRepository Service containers and config

2020-02-14 Thread gerritbot
gerritbot added a comment. Change 572265 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek): [mediawiki/extensions/Wikibase@master] Removed "non-entity-source" conditional logic in RebuildPropertyInfo https://gerrit.wikimedia.org/r/572265 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T245062: Double ?uselang= passed to a file results in "Cache key contains characters that are not allowed: `P180_1101514477_fr?uselang=fr_label`"

2020-02-14 Thread gerritbot
gerritbot added a comment. Change 572264 had a related patch set uploaded (by Jakob; owner: Tarrow): [mediawiki/extensions/Wikibase@wmf/1.35.0-wmf.19] Prevent invalid term languages from cached PrefetchingTermLookup https://gerrit.wikimedia.org/r/572264 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T241975: entitysources: Remove old MultiRepository & PerRepository Service containers and config

2020-02-14 Thread gerritbot
gerritbot added a comment. Change 572261 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek): [mediawiki/extensions/Wikibase@master] Removed "non-entity-source" conditional logic in RebuildTermSqlIndex https://gerrit.wikimedia.org/r/572261 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T245062: Double ?uselang= passed to a file results in "Cache key contains characters that are not allowed: `P180_1101514477_fr?uselang=fr_label`"

2020-02-14 Thread gerritbot
gerritbot added a comment. Change 572259 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup): [mediawiki/extensions/Wikibase@master] Do not try to load label in unknown languages in Lua https://gerrit.wikimedia.org/r/572259 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T245062: Double ?uselang= passed to a file results in "Cache key contains characters that are not allowed: `P180_1101514477_fr?uselang=fr_label`"

2020-02-14 Thread Ladsgroup
Ladsgroup added a comment. On the lua side of things: You can reproduce this problem by setting the language to almost anything other than a valid one like "uselang=???" . The good news is that I couldn't break out

[Wikidata-bugs] [Maniphest] [Commented On] T239421: Step 1: mobile fixes (impact: medium)

2020-02-14 Thread gerritbot
gerritbot added a comment. Change 547198 had a related patch set uploaded (by Michael Große; owner: Michael Große): [mediawiki/extensions/Wikibase@master] bridge: Adjust the size of the Header and close button x https://gerrit.wikimedia.org/r/547198 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Updated] T228857: Step 1: Investigate common.js bundle content/size

2020-02-14 Thread gerritbot
gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T228857 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: WMDE-leszek, Lucas_Werkmeister_WMDE, Michael, Matthias_Geisler_WMDE, Aklapper,

[Wikidata-bugs] [Maniphest] [Commented On] T228857: Step 1: Investigate common.js bundle content/size

2020-02-14 Thread gerritbot
gerritbot added a comment. Change 571482 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)): [mediawiki/extensions/Wikibase@master] bridge: minify app build https://gerrit.wikimedia.org/r/571482 TASK DETAIL https://phabricator.wikimedia.org/T228857

[Wikidata-bugs] [Maniphest] [Commented On] T244992: Incorporate new component library release in bridge

2020-02-14 Thread gerritbot
gerritbot added a comment. Change 572247 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/Wikibase@master] bridge: update to new component library version https://gerrit.wikimedia.org/r/572247 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Updated] T244992: Incorporate new component library release in bridge

2020-02-14 Thread gerritbot
gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T244992 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, gerritbot Cc: Aklapper, Pablo-WMDE, Un1tY, Sarai-WMDE, Hook696, Daryl-TTMG,

[Wikidata-bugs] [Maniphest] [Claimed] T244992: Incorporate new component library release in bridge

2020-02-14 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE claimed this task. Lucas_Werkmeister_WMDE moved this task from To do to Doing on the Wikidata-Bridge-Sprint-14 board. TASK DETAIL https://phabricator.wikimedia.org/T244992 WORKBOARD https://phabricator.wikimedia.org/project/board/4576/ EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T244989: Release component lib

2020-02-14 Thread gerritbot
gerritbot added a comment. Change 572225 **merged** by jenkins-bot: [wikibase/vuejs-components@master] Bump version to 0.1.4 https://gerrit.wikimedia.org/r/572225 TASK DETAIL https://phabricator.wikimedia.org/T244989 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Updated] T245062: Double ?uselang= passed to a file results in "Cache key contains characters that are not allowed: `P180_1101514477_fr?uselang=fr_label`"

2020-02-14 Thread Tarrow
Tarrow added a subscriber: Rosalie_WMDE. Tarrow added a comment. So we (@Jakob_WMDE and @Rosalie_WMDE and me) looked at this in some detail. We came to the following conclusions (chip in if I misrepresented anything) The ideal solution is for us to fix

[Wikidata-bugs] [Maniphest] [Commented On] T243701: Wikidata maxlag repeatedly over 5s since Jan20, 2020 (primarily caused by the query service)

2020-02-14 Thread Bugreporter
Bugreporter added a comment. By default pywikibot will do one edit every 10 seconds (or longer if you use parallel processes). This may be overrided by setting -pt:1 (or 0) and some bots runs under it. This task will unconditionally throttle it when lag is high (but they can still edit in a

[Wikidata-bugs] [Maniphest] [Commented On] T243701: Wikidata maxlag repeatedly over 5s since Jan20, 2020 (primarily caused by the query service)

2020-02-14 Thread Strainu
Strainu added a comment. In T243701#5884801 , @Ladsgroup wrote: > I have been thinking about this and I think I have a suggestion. bots and tools, should respect maxlag **before** it reaches the threshold. We need to return the value

[Wikidata-bugs] [Maniphest] [Claimed] T119226: Very small (or very large) quantity values (represented in scientific notation) result in error in add/update via pywikibot/wikidata API

2020-02-14 Thread DD063520
DD063520 claimed this task. DD063520 added a comment. No, problem there is still time to do it ; ) . of I see what @thiemowmde means. But I'm not sure if I can implement this. The problem is that there can be precision problems if it is done as I propose, right? TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T243701: Wikidata maxlag repeatedly over 5s since Jan20, 2020 (primarily caused by the query service)

2020-02-14 Thread Bugreporter
Bugreporter added a comment. Currently Widar use a policy of sleeping 3x+1 second if the lag (x second) is higher than one second. PetScan run batches five in parallel, so for a lag of 10 seconds PetScan make 5 edits every 31 second. TASK DETAIL https://phabricator.wikimedia.org/T243701

[Wikidata-bugs] [Maniphest] [Commented On] T119226: Very small (or very large) quantity values (represented in scientific notation) result in error in add/update via pywikibot/wikidata API

2020-02-14 Thread ArthurPSmith
ArthurPSmith added a comment. Sorry I never got around to looking at this further. @DD063520 do you understand the above comment from @thiemowmde about using the wbparsevalue api rather than python internals? TASK DETAIL https://phabricator.wikimedia.org/T119226 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Updated] T245144: Increase Retry-Time header for Wikidata

2020-02-14 Thread Bugreporter
Bugreporter added a comment. This will be T240442: Design a continuous throttling policy for Wikidata bots . TASK DETAIL https://phabricator.wikimedia.org/T245144 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T245062: Double ?uselang= passed to a file results in "Cache key contains characters that are not allowed: `P180_1101514477_fr?uselang=fr_label`"

2020-02-14 Thread gerritbot
gerritbot added a comment. Change 572228 had a related patch set uploaded (by Tarrow; owner: Tarrow): [mediawiki/extensions/Wikibase@master] Filter to only prefect valid terms https://gerrit.wikimedia.org/r/572228 TASK DETAIL https://phabricator.wikimedia.org/T245062 EMAIL

[Wikidata-bugs] [Maniphest] [Edited] T245264: Wikibase javascript attempts to automatically render MediaInfo content

2020-02-14 Thread Cparle
Cparle updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T245264 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Cparle Cc: Cparle, Aklapper, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer,

[Wikidata-bugs] [Maniphest] [Created] T245264: Wikibase javascript attempts to automatically render MediaInfo content

2020-02-14 Thread Cparle
Cparle created this task. Cparle added projects: MediaWiki-extensions-WikibaseView, Wikidata, WikibaseMediaInfo. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION On the File page it seems that Wikibase attempts to render MediaInfo content, and only fails to because it

[Wikidata-bugs] [Maniphest] [Commented On] T243701: Wikidata maxlag repeatedly over 5s since Jan20, 2020 (primarily caused by the query service)

2020-02-14 Thread Ladsgroup
Ladsgroup added a comment. In T243701#5880988 , @Bugreporter wrote: > The only way to resolve the issue is increase the rate of edit Query Updater can handle, or reduce the number of triple changes each edit. Yes and no. Yes, WDQS

[Wikidata-bugs] [Maniphest] [Claimed] T244990: An attempt at visual regression testing

2020-02-14 Thread Tonina_Zhelyazkova_WMDE
Tonina_Zhelyazkova_WMDE claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T244990 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tonina_Zhelyazkova_WMDE Cc: Aklapper, Pablo-WMDE, Sarai-WMDE, darthmon_wmde, Michael, Nandana, Lahi,

[Wikidata-bugs] [Maniphest] [Commented On] T245144: Increase Retry-Time header for Wikidata

2020-02-14 Thread Ladsgroup
Ladsgroup added a comment. I have been thinking about this. Originally I thought it would help but the more I think I feel it would be very similar to the increasing factor. The oscillation will be longer but the situation stays the same because they only respect after WDQS lagging behind

[Wikidata-bugs] [Maniphest] [Commented On] T239421: Step 1: mobile fixes (impact: medium)

2020-02-14 Thread gerritbot
gerritbot added a comment. Change 572010 had a related patch set uploaded (by Michael Große; owner: Michael Große): [mediawiki/extensions/Wikibase@master] bridge: Adjust margins in bailout components https://gerrit.wikimedia.org/r/572010 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T244989: Release component lib

2020-02-14 Thread gerritbot
gerritbot added a comment. Change 572226 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [wikibase/vuejs-components@master] Add release instructions to README https://gerrit.wikimedia.org/r/572226 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T239421: Step 1: mobile fixes (impact: medium)

2020-02-14 Thread gerritbot
gerritbot added a comment. Change 572032 had a related patch set uploaded (by Michael Große; owner: Michael Große): [mediawiki/extensions/Wikibase@master] bridge: add missing side margins to permission errors https://gerrit.wikimedia.org/r/572032 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Updated] T239421: Step 1: mobile fixes (impact: medium)

2020-02-14 Thread gerritbot
gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T239421 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael, gerritbot Cc: Lydia_Pintscher, WMDE-leszek, darthmon_wmde, Pablo-WMDE, Michael, SaraiSan,

[Wikidata-bugs] [Maniphest] [Commented On] T239421: Step 1: mobile fixes (impact: medium)

2020-02-14 Thread gerritbot
gerritbot added a comment. Change 571996 had a related patch set uploaded (by Michael Große; owner: Michael Große): [mediawiki/extensions/Wikibase@master] bridge: Add body mixins and use them where appropriate https://gerrit.wikimedia.org/r/571996 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Updated] T244989: Release component lib

2020-02-14 Thread gerritbot
gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T244989 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, gerritbot Cc: Aklapper, Pablo-WMDE, Un1tY, Sarai-WMDE, Hook696, Daryl-TTMG,

[Wikidata-bugs] [Maniphest] [Commented On] T244989: Release component lib

2020-02-14 Thread gerritbot
gerritbot added a comment. Change 572225 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [wikibase/vuejs-components@master] Bump version to 0.1.4 https://gerrit.wikimedia.org/r/572225 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Claimed] T244989: Release component lib

2020-02-14 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE claimed this task. Lucas_Werkmeister_WMDE moved this task from To do to Doing on the Wikidata-Bridge-Sprint-14 board. TASK DETAIL https://phabricator.wikimedia.org/T244989 WORKBOARD https://phabricator.wikimedia.org/project/board/4576/ EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Updated] T244991: Implement changes in component library

2020-02-14 Thread Maintenance_bot
Maintenance_bot removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T244991 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, Maintenance_bot Cc: Aklapper, Pablo-WMDE, Sarai-WMDE, darthmon_wmde,

[Wikidata-bugs] [Maniphest] [Updated] T245243: Constraints modules not included on pages that aren't in an entity namespace, but that contain entities in a slot

2020-02-14 Thread Maintenance_bot
Maintenance_bot removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T245243 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Cparle, Maintenance_bot Cc: Cparle, Aklapper, darthmon_wmde, Nandana, Lahi, Gq86, Ramsey-WMF,

[Wikidata-bugs] [Maniphest] [Updated] T238662: Step 1: make edit based on fix/update choice (impact: high)

2020-02-14 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE updated the cover image to Restricted File. TASK DETAIL https://phabricator.wikimedia.org/T238662 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE, Lucas_Werkmeister_WMDE Cc: Lucas_Werkmeister_WMDE, Jakob_WMDE,

[Wikidata-bugs] [Maniphest] [Updated] T245243: Constraints modules not included on pages that aren't in an entity namespace, but that contain entities in a slot

2020-02-14 Thread ReleaseTaggerBot
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.20; 2020-02-18). TASK DETAIL https://phabricator.wikimedia.org/T245243 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Cparle, ReleaseTaggerBot Cc: Cparle, Aklapper, Un1tY, Hook696,

[Wikidata-bugs] [Maniphest] [Updated] T244916: (Property|Item)TermStore::getTerms() is unused

2020-02-14 Thread ReleaseTaggerBot
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.20; 2020-02-18). TASK DETAIL https://phabricator.wikimedia.org/T244916 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hoo, ReleaseTaggerBot Cc: darthmon_wmde, Lydia_Pintscher, WMDE-leszek,

[Wikidata-bugs] [Maniphest] [Commented On] T245243: Constraints modules not included on pages that aren't in an entity namespace, but that contain entities in a slot

2020-02-14 Thread gerritbot
gerritbot added a comment. Change 572218 **merged** by jenkins-bot: [mediawiki/extensions/WikibaseQualityConstraints@master] Add constraints js to pages contain entities (including within slots) https://gerrit.wikimedia.org/r/572218 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Unblock] T243192: font size adjustments

2020-02-14 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE closed subtask T244991: Implement changes in component library as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T243192 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Charlie_WMDE,

[Wikidata-bugs] [Maniphest] [Closed] T244991: Implement changes in component library

2020-02-14 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE closed this task as "Resolved". Lucas_Werkmeister_WMDE moved this task from Peer Review to Done on the Wikidata-Bridge-Sprint-14 board. TASK DETAIL https://phabricator.wikimedia.org/T244991 WORKBOARD https://phabricator.wikimedia.org/project/board/4576/ EMAIL

[Wikidata-bugs] [Maniphest] [Updated] T238662: Step 1: make edit based on fix/update choice (impact: high)

2020-02-14 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE updated the cover image to Restricted File. TASK DETAIL https://phabricator.wikimedia.org/T238662 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE, Lucas_Werkmeister_WMDE Cc: Lucas_Werkmeister_WMDE, Jakob_WMDE,

[Wikidata-bugs] [Maniphest] [Commented On] T244991: Implement changes in component library

2020-02-14 Thread gerritbot
gerritbot added a comment. Change 571765 **merged** by jenkins-bot: [wikibase/vuejs-components@master] Fix font sizes of RadioInput https://gerrit.wikimedia.org/r/571765 TASK DETAIL https://phabricator.wikimedia.org/T244991 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Updated] T238662: Step 1: make edit based on fix/update choice (impact: high)

2020-02-14 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE updated the cover image to Restricted File. TASK DETAIL https://phabricator.wikimedia.org/T238662 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE, Lucas_Werkmeister_WMDE Cc: Lucas_Werkmeister_WMDE, Jakob_WMDE,

[Wikidata-bugs] [Maniphest] [Updated] T245243: Constraints modules not included on pages that aren't in an entity namespace, but that contain entities in a slot

2020-02-14 Thread gerritbot
gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T245243 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Cparle, gerritbot Cc: Cparle, Aklapper, Un1tY, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400,

[Wikidata-bugs] [Maniphest] [Commented On] T245243: Constraints modules not included on pages that aren't in an entity namespace, but that contain entities in a slot

2020-02-14 Thread gerritbot
gerritbot added a comment. Change 572218 had a related patch set uploaded (by Cparle; owner: Cparle): [mediawiki/extensions/WikibaseQualityConstraints@master] Add constraints js to pages contain entities (including within slots) https://gerrit.wikimedia.org/r/572218 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T244916: (Property|Item)TermStore::getTerms() is unused

2020-02-14 Thread gerritbot
gerritbot added a comment. Change 572207 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Rename (Property|Item)TermStoreWriter to more specific name https://gerrit.wikimedia.org/r/572207 TASK DETAIL https://phabricator.wikimedia.org/T244916 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Created] T245245: Message Wikibase-error-ui-no-external-page shows literal $1 and $2 instead of values

2020-02-14 Thread Raymond
Raymond created this task. Raymond added a project: Wikidata. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION I tried to connect a category page on Wikimedia Commons with a Wikidata item. I entered the Q Id instead of the page name and I got this error message The

[Wikidata-bugs] [Maniphest] [Commented On] T244916: (Property|Item)TermStore::getTerms() is unused

2020-02-14 Thread gerritbot
gerritbot added a comment. Change 572207 had a related patch set uploaded (by Hoo man; owner: Hoo man): [mediawiki/extensions/Wikibase@master] Rename (Property|Item)TermStoreWriter to more specific name https://gerrit.wikimedia.org/r/572207 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Closed] T222591: Aliases that are too long fail with wrong Error

2020-02-14 Thread Lydia_Pintscher
Lydia_Pintscher closed this task as "Resolved". Lydia_Pintscher claimed this task. Lydia_Pintscher added a comment. Yay :) Thanks for testing. TASK DETAIL https://phabricator.wikimedia.org/T222591 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To:

[Wikidata-bugs] [Maniphest] [Claimed] T245243: Constraints modules not included on pages that aren't in an entity namespace, but that contain entities in a slot

2020-02-14 Thread Cparle
Cparle claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T245243 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Cparle Cc: Cparle, Aklapper, darthmon_wmde, Nandana, Lahi, Gq86, Ramsey-WMF, Lucas_Werkmeister_WMDE, GoranSMilovanovic,

[Wikidata-bugs] [Maniphest] [Updated] T245243: Constraints modules not included on pages that aren't in an entity namespace, but that contain entities in a slot

2020-02-14 Thread Cparle
Cparle added a project: Structured-Data-Backlog (Current Work). TASK DETAIL https://phabricator.wikimedia.org/T245243 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Cparle Cc: Cparle, Aklapper, darthmon_wmde, Nandana, Lahi, Gq86, Ramsey-WMF,

  1   2   >