[Wikidata-bugs] [Maniphest] [Commented On] T254476: Bad contrast of "Edit links" button in Vector skin

2020-06-23 Thread Iniquity
Iniquity added a comment. If the entire text of the Wikibase client is in the #f6f6f6 background, then maybe it’s worth replacing all inclusions? https://github.com/wikimedia/mediawiki-extensions-Wikibase/search?q=72777d&unscoped_q=72777d TASK DETAIL https://phabricator.wikimedia.org/T25

[Wikidata-bugs] [Maniphest] [Updated] T254476: Bad contrast of "Edit links" button in Vector skin

2020-06-23 Thread gerritbot
gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T254476 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: darthmon_wmde, gerritbot Cc: Lydia_Pintscher, Sarai-WMDE, Volker_E, santhosh, Nikerabbit, Carn, Iniquit

[Wikidata-bugs] [Maniphest] [Commented On] T254476: Bad contrast of "Edit links" button in Vector skin

2020-06-23 Thread gerritbot
gerritbot added a comment. Change 607399 had a related patch set uploaded (by Iniquity; owner: Iniquity): [mediawiki/extensions/Wikibase@master] Change 'Edit link' color to make it WCAG compliant https://gerrit.wikimedia.org/r/607399 TASK DETAIL https://phabricator.wikimedia.org/T254

[Wikidata-bugs] [Maniphest] [Commented On] T255319: Eventually deprecate SkinTemplateNavigation::SpecialPage and SkinTemplateNavigation hooks in favor of SkinTemplateNavigation::Universal

2020-06-23 Thread gerritbot
gerritbot added a comment. Change 605326 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson): [mediawiki/skins/Vector@master] Favor SkinTemplateNavigation::Universal https://gerrit.wikimedia.org/r/605326 TASK DETAIL https://phabricator.wikimedia.org/T255319 EMAIL PREFE

[Wikidata-bugs] [Maniphest] [Reassigned] T245043: Legacy methods WikiPage::clearPreparedEdit() and Article::clearPreparedEdit()

2020-06-23 Thread Helga_sf
Helga_sf reassigned this task from Art-Baltai to Peter.ovchyn. TASK DETAIL https://phabricator.wikimedia.org/T245043 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Peter.ovchyn, Helga_sf Cc: Peter.ovchyn, daniel, Art-Baltai, tstarling, Aklapper, Xero

[Wikidata-bugs] [Maniphest] [Unassigned] T207839: Batch add WO II war memorials to Wikidata

2020-06-23 Thread Pintoch
Pintoch removed Pintoch as the assignee of this task. Pintoch added a comment. (just removing myself as assignee as I am not expected to work on this task, I was just available to help during the event) TASK DETAIL https://phabricator.wikimedia.org/T207839 EMAIL PREFERENCES https://phabr

[Wikidata-bugs] [Maniphest] [Updated] T250930: Wikibase receiving ⧼Lang⧽ from uselang parameter and using it everwhere

2020-06-23 Thread Tarrow
Tarrow added a comment. I think the main place this is used and causes problems is: T247057 You can see that what happens is that the CachingFallbackLabelDescriptionLookup is always looking up whatever is at the top of the LanguageFallbackChai

[Wikidata-bugs] [Maniphest] [Commented On] T255852: Error: Invalid Claim while trying to set P2096 and P18 for a wikidata Item

2020-06-23 Thread maskaravivek
maskaravivek added a comment. Thanks, @matej_suchanek. That was indeed the cause of the error. I am now able to call the API successfully. For reference, this is the claim that I am using now. { "id": "Q7110921$35f7634d-f4b9-4d51-aac8-1143ea95230c", "mainsnak": {

[Wikidata-bugs] [Maniphest] [Edited] T254881: Explore visual regression testing

2020-06-23 Thread Tonina_Zhelyazkova_WMDE
Tonina_Zhelyazkova_WMDE updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T254881 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tonina_Zhelyazkova_WMDE Cc: Pablo-WMDE, darthmon_wmde, Sarai-WMDE, Aklapper, raja_wmde, Nandana

[Wikidata-bugs] [Maniphest] [Updated] T255998: Wikibase travis CI is failing, no such table: unittest_wbt_type foir sqlite

2020-06-23 Thread Maintenance_bot
Maintenance_bot removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T255998 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael, Maintenance_bot Cc: Aklapper, Addshore, Iflorez, darthmon_wmde, alaa_wmde, Nandana, Lah

[Wikidata-bugs] [Maniphest] [Closed] T255601: MediaInfo UI breaks when repoDatabase set to "testcommonswiki" instead of false

2020-06-23 Thread matthiasmullie
matthiasmullie closed this task as "Resolved". matthiasmullie claimed this task. matthiasmullie added a comment. I redeployed the config patch (https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/605645) and this issue no longer seems present, so closing the ticket. Please reopen

[Wikidata-bugs] [Maniphest] [Unblock] T254315: entitysources: Directly create entitySources config for WMF production wikis

2020-06-23 Thread matthiasmullie
matthiasmullie closed subtask T255601: MediaInfo UI breaks when repoDatabase set to "testcommonswiki" instead of false as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T254315 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Addshore, matt

[Wikidata-bugs] [Maniphest] [Updated] T255998: Wikibase travis CI is failing, no such table: unittest_wbt_type foir sqlite

2020-06-23 Thread ReleaseTaggerBot
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.39; 2020-06-30). TASK DETAIL https://phabricator.wikimedia.org/T255998 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael, ReleaseTaggerBot Cc: Aklapper, Addshore, Alter-paule, Beast1978

[Wikidata-bugs] [Maniphest] [Commented On] T255998: Wikibase travis CI is failing, no such table: unittest_wbt_type foir sqlite

2020-06-23 Thread gerritbot
gerritbot added a comment. Change 607266 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Fix travis error about missing test database https://gerrit.wikimedia.org/r/607266 TASK DETAIL https://phabricator.wikimedia.org/T255998 EMAIL PREFERENCES https://phabricator

[Wikidata-bugs] [Maniphest] [Unblock] T255423: See and use design tokens to define specs for handover

2020-06-23 Thread Pablo-WMDE
Pablo-WMDE closed subtask T256021: Import WMF truth as nested JSON as "Invalid". TASK DETAIL https://phabricator.wikimedia.org/T255423 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Pablo-WMDE, Sarai-WMDE, Aklapper, darthmon_wmde, Nan

[Wikidata-bugs] [Maniphest] [Commented On] T256021: Import WMF truth as nested JSON

2020-06-23 Thread Pablo-WMDE
Pablo-WMDE added a comment. We reached the conclusion that we can best build a system if we only let in outside //values//, but not entire tokens (i.e. incl the key). Consequently, there is no requirement for the imported token to follow a structure, we can use them in the shallow way we get

[Wikidata-bugs] [Maniphest] [Closed] T256021: Import WMF truth as nested JSON

2020-06-23 Thread Pablo-WMDE
Pablo-WMDE closed this task as "Invalid". TASK DETAIL https://phabricator.wikimedia.org/T256021 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Aklapper, Pablo-WMDE, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawEx

[Wikidata-bugs] [Maniphest] [Updated] T255998: Wikibase travis CI is failing, no such table: unittest_wbt_type foir sqlite

2020-06-23 Thread gerritbot
gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T255998 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael, gerritbot Cc: Aklapper, Addshore, Alter-paule, Beast1978, Un1tY, Hook696, Iflorez, darthmon_wm

[Wikidata-bugs] [Maniphest] [Commented On] T255998: Wikibase travis CI is failing, no such table: unittest_wbt_type foir sqlite

2020-06-23 Thread gerritbot
gerritbot added a comment. Change 607266 had a related patch set uploaded (by Michael Große; owner: Michael Große): [mediawiki/extensions/Wikibase@master] Fix travis error about missing test database https://gerrit.wikimedia.org/r/607266 TASK DETAIL https://phabricator.wikimedia.org

[Wikidata-bugs] [Maniphest] [Claimed] T255998: Wikibase travis CI is failing, no such table: unittest_wbt_type foir sqlite

2020-06-23 Thread Michael
Michael claimed this task. Michael edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞); removed Wikidata-Campsite. Restricted Application added a project: User-Michael. TASK DETAIL https://phabricator.wikimedia.org/T255998 EMAIL PREFERENCES https://phabricator.wikimedia.

[Wikidata-bugs] [Maniphest] [Changed Subscribers] T256114: Create MediaWiki-Docker/Wikibase

2020-06-23 Thread Lucas_Werkmeister_WMDE

[Wikidata-bugs] [Maniphest] [Edited] T255051: Upgrade WebdriverIO in the WikibaseLexeme repository

2020-06-23 Thread zeljkofilipin
zeljkofilipin updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T255051 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Vidhi-Mody, zeljkofilipin Cc: Vidhi-Mody, Aklapper, Alter-paule, Beast1978, Un1tY, Hook696, darthmon_wmd

[Wikidata-bugs] [Maniphest] [Updated] T256118: Create MediaWiki-Docker/WikibaseLexeme

2020-06-23 Thread zeljkofilipin
zeljkofilipin added a parent task: T255051: Upgrade WebdriverIO in the WikibaseLexeme repository. TASK DETAIL https://phabricator.wikimedia.org/T256118 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Vidhi-Mody, zeljkofilipin Cc: zeljkofilipin, darth

[Wikidata-bugs] [Maniphest] [Updated] T255051: Upgrade WebdriverIO in the WikibaseLexeme repository

2020-06-23 Thread zeljkofilipin
zeljkofilipin added a subtask: T256118: Create MediaWiki-Docker/WikibaseLexeme. TASK DETAIL https://phabricator.wikimedia.org/T255051 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Vidhi-Mody, zeljkofilipin Cc: Vidhi-Mody, Aklapper, Alter-paule, Beas

[Wikidata-bugs] [Maniphest] [Unblock] T255880: Remove uses of PHP classes from Wikibase Repo in Client and Lib

2020-06-23 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE closed subtask T255883: Don’t reference WikibaseRepo EntityContent class in WikibaseLib’s EntityChange as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T255880 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_W

[Wikidata-bugs] [Maniphest] [Triaged] T256118: Create MediaWiki-Docker/WikibaseLexeme

2020-06-23 Thread zeljkofilipin
zeljkofilipin triaged this task as "Medium" priority. zeljkofilipin moved this task from Inbox to Test Engineering on the Quality-and-Test-Engineering-Team (QTE) board. TASK DETAIL https://phabricator.wikimedia.org/T256118 WORKBOARD https://phabricator.wikimedia.org/project/board/4403/ EMAI

[Wikidata-bugs] [Maniphest] [Created] T256118: Create MediaWiki-Docker/WikibaseLexeme

2020-06-23 Thread zeljkofilipin
zeljkofilipin created this task. zeljkofilipin added projects: Lexicographical data, Quality-and-Test-Engineering-Team (QTE), User-zeljkofilipin, User-Vidhi-Mody. Restricted Application added a project: Wikidata. TASK DESCRIPTION - https://www.mediawiki.org/wiki/MediaWiki-Docker/Wikibase TASK

[Wikidata-bugs] [Maniphest] [Closed] T255883: Don’t reference WikibaseRepo EntityContent class in WikibaseLib’s EntityChange

2020-06-23 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE closed this task as "Resolved". Lucas_Werkmeister_WMDE moved this task from Peer Review to Done on the Wikibase Extension Decoupling and Registration (Sprint 1) board. TASK DETAIL https://phabricator.wikimedia.org/T255883 WORKBOARD https://phabricator.wikimedia.org/pro

[Wikidata-bugs] [Maniphest] [Updated] T255883: Don’t reference WikibaseRepo EntityContent class in WikibaseLib’s EntityChange

2020-06-23 Thread Maintenance_bot
Maintenance_bot removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T255883 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, Maintenance_bot Cc: Addshore, Aklapper, Lucas_Werkmeister_WMDE, darthmon

[Wikidata-bugs] [Maniphest] [Commented On] T255883: Don’t reference WikibaseRepo EntityContent class in WikibaseLib’s EntityChange

2020-06-23 Thread gerritbot
gerritbot added a comment. Change 605837 abandoned by Lucas Werkmeister (WMDE): Move EntityContent access out of EntityChange Reason: superseded by I08ea10a8a4 https://gerrit.wikimedia.org/r/605837 TASK DETAIL https://phabricator.wikimedia.org/T255883 EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] [Reassigned] T256114: Create MediaWiki-Docker/Wikibase

2020-06-23 Thread zeljkofilipin
zeljkofilipin reassigned this task from zeljkofilipin to Vidhi-Mody. zeljkofilipin moved this task from Waiting to In Progress on the User-Vidhi-Mody board. TASK DETAIL https://phabricator.wikimedia.org/T256114 WORKBOARD https://phabricator.wikimedia.org/project/board/4832/ EMAIL PREFERENCE

[Wikidata-bugs] [Maniphest] [Edited] T255051: Upgrade WebdriverIO in the WikibaseLexeme repository

2020-06-23 Thread zeljkofilipin
zeljkofilipin updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T255051 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Vidhi-Mody, zeljkofilipin Cc: Vidhi-Mody, Aklapper, Alter-paule, Beast1978, Un1tY, Hook696, darthmon_wmd

[Wikidata-bugs] [Maniphest] [Unassigned] T255045: Upgrade WebdriverIO in the Wikibase repository

2020-06-23 Thread zeljkofilipin
zeljkofilipin removed Vidhi-Mody as the assignee of this task. zeljkofilipin moved this task from In Progress to Waiting on the User-Vidhi-Mody board. TASK DETAIL https://phabricator.wikimedia.org/T255045 WORKBOARD https://phabricator.wikimedia.org/project/board/4832/ EMAIL PREFERENCES ht

[Wikidata-bugs] [Maniphest] [Edited] T255045: Upgrade WebdriverIO in the Wikibase repository

2020-06-23 Thread zeljkofilipin
zeljkofilipin updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T255045 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Vidhi-Mody, zeljkofilipin Cc: WMDE-leszek, Addshore, zeljkofilipin, Lucas_Werkmeister_WMDE, Aklapper, Vi

[Wikidata-bugs] [Maniphest] [Updated] T255045: Upgrade WebdriverIO in the Wikibase repository

2020-06-23 Thread zeljkofilipin
zeljkofilipin added a subtask: T256114: Create MediaWiki-Docker/Wikibase. TASK DETAIL https://phabricator.wikimedia.org/T255045 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Vidhi-Mody, zeljkofilipin Cc: WMDE-leszek, Addshore, zeljkofilipin, Lucas_W

[Wikidata-bugs] [Maniphest] [Updated] T256114: Create MediaWiki-Docker/Wikibase

2020-06-23 Thread zeljkofilipin
zeljkofilipin added a parent task: T255045: Upgrade WebdriverIO in the Wikibase repository. TASK DETAIL https://phabricator.wikimedia.org/T256114 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: zeljkofilipin Cc: Aklapper, Vidhi-Mody, zeljkofilipin, d

[Wikidata-bugs] [Maniphest] [Created] T256114: Create MediaWiki-Docker/Wikibase

2020-06-23 Thread zeljkofilipin
zeljkofilipin created this task. zeljkofilipin added projects: Quality-and-Test-Engineering-Team (QTE), User-zeljkofilipin, User-Vidhi-Mody, Wikidata. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION - https://www.mediawiki.org/wiki/Wikibase/Installation - https://www.med

[Wikidata-bugs] [Maniphest] [Triaged] T256114: Create MediaWiki-Docker/Wikibase

2020-06-23 Thread zeljkofilipin
zeljkofilipin triaged this task as "Medium" priority. zeljkofilipin moved this task from Inbox to Test Engineering on the Quality-and-Test-Engineering-Team (QTE) board. TASK DETAIL https://phabricator.wikimedia.org/T256114 WORKBOARD https://phabricator.wikimedia.org/project/board/4403/ EMAI

[Wikidata-bugs] [Maniphest] [Closed] T231191: Wikibase setup guide - most common next steps

2020-06-23 Thread danshick-wmde
danshick-wmde closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T231191 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: danshick-wmde Cc: lucamauri, danshick-wmde, Samantha_Alipio_WMDE, elal, Addshore, johl, Aklapper, Lydi

[Wikidata-bugs] [Maniphest] [Commented On] T231191: Wikibase setup guide - most common next steps

2020-06-23 Thread danshick-wmde
danshick-wmde added a comment. Content is live. https://wikiba.se/setup TASK DETAIL https://phabricator.wikimedia.org/T231191 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: danshick-wmde Cc: lucamauri, danshick-wmde, Samantha_Alipio_WMDE, el

[Wikidata-bugs] [Maniphest] [Updated] T255852: Error: Invalid Claim while trying to set P2096 and P18 for a wikidata Item

2020-06-23 Thread Lydia_Pintscher
Lydia_Pintscher added a project: Wikidata-Campsite. TASK DETAIL https://phabricator.wikimedia.org/T255852 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lydia_Pintscher Cc: matej_suchanek, Aklapper, maskaravivek, Liuxinyu970226, darthmon_wmde, Nanda

[Wikidata-bugs] [Maniphest] [Commented On] T255852: Error: Invalid Claim while trying to set P2096 and P18 for a wikidata Item

2020-06-23 Thread matej_suchanek
matej_suchanek added a comment. While this error should definitely be investigated, note that `P2096` should be a qualifier , not a reference. TASK DETAIL https://phabricator.wikimedia.org/T255852 EMAIL PREFERENCES https://phabricator.w

[Wikidata-bugs] [Maniphest] [Commented On] T256021: Import WMF truth as nested JSON

2020-06-23 Thread Pablo-WMDE
Pablo-WMDE added a comment. Upon closer inspection I now realize that the problem of "concrete values and child nodes on the same level" is insurmountable for style-dictionary, too. Its CTI structure does not allow for that. V

[Wikidata-bugs] [Maniphest] [Updated] T255883: Don’t reference WikibaseRepo EntityContent class in WikibaseLib’s EntityChange

2020-06-23 Thread ReleaseTaggerBot
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.39; 2020-06-30). TASK DETAIL https://phabricator.wikimedia.org/T255883 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, ReleaseTaggerBot Cc: Addshore, Aklapper, Lucas_W

[Wikidata-bugs] [Maniphest] [Commented On] T256021: Import WMF truth as nested JSON

2020-06-23 Thread Pablo-WMDE
Pablo-WMDE added a comment. Looked into https://www.npmjs.com/package/flat 's `unflatten()` but that struggles with concrete values and child nodes on the same level, e.g. `@background-color-base` vs `@background-color-base--hover`. Ironically this seems to coincide quite a bit with the dou

[Wikidata-bugs] [Maniphest] [Commented On] T255883: Don’t reference WikibaseRepo EntityContent class in WikibaseLib’s EntityChange

2020-06-23 Thread gerritbot
gerritbot added a comment. Change 607019 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Don’t access content in EntityChange::setRevisionInfo https://gerrit.wikimedia.org/r/607019 TASK DETAIL https://phabricator.wikimedia.org/T255883 EMAIL PREFERENCES https://ph