Aleksey_WMDE added a comment.
Decision matrix: https://docs.google.com/spreadsheets/d/1CTxB7I2BodpdOh0JNwzrR-ekA63q2SzV1j1T4dyBtDcTASK DETAILhttps://phabricator.wikimedia.org/T151329EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Aleksey_WMDECc: Gstupp
Aleksey_WMDE added a comment.
I failed to find where this code is called.
Can anyone help me?
What page should I open to get EntityChange::getEntityId() called?TASK DETAILhttps://phabricator.wikimedia.org/T157674EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences
Aleksey_WMDE changed the title from "wbentitysearch should match foreign entity IDs." to "wbsearchentities should match foreign entity IDs.".
TASK DETAILhttps://phabricator.wikimedia.org/T157687EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailprefere
Aleksey_WMDE edited the task description. (Show Details)
EDIT DETAILSwbwbsearchentitysearchies currently has special handling for the case where the search term is an entity ID, and the respective entity exists. This code can be found in EntitySearchHelper::getExactMatchForEntityId(). It currently
Aleksey_WMDE added a comment.
Draft: https://gerrit.wikimedia.org/r/#/c/335832/TASK DETAILhttps://phabricator.wikimedia.org/T151329EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Aleksey_WMDECc: Gstupp, Glorian_WD, WMDE-leszek, Mbch331, Aleksey_WMDE
Aleksey_WMDE added a comment.
Use Lua code as property's property to define formatter function (as a raw code or a module reference).
also: * CONS Have to be supported by developers
Probably I didn't put it the right way:
The idea is to allow "any" user to add and/or
Aleksey_WMDE added a comment.
Ways to build URL for external IDs
Here are some thoughts on this topic:
Replace $1 with id in URL template like http://domain.com/$1 (current way)
CONS Doesn't work for a range of websites (see: current workaround)
Use external IDs format that will work
Aleksey_WMDE added a comment.
As soon as we don't need to wrap it in a closure I don't see a reason to put callback in the name - it will only bring confusion.
If we need to wrap it in a closure I don't understand why do we need an interface in the first place?T
Aleksey_WMDE added a comment.
Vote for dropping "callback" suffix.TASK DETAILhttps://phabricator.wikimedia.org/T152491EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, Aleksey_WMDECc: thiemowmde, Aleksey_WMDE, gerritbot, Jakob_WMDE, W
Aleksey_WMDE added a comment.
I believe that it should be done in both places.
As I understood ChangeOp is more (correct me if I'm wrong) Data Access Layer thingy and responsible for persistence: generate Summary and ensure that we won't get inconsistent data in DB.
But in this case, I
Aleksey_WMDE claimed this task.
TASK DETAILhttps://phabricator.wikimedia.org/T150205EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Aleksey_WMDECc: WMDE-leszek, User-Daniel, Aklapper, Ladsgroup, D3r1ck01, Izno, Wikidata-bugs, aude
201 - 211 of 211 matches
Mail list logo