[Wikidata-bugs] [Maniphest] [Unassigned] T184709: Prevent removing focus from the editor when showing autocompletions or suggestions on Query.Wikidata.org

2020-03-18 Thread eflyjason
eflyjason removed eflyjason as the assignee of this task. TASK DETAIL https://phabricator.wikimedia.org/T184709 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: eflyjason Cc: Aklapper, Jonas, Graham87, Smalyshev, Florian, gerritbot

[Wikidata-bugs] [Maniphest] [Retitled] T184718: Make query.wikidata.org query main part (query helper + query editor) responsive

2018-01-11 Thread eflyjason
eflyjason renamed this task from "Make query.wikidata.org query part (upper part) responsive" to "Make query.wikidata.org query main part (query helper + query editor) responsive".eflyjason updated the task description. (Show Details) CHANGES TO TASK DESCRIPTIONMake query.wik

[Wikidata-bugs] [Maniphest] [Created] T184718: Make query.wikidata.org query part (upper part) responsive

2018-01-11 Thread eflyjason
eflyjason created this task.eflyjason triaged this task as "Low" priority.eflyjason added projects: Wikidata-Query-Service, Wikidata, Discovery. TASK DESCRIPTIONF12443226: Untitledgaga.gif (Click to view gif)TASK DETAILhttps://phabricator.wikimedia.org/T184718EMAIL PREFER

[Wikidata-bugs] [Maniphest] [Triaged] T184717: Make query.wikidata.org responsive

2018-01-11 Thread eflyjason
eflyjason triaged this task as "Normal" priority. TASK DETAILhttps://phabricator.wikimedia.org/T184717EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eflyjasonCc: Aklapper, eflyjason, Lahi, Gq86, Darkminds3113, Lucas_Werkmeister_WMDE, GoranSM

[Wikidata-bugs] [Maniphest] [Created] T184717: Make query.wikidata.org responsive

2018-01-11 Thread eflyjason
eflyjason created this task.eflyjason added a project: Wikidata-Query-Service.Herald added a subscriber: Aklapper.Herald added projects: Wikidata, Discovery. TASK DESCRIPTIONCurrently, query.wikidata.org is still not looking very great on mobile devices. It would be nice to make query.wikidata.org

[Wikidata-bugs] [Maniphest] [Updated] T154890: [Story] Mobile/responsive menus

2018-01-11 Thread eflyjason
eflyjason added a parent task: T184717: Make query.wikidata.org responsive. TASK DETAILhttps://phabricator.wikimedia.org/T154890EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eflyjasonCc: gerritbot, eflyjason, mxn, PokestarFan, Jonas, Aklapper, Adrian1985

[Wikidata-bugs] [Maniphest] [Updated] T184717: Make query.wikidata.org responsive

2018-01-11 Thread eflyjason
eflyjason added a subtask: T154890: [Story] Mobile/responsive menus . TASK DETAILhttps://phabricator.wikimedia.org/T184717EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eflyjasonCc: Aklapper, eflyjason, Lahi, Gq86, Darkminds3113, Lucas_Werkmeister_WMDE

[Wikidata-bugs] [Maniphest] [Commented On] T184709: Prevent removing focus from the editor when showing autocompletions or suggestions on Query.Wikidata.org

2018-01-11 Thread eflyjason
eflyjason added a comment. On the time when _keyboardShortcut is called, the CodeMirror-hints is already closed and removed, so we cannot use that way to check if a code hint is displayed. I think some of the API here might be helpful: https://codemirror.net/doc/manual.html#apiTASK DETAILhttps

[Wikidata-bugs] [Maniphest] [Created] T184709: Prevent removing focus from the editor when showing autocompletions or suggestions on Query.Wikidata.org

2018-01-11 Thread eflyjason
eflyjason created this task.eflyjason triaged this task as "Low" priority.eflyjason added projects: Wikidata Query UI, Wikidata. TASK DESCRIPTIONPressing Esc to close the editor’s autocompletions or suggestions on Query.Wikidata.org now also removes focus from the editor. We need to igno

[Wikidata-bugs] [Maniphest] [Commented On] T173213: Implement keyboard accessibility for Query.Wikidata.org

2018-01-08 Thread eflyjason
eflyjason added a comment. Mentioning at corresponding UI elements sound like a good idea. Currently the "execute query" already have a shortcut hint: F12321135: Screen Shot 2018-01-08 at 11.52.01 PM.pngTASK DETAILhttps://phabricator.wikimedia.org/T173213EMAIL PREFER

[Wikidata-bugs] [Maniphest] [Created] T184419: Keyboard accessibility for Query.Wikidata.org not working as intended on mobile devices

2018-01-08 Thread eflyjason
eflyjason created this task.eflyjason added projects: Wikidata Query UI, Wikidata. TASK DESCRIPTIONCurrently, when we type shortcuts like e or f in textarea on mobile devices, the corresponding action will be triggered. However, these action shouldn't be triggered when user is focused on textarea

[Wikidata-bugs] [Maniphest] [Reassigned] T183807: Add highlight and selection feature for query result table for Query.Wikidata.org

2018-01-08 Thread eflyjason
eflyjason reassigned this task from eflyjason to Anpans. TASK DETAILhttps://phabricator.wikimedia.org/T183807EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Anpans, eflyjasonCc: Aklapper, Jonas, Graham87, Smalyshev, Florian, gerritbot, eflyjason, Bright1055

[Wikidata-bugs] [Maniphest] [Commented On] T154890: [Story] Mobile/responsive menus

2018-01-07 Thread eflyjason
eflyjason added a comment. I changed the "Tools" from a dropdown item to a button. The design will be more consistent and also can work better in small screens. Now: F12295106: Screen Shot 2018-01-07 at 6.33.32 PM.png Changed: F12295108: Screen Shot 2018-01-07 at 6.33.20 PM.pngTASK D

[Wikidata-bugs] [Maniphest] [Commented On] T154890: [Story] Mobile/responsive menus

2018-01-06 Thread eflyjason
eflyjason added a comment. The result view's dropdown should be working too.TASK DETAILhttps://phabricator.wikimedia.org/T154890EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eflyjasonCc: gerritbot, eflyjason, mxn, PokestarFan, Jonas, Aklapper, Adrian1985

[Wikidata-bugs] [Maniphest] [Commented On] T154890: [Story] Mobile/responsive menus

2018-01-06 Thread eflyjason
eflyjason added a comment. F12292127: Untitled.gifTASK DETAILhttps://phabricator.wikimedia.org/T154890EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eflyjasonCc: eflyjason, mxn, PokestarFan, Jonas, Aklapper, Bright1055, Lahi, Gq86, Darkminds3113, Toppole69

[Wikidata-bugs] [Maniphest] [Commented On] T154890: [Story] Mobile/responsive menus

2018-01-05 Thread eflyjason
eflyjason added a comment. So we are trying to make the drop-down menu become something like this drop-down menu right? F12259352: Screen Shot 2018-01-05 at 7.16.53 PM.pngTASK DETAILhttps://phabricator.wikimedia.org/T154890EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel

[Wikidata-bugs] [Maniphest] [Commented On] T183923: Keyboard accessibility help dialog

2018-01-03 Thread eflyjason
eflyjason added a comment. F12225770: Screen Shot 2018-01-03 at 9.43.47 PM.pngTASK DETAILhttps://phabricator.wikimedia.org/T183923EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eflyjasonCc: gerritbot, Lucas_Werkmeister_WMDE, Aklapper, eflyjason, Jonas

[Wikidata-bugs] [Maniphest] [Claimed] T183923: Keyboard accessibility help dialog

2018-01-03 Thread eflyjason
eflyjason claimed this task. TASK DETAILhttps://phabricator.wikimedia.org/T183923EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eflyjasonCc: Lucas_Werkmeister_WMDE, Aklapper, eflyjason, Jonas, Bright1055, Lahi, Gq86, Toppole69, GoranSMilovanovic, Mine0901

[Wikidata-bugs] [Maniphest] [Created] T183807: Add highlight and selection feature for query result table for Query.Wikidata.org

2017-12-30 Thread eflyjason
eflyjason created this task.eflyjason added projects: Wikidata Query UI, Wikidata, Design, WMDE-Design. TASK DESCRIPTIONCurrently, users can only use tab or arrow up/arrow down to move between links inside the query result table in https://query.wikidata.org. It would be nice to add a feature

[Wikidata-bugs] [Maniphest] [Commented On] T173213: Implement keyboard accessibility for Query.Wikidata.org

2017-12-30 Thread eflyjason
eflyjason added a comment. Added R to jump to query result and Arrow Up/Arrow Down to select item in query resultTASK DETAILhttps://phabricator.wikimedia.org/T173213EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eflyjasonCc: gerritbot, eflyjason, Florian

[Wikidata-bugs] [Maniphest] [Commented On] T173213: Implement keyboard accessibility for Query.Wikidata.org

2017-12-29 Thread eflyjason
eflyjason added a comment. Updated. Should be all working now :) Ctrl/Command+Enter: Run query Esc: Leave current input field/textarea ?: Toggle Help menu I: Focus on query textarea F: Focus on "Fliter" button in Query Helper S: Focus on "Show" button in Query Helper M:

[Wikidata-bugs] [Maniphest] [Commented On] T173213: Implement keyboard accessibility for Query.Wikidata.org

2017-12-27 Thread eflyjason
eflyjason added a comment. Ctrl/Command+Enter: Run query Esc: Leave current input field/textarea Alt+F: Click "Fliter" button in Query Helper Alt+S: Click "Show" button in Query Helper Alt+L: Click "Limit" button in Query Helper Alt+D: Clear query Alt+R: Restore prev

[Wikidata-bugs] [Maniphest] [Commented On] T173213: Implement keyboard accessibility for Query.Wikidata.org

2017-12-27 Thread eflyjason
eflyjason added a comment. I would suggest F12086290: Screen Shot 2017-12-27 at 11.17.41 PM.png to be a better layout for accessibility .TASK DETAILhttps://phabricator.wikimedia.org/T173213EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eflyjasonCc

[Wikidata-bugs] [Maniphest] [Commented On] T173213: Implement keyboard accessibility for Query.Wikidata.org

2017-12-27 Thread eflyjason
eflyjason added a comment. Just tested. We are currently able to use alt+tab to Open, select and run an example. Edit query and navigate through result. (though not very efficiently of course)TASK DETAILhttps://phabricator.wikimedia.org/T173213EMAIL PREFERENCEShttps://phabricator.wikimedia.org

[Wikidata-bugs] [Maniphest] [Claimed] T173213: Implement keyboard accessibility for Query.Wikidata.org

2017-12-27 Thread eflyjason
eflyjason claimed this task. TASK DETAILhttps://phabricator.wikimedia.org/T173213EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eflyjasonCc: eflyjason, Florian, Smalyshev, Graham87, Jonas, Aklapper, Bright1055, Lahi, Gq86, Toppole69, Lucas_Werkmeister_WMDE

[Wikidata-bugs] [Maniphest] [Commented On] T173213: Implement keyboard accessibility for Query.Wikidata.org

2017-12-27 Thread eflyjason
eflyjason added a comment. In T173213#3772104, @Florian wrote: Was already imported as: https://codein.withgoogle.com/dashboard/tasks/4880480144982016/ With the title: "Keyboard accessibility for Query.Wikidata.org" and the request to add keyboard-accessibility to the index.html fil

[Wikidata-bugs] [Maniphest] [Commented On] T156572: Consider dropping "大马简体 (aka 中文(马来西亚)zh-my)"?

2017-12-24 Thread eflyjason
eflyjason added a comment. I would suggest first request for comments at https://zh.wikipedia.org/wiki/Wikipedia:互助客棧/其他 in Chinese Wikipedia.TASK DETAILhttps://phabricator.wikimedia.org/T156572EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eflyjasonCc

[Wikidata-bugs] [Maniphest] [Commented On] T107693: Add "Create new item" link to property value drop-down menu (particularly when no item matches) in Wikidata

2017-12-11 Thread eflyjason
eflyjason added a comment. In T107693#3826552, @Mvolz wrote: Would you like to submit this work for review on the google code-in website? We can't approve it unless that is done :). Thank you! I've added it to https://www.wikidata.org/wiki/Wikidata:Tools/User_scripts#AddNewItem and also

[Wikidata-bugs] [Maniphest] [Commented On] T107693: Add "Create new item" link to property value drop-down menu (particularly when no item matches) in Wikidata

2017-12-10 Thread eflyjason
eflyjason added a comment. In T107693#3826291, @Sjoerddebruin wrote: I saw that the script also affects the property input field, I don't think that should be happening. Fixed :D https://www.wikidata.org/w/index.php?title=User:Eflyjason/Gadget-CreateNewItem.js=606686398TASK DETAILhttps

[Wikidata-bugs] [Maniphest] [Commented On] T107693: Add "Create new item" link to property value drop-down menu (particularly when no item matches) in Wikidata

2017-12-09 Thread eflyjason
eflyjason added a comment. https://www.wikidata.org/w/index.php?title=User:Eflyjason/Gadget-CreateNewItem.js=606565642 In T107693#3825336, @Sjoerddebruin wrote: Great so far! Is it possible to use OOjs UI for the popup though? We are slowly transforming our current gadgets to it. The form

[Wikidata-bugs] [Maniphest] [Commented On] T107693: Add "Create new item" link to property value drop-down menu (particularly when no item matches) in Wikidata

2017-12-09 Thread eflyjason
eflyjason added a comment. https://www.wikidata.org/w/index.php?title=User:Eflyjason/Gadget-CreateNewItem.js=606396356 the popup is working too :DTASK DETAILhttps://phabricator.wikimedia.org/T107693EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eflyjasonCc

[Wikidata-bugs] [Maniphest] [Commented On] T107693: Add "Create new item" link to property value drop-down menu (particularly when no item matches) in Wikidata

2017-12-09 Thread eflyjason
eflyjason added a comment. https://www.wikidata.org/wiki/User:Eflyjason/Gadget-CreateNewItem.js var currentFieldText = ""; $(document).on('input propertychange paste', ".ui-suggester-input", function() { currentFieldText = $(this).val(); //console.log("Ent

[Wikidata-bugs] [Maniphest] [Commented On] T107693: Add "Create new item" link to property value drop-down menu (particularly when no item matches) in Wikidata

2017-12-09 Thread eflyjason
eflyjason added a comment. I guess that this gadget will have to override _initMenu function in jquery.wikibase.entityselector.js and replace the null with the open new URL function? customItems.unshift( new $.ui.ooMenu.CustomItem( this.options.messages.notfound, function