gerritbot added a comment.
Change 232236 merged by jenkins-bot:
Check renderers' matcher method to find the appropriate renderers for a link
https://gerrit.wikimedia.org/r/232236
TASK DETAIL
https://phabricator.wikimedia.org/T102921
EMAIL PREFERENCES
https://phabricator.wikimedia.org/setti
Jdlrobson added a comment.
Thank you @Se4598 I will take a look at the
Gadget today. I didn't realise there was an existing one so that certainly adds
more urgency/clarity to this.
I hope to take a look today and hopefully have time to add a follow up patch
with tests.
Definitely would be more
Ricordisamoa added a comment.
In https://phabricator.wikimedia.org/T102921#1720496, @Se4598 wrote:
> PS: A thing where I'm not sure about if this is the right thing is the
> argument supplied to the matcher-function. Currently it is the href-part of a
> link, e.g. "/wiki/Mainpage".
> But the g
Se4598 added a comment.
PS: A thing where I'm not sure about if this is the right thing is the argument
supplied to the matcher-function. Currently it is the href-part of a link, e.g.
"/wiki/Mainpage".
But the gadget works/inspects on the title-attribute of the link. Theoretically
that could be
Se4598 added a comment.
Ok, I try to explain what this patch aims at.
The patch in question solves the problem that previously it wasn't possible to
add new renderer without overwriting popups javascript functions with own
customized ones, which are prone to break if the original function change
Jdlrobson added a comment.
Apologies for being pissed off but please as always
assume good faith. My team has to manage various extensions and I'm trying to
set expectations and clear out a backlog of patches. Sadly written
communication doesn't always come across as it should. I should be pisse
Se4598 added a subscriber: Se4598.
Se4598 added a comment.
In https://phabricator.wikimedia.org/T102921#1720328, @Jdlrobson wrote:
> I understand what you are trying to achieve and what the desired outcome is.
> I just want to know whether https://gerrit.wikimedia.org/r/232236 helps you
> do th
Jdlrobson added a comment.
I understand what you are trying to achieve and what the desired outcome is.
I just want to know whether https://gerrit.wikimedia.org/r/232236 helps you do
that.
This requires you building something.
To be clear I expect the Wikidata team to make use of
https://gerrit
Lydia_Pintscher added a comment.
example functionality: go to https://www.wikidata.org/wiki/Q1 and hover over
"significant event" and "big bang". Hover cards should show up for both (links
to other items and links to properties).
TASK DETAIL
https://phabricator.wikimedia.org/T102921
EMAIL P
Jdlrobson added a comment.
FWIW stalled tasks can easily be tracked rather easily in such a way that you
do not lose sight of them. See
https://phabricator.wikimedia.org/dashboard/view/125/ to get an insight into
our workflow.
Right now patch to review tells me my team that we need to review
Jdlrobson added a comment.
Thanks @hoo open questions on patch so we can get this wrapped up.
TASK DETAIL
https://phabricator.wikimedia.org/T102921
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Prtksxna, Jdlrobson
Cc: Jdlrobson, gerritbot, Prtksxn
11 matches
Mail list logo
