[Wikidata-bugs] [Maniphest] [Commented On] T104187: Move services in DataModel to DataModel Services

JeroenDeDauw added a comment. See also: https://phabricator.wikimedia.org/T110344 TASK DETAIL https://phabricator.wikimedia.org/T104187 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Addshore, JeroenDeDauw Cc: hoo, Tpt, thiemowmde, Addshore, Bene,

[Wikidata-bugs] [Maniphest] [Commented On] T104187: Move services in DataModel to DataModel Services

JeroenDeDauw added a comment. These classes and interfaces have been added to the new component and I submitted a PR with the removal of the old copies at https://github.com/wmde/WikibaseDataModel/pull/516 TASK DETAIL https://phabricator.wikimedia.org/T104187 EMAIL PREFERENCES https://pha

[Wikidata-bugs] [Maniphest] [Commented On] T104187: Move services in DataModel to DataModel Services

JeroenDeDauw added a comment. I've updated the list. Let's move on with moving the stuff :) TASK DETAIL https://phabricator.wikimedia.org/T104187 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: JeroenDeDauw Cc: hoo, Tpt, thiemowmde, Addshore, Bene,

[Wikidata-bugs] [Maniphest] [Commented On] T104187: Move services in DataModel to DataModel Services

thiemowmde added a comment. > GuidParser in DataModel and the GuidGenerator in Wikibase Lib. The idea is to > move both to DataModel services. That's cool, thanks for pointing this out. > "deconstruct". Means "parse". TASK DETAIL https://phabricator.wikimedia.org/T104187 EMAIL PREFERENC

[Wikidata-bugs] [Maniphest] [Commented On] T104187: Move services in DataModel to DataModel Services

Bene added a comment. - No to `PropertyIdProvider`, it's a useful interface and should remain in Wikibase DataModel. Otherwise, classes cannot implement it. - Agree with @thiemowmde on the `LegacyIdInterpreter` - `ByPropertyIdGrouper` should go into DataModel Services. I don't think it should be

[Wikidata-bugs] [Maniphest] [Commented On] T104187: Move services in DataModel to DataModel Services

JeroenDeDauw added a comment. On StatementGuidParser: Right now we have the GuidParser in DataModel and the GuidGenerator in Wikibase Lib. The idea is to move both to DataModel services. Does that not improve the situation? Am I forgetting about something else? I'm not sure what is being referr

[Wikidata-bugs] [Maniphest] [Commented On] T104187: Move services in DataModel to DataModel Services

thiemowmde added a comment. - Parsers and lookups and such are obviously much closer to "services" than they are to a "model". - ByPropertyIdGrouper: I always found this class weird. It could even be rewritten to pass id serialization strings instead of EntityId objects. With this simple change

[Wikidata-bugs] [Maniphest] [Commented On] T104187: Move services in DataModel to DataModel Services

JeroenDeDauw added a comment. - ByPropertyIdGrouper - LegacyIdInterpreter - PropertyIdProvider (not entirely sure about this one) - Entity / EntityIdParser + derivatives - Entity / EntityIdParsingException - Entity / PropertyDataTypeLookup - Entity / InMemoryDataTypeLookup - Entity / PropertyLooku