gerritbot added a comment.
Change 68 merged by jenkins-bot:
SearchEntities return 'aliases' when not same as label
https://gerrit.wikimedia.org/r/68
TASK DETAIL
https://phabricator.wikimedia.org/T104273
EMAIL PREFERENCES
gerritbot added a comment.
Change 221876 merged by Addshore:
SearchEntities return 'aliases' when not same as label
https://gerrit.wikimedia.org/r/221876
TASK DETAIL
https://phabricator.wikimedia.org/T104273
EMAIL PREFERENCES
daniel added a subscriber: daniel.
daniel added a comment.
This issue is fallout of https://phabricator.wikimedia.org/T90692. The
suggester uses the contents of aliases to indicate why a term was matched (if
the label wasn't the match, it would have to be the alias). So when changing
the
gerritbot added a comment.
Change 221876 had a related patch set uploaded (by Addshore):
SearchEntities return 'aliases' when not same as label
https://gerrit.wikimedia.org/r/221876
TASK DETAIL
https://phabricator.wikimedia.org/T104273
EMAIL PREFERENCES
aude added a comment.
example api results
{
searchinfo: {
search: c
},
search: [
{
id: Q14,
url: http://wikidatawiki/wiki/Q14;,
label: Cairo,
match: {
type: label,
language: en,
text: Cairo
},
aliases: [
Cairo
]
},
{
id: Q155,
url:
aude added a comment.
i still see further issues, but my patch fixes the obvious issue.
On test.wikidata, if I search kitt, it shows Also known as: kitties, kitty
(e.g. two aliases) my patch doesn't fix that.
F186240: kittens.png https://phabricator.wikimedia.org/F186240
TASK DETAIL
gerritbot added a comment.
Change 221811 merged by jenkins-bot:
Add searchentities alias param only for alias search results
https://gerrit.wikimedia.org/r/221811
TASK DETAIL
https://phabricator.wikimedia.org/T104273
EMAIL PREFERENCES
gerritbot added a comment.
Change 221814 had a related patch set uploaded (by Hoo man):
Add searchentities alias param only for alias search results
https://gerrit.wikimedia.org/r/221814
TASK DETAIL
https://phabricator.wikimedia.org/T104273
EMAIL PREFERENCES
aude added a comment.
problem occurs with all suggestions (properties and values)
TASK DETAIL
https://phabricator.wikimedia.org/T104273
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: aude
Cc: aude, Aklapper, Wikidata-bugs, Malyacko, P.Copp
gerritbot added a subscriber: gerritbot.
gerritbot added a comment.
Change 221811 had a related patch set uploaded (by Aude):
Add searchentities alias param only for alias search results
https://gerrit.wikimedia.org/r/221811
TASK DETAIL
https://phabricator.wikimedia.org/T104273
EMAIL
gerritbot added a comment.
Change 221814 merged by jenkins-bot:
Add searchentities alias param only for alias search results
https://gerrit.wikimedia.org/r/221814
TASK DETAIL
https://phabricator.wikimedia.org/T104273
EMAIL PREFERENCES
11 matches
Mail list logo
