[Wikidata-bugs] [Maniphest] [Commented On] T106327: label normalization fails in Chrome / Opera / PhantomJS

2015-08-04 Thread gerritbot
gerritbot added a comment. Change 229090 had a related patch set uploaded (by Thiemo Mättig (WMDE)): Revert Revert Make label view multiline by default https://gerrit.wikimedia.org/r/229090 TASK DETAIL https://phabricator.wikimedia.org/T106327 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T106327: label normalization fails in Chrome / Opera / PhantomJS

2015-08-04 Thread thiemowmde
thiemowmde added a comment. The failing test was indeed unrelated. I can understand why the revert was done, but the same could have been done by simply commenting out the broken test case and opening a ticket. We do not have a normalization feature. This is an unintended side-effect of a CSS

[Wikidata-bugs] [Maniphest] [Commented On] T106327: label normalization fails in Chrome / Opera / PhantomJS

2015-08-04 Thread gerritbot
gerritbot added a comment. Change 229090 merged by jenkins-bot: Revert Revert Make label view multiline by default https://gerrit.wikimedia.org/r/229090 TASK DETAIL https://phabricator.wikimedia.org/T106327 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T106327: label normalization fails in Chrome / Opera / PhantomJS

2015-07-31 Thread WMDE-Fisch
WMDE-Fisch added a comment. Hey the test fail now because reverting the change changed the textarea to an input field again. The test expect a textarea. The failures are therefore unrelated to any real error. I will adjust the tests. see

[Wikidata-bugs] [Maniphest] [Commented On] T106327: label normalization fails in Chrome / Opera / PhantomJS

2015-07-30 Thread JanZerebecki
JanZerebecki added a comment. Same thing is broken on firefox:

[Wikidata-bugs] [Maniphest] [Commented On] T106327: label normalization fails in Chrome / Opera / PhantomJS

2015-07-28 Thread WMDE-Fisch
WMDE-Fisch added a comment. Why are you reverting the change without even thinking of the intentions behind it and the alternatives to fix this bug? TASK DETAIL https://phabricator.wikimedia.org/T106327 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/

[Wikidata-bugs] [Maniphest] [Commented On] T106327: label normalization fails in Chrome / Opera / PhantomJS

2015-07-28 Thread Addshore
Addshore added a comment. Yep, as @aude said :) The branch should be fixed asap (revert is the easiest way to do this). Then the revert is up on master as an option, of course a better / different fix before the next branch would be best! TASK DETAIL https://phabricator.wikimedia.org/T106327

[Wikidata-bugs] [Maniphest] [Commented On] T106327: label normalization fails in Chrome / Opera / PhantomJS

2015-07-28 Thread WMDE-Fisch
WMDE-Fisch added a comment. alright - excuse accepted :-)! TASK DETAIL https://phabricator.wikimedia.org/T106327 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: WMDE-Fisch Cc: aude, gerritbot, Addshore, Jonas, thiemowmde, Lydia_Pintscher, Aklapper,

[Wikidata-bugs] [Maniphest] [Commented On] T106327: label normalization fails in Chrome / Opera / PhantomJS

2015-07-28 Thread aude
aude added a subscriber: aude. aude added a comment. @WMDE-Fisch needs to be reverted at least in the deployment branch and think is the correct thing to do in master. then we when Thiemo and Lydia are back, we can get their input, work on a fix and un-revert TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T106327: label normalization fails in Chrome / Opera / PhantomJS

2015-07-28 Thread gerritbot
gerritbot added a subscriber: gerritbot. gerritbot added a comment. Change 227442 had a related patch set uploaded (by Addshore): Revert Make label view multiline by default https://gerrit.wikimedia.org/r/227442 TASK DETAIL https://phabricator.wikimedia.org/T106327 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T106327: label normalization fails in Chrome / Opera / PhantomJS

2015-07-28 Thread gerritbot
gerritbot added a comment. Change 227444 had a related patch set uploaded (by Addshore): Revert Make label view multiline by default https://gerrit.wikimedia.org/r/227444 TASK DETAIL https://phabricator.wikimedia.org/T106327 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T106327: label normalization fails in Chrome / Opera / PhantomJS

2015-07-28 Thread gerritbot
gerritbot added a comment. Change 227442 merged by jenkins-bot: Revert Make label view multiline by default https://gerrit.wikimedia.org/r/227442 TASK DETAIL https://phabricator.wikimedia.org/T106327 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: