[Wikidata-bugs] [Maniphest] [Commented On] T106588: Module ext.WikidataPageBanner should depend on oojs-ui-styles not oojs-ui

2015-07-23 Thread gerritbot
gerritbot added a subscriber: gerritbot. gerritbot added a comment. Change 226521 had a related patch set uploaded (by Sumit): Load oojs ui styles only for banner icons https://gerrit.wikimedia.org/r/226521 TASK DETAIL https://phabricator.wikimedia.org/T106588 EMAIL PREFERENCES https://pha

[Wikidata-bugs] [Maniphest] [Commented On] T106588: Module ext.WikidataPageBanner should depend on oojs-ui-styles not oojs-ui

2015-07-23 Thread matmarex
matmarex added a subscriber: matmarex. matmarex added a comment. Remember, 'dependencies' are completely ignored for modules loaded with `addModuleStyles()`, like 'ext.WikidataPageBanner'. Styles for OOjs UI widgets are loaded when you call `OutputPage::enableOOUI()`, which the extension correc

[Wikidata-bugs] [Maniphest] [Commented On] T106588: Module ext.WikidataPageBanner should depend on oojs-ui-styles not oojs-ui

2015-07-23 Thread Jdlrobson
Jdlrobson added a comment. Oh cool.. so he doesn't need to add the module at all. That's even better :) TASK DETAIL https://phabricator.wikimedia.org/T106588 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdlrobson Cc: matmarex, gerritbot, Aklapper

[Wikidata-bugs] [Maniphest] [Commented On] T106588: Module ext.WikidataPageBanner should depend on oojs-ui-styles not oojs-ui

2015-07-23 Thread gerritbot
gerritbot added a comment. Change 226521 merged by jenkins-bot: WikidataPageBanner remove oojs-ui dependency https://gerrit.wikimedia.org/r/226521 TASK DETAIL https://phabricator.wikimedia.org/T106588 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: