[Wikidata-bugs] [Maniphest] [Commented On] T110811: [RFC] Unify our JS codestyle with the MW codestyle

thiemowmde added a comment. For the record, this is what we decided to left out for now: - We decided to neither enforce `function()` nor `function ()` for now. - The components https://phabricator.wikimedia.org/tag/wikibase-datamodel-javascript/,

[Wikidata-bugs] [Maniphest] [Commented On] T110811: [RFC] Unify our JS codestyle with the MW codestyle

Ricordisamoa added a comment. Shall I abandon https://gerrit.wikimedia.org/r/233934 then? TASK DETAIL https://phabricator.wikimedia.org/T110811 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ricordisamoa Cc: Tobi_WMDE_SW, adrianheine,

[Wikidata-bugs] [Maniphest] [Commented On] T110811: [RFC] Unify our JS codestyle with the MW codestyle

gerritbot added a comment. Change 243097 merged by jenkins-bot: build: Enable jscs jsDoc rule 'requireReturnTypes' and make pass https://gerrit.wikimedia.org/r/243097 TASK DETAIL https://phabricator.wikimedia.org/T110811 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T110811: [RFC] Unify our JS codestyle with the MW codestyle

thiemowmde added a comment. > Shall I abandon https://gerrit.wikimedia.org/r/233934 then? In my opinion, yes. At least for now. We caused quite some trouble and rebases to this point. Would be nice to focus on more productive stuff. Don't get me wrong, I'm thankful for what you did. The fact

[Wikidata-bugs] [Maniphest] [Commented On] T110811: [RFC] Unify our JS codestyle with the MW codestyle

gerritbot added a comment. Change 233934 abandoned by Ricordisamoa: jscs: require space after "function", align with wikimedia preset Reason: https://phabricator.wikimedia.org/T110811#1696595 https://gerrit.wikimedia.org/r/233934 TASK DETAIL https://phabricator.wikimedia.org/T110811 EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T110811: [RFC] Unify our JS codestyle with the MW codestyle

gerritbot added a comment. Change 243090 merged by jenkins-bot: build: Enable jscs jsDoc rule 'checkParamNames' and make pass https://gerrit.wikimedia.org/r/243090 TASK DETAIL https://phabricator.wikimedia.org/T110811 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T110811: [RFC] Unify our JS codestyle with the MW codestyle

gerritbot added a comment. Change 242927 merged by jenkins-bot: JSCS: require space also after case, void, with, typeof https://gerrit.wikimedia.org/r/242927 TASK DETAIL https://phabricator.wikimedia.org/T110811 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T110811: [RFC] Unify our JS codestyle with the MW codestyle

gerritbot added a comment. Change 242615 merged by jenkins-bot: Enable JSCS rule requireSpaceAfterKeywords in "google" style https://gerrit.wikimedia.org/r/242615 TASK DETAIL https://phabricator.wikimedia.org/T110811 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T110811: [RFC] Unify our JS codestyle with the MW codestyle

gerritbot added a comment. Change 242927 had a related patch set uploaded (by JanZerebecki): JSCS: requre space also after case, void, with, typeof https://gerrit.wikimedia.org/r/242927 TASK DETAIL https://phabricator.wikimedia.org/T110811 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T110811: [RFC] Unify our JS codestyle with the MW codestyle

JanZerebecki added a comment. The only thing we could not agree on is requireSpaceAfterKeywords for function. TASK DETAIL https://phabricator.wikimedia.org/T110811 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: JanZerebecki Cc: Tobi_WMDE_SW,

[Wikidata-bugs] [Maniphest] [Commented On] T110811: [RFC] Unify our JS codestyle with the MW codestyle

gerritbot added a comment. Change 243083 had a related patch set uploaded (by Ricordisamoa): build: Enable jscs jsDoc rule 'checkTypes' and make pass https://gerrit.wikimedia.org/r/243083 TASK DETAIL https://phabricator.wikimedia.org/T110811 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T110811: [RFC] Unify our JS codestyle with the MW codestyle

gerritbot added a comment. Change 243090 had a related patch set uploaded (by Ricordisamoa): build: Enable jscs jsDoc rule 'checkParamNames' and make pass https://gerrit.wikimedia.org/r/243090 TASK DETAIL https://phabricator.wikimedia.org/T110811 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T110811: [RFC] Unify our JS codestyle with the MW codestyle

gerritbot added a comment. Change 243097 had a related patch set uploaded (by Ricordisamoa): build: Enable jscs jsDoc rule 'requireReturnTypes' and make pass https://gerrit.wikimedia.org/r/243097 TASK DETAIL https://phabricator.wikimedia.org/T110811 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T110811: [RFC] Unify our JS codestyle with the MW codestyle

gerritbot added a comment. Change 243083 merged by jenkins-bot: build: Enable jscs jsDoc rule 'checkTypes' and make pass https://gerrit.wikimedia.org/r/243083 TASK DETAIL https://phabricator.wikimedia.org/T110811 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T110811: [RFC] Unify our JS codestyle with the MW codestyle

thiemowmde added a comment. Patches for review: - https://gerrit.wikimedia.org/r/242615 - https://github.com/wmde/ValueView/pull/195 TASK DETAIL https://phabricator.wikimedia.org/T110811 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde

[Wikidata-bugs] [Maniphest] [Commented On] T110811: [RFC] Unify our JS codestyle with the MW codestyle

gerritbot added a comment. Change 242615 had a related patch set uploaded (by Thiemo Mättig (WMDE)): Enable JSCS rule requireSpaceAfterKeywords https://gerrit.wikimedia.org/r/242615 TASK DETAIL https://phabricator.wikimedia.org/T110811 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T110811: [RFC] Unify our JS codestyle with the MW codestyle

Tobi_WMDE_SW added a comment. committed for https://phabricator.wikimedia.org/tag/wikidata-sprint-2015-09-29/: @thiemowmde and @jonas and @janzerebecki sit together and decide on this. TASK DETAIL https://phabricator.wikimedia.org/T110811 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T110811: [RFC] Unify our JS codestyle with the MW codestyle

Lydia_Pintscher added a comment. long run win > short term pain? :) TASK DETAIL https://phabricator.wikimedia.org/T110811 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: adrianheine, Lydia_Pintscher Cc: adrianheine, JanZerebecki, Ricordisamoa,

[Wikidata-bugs] [Maniphest] [Commented On] T110811: [RFC] Unify our JS codestyle with the MW codestyle

adrianheine added a comment. I don't feel strongly about the coding style change. In the long run it probably makes sense to have Wikibase PHP and Wikibase JS as well as Wikibase JS and MediaWiki JS follow the same coding style. I'm not looking forward to the merge conflicts this will give us,

[Wikidata-bugs] [Maniphest] [Commented On] T110811: [RFC] Unify our JS codestyle with the MW codestyle

Tobi_WMDE_SW added a comment. AFAIK the ticket was created based on a patch that was uploaded **before** before the topic was discussed and by someone who was not aware of our Wikibase JS coding conventions .

[Wikidata-bugs] [Maniphest] [Commented On] T110811: [RFC] Unify our JS codestyle with the MW codestyle

Lydia_Pintscher added a comment. In https://phabricator.wikimedia.org/T110811#1640976, @Tobi_WMDE_SW wrote: > My suggestion: Let's stick with > https://www.mediawiki.org/wiki/Wikibase/Coding_conventions#JavaScript_style_policies. > Thoughts were put into this by the JS developers in our team

[Wikidata-bugs] [Maniphest] [Commented On] T110811: [RFC] Unify our JS codestyle with the MW codestyle

Tobi_WMDE_SW added a subscriber: Tobi_WMDE_SW. Tobi_WMDE_SW added a comment. My suggestion: Let's stick with https://www.mediawiki.org/wiki/Wikibase/Coding_conventions#JavaScript_style_policies. Thoughts were put into this by the JS developers in our team back then. I'm not against changing it

[Wikidata-bugs] [Maniphest] [Commented On] T110811: [RFC] Unify our JS codestyle with the MW codestyle

Ricordisamoa added a comment. This is just to clarify that I had no intention whatsoever of changing established conventions. I can help you set jscs up for whatever rules you want to follow. TASK DETAIL https://phabricator.wikimedia.org/T110811 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T110811: [RFC] Unify our JS codestyle with the MW codestyle

JanZerebecki added a comment. Does https://github.com/jscs-dev/node-jscs/blob/master/presets/wikimedia.json contain a rule for the function() vs. function () ? I not we should add one upstream. TASK DETAIL https://phabricator.wikimedia.org/T110811 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T110811: [RFC] Unify our JS codestyle with the MW codestyle

Ricordisamoa added a comment. In https://phabricator.wikimedia.org/T110811#1606300, @JanZerebecki wrote: > Does https://github.com/jscs-dev/node-jscs/blob/master/presets/wikimedia.json > contain a rule for the function() vs. function () ? I not we should add one > upstream.

[Wikidata-bugs] [Maniphest] [Commented On] T110811: [RFC] Unify our JS codestyle with the MW codestyle

JanZerebecki added a comment. Now I get it, I was confused by the setting it to true vs an array of words. In https://phabricator.wikimedia.org/T110811#1606110, @thiemowmde wrote: > In PHP `public function foo( $param )` does not have a space, calling > `$this->foo( $param )` does not have a

[Wikidata-bugs] [Maniphest] [Commented On] T110811: [RFC] Unify our JS codestyle with the MW codestyle

Ricordisamoa added a comment. In https://phabricator.wikimedia.org/T110811#1606110, @thiemowmde wrote: > A strong no to `function ()` with a space. This contradicts the reasoning > behind this "space vs. no space" rule: function declarations and calls never > have a space. In PHP `public

[Wikidata-bugs] [Maniphest] [Commented On] T110811: [RFC] Unify our JS codestyle with the MW codestyle

JanZerebecki added a subscriber: JanZerebecki. JanZerebecki added a comment. I'm for aligning with wikimedia core. TASK DETAIL https://phabricator.wikimedia.org/T110811 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: JanZerebecki Cc: JanZerebecki,

[Wikidata-bugs] [Maniphest] [Commented On] T110811: [RFC] Unify our JS codestyle with the MW codestyle

gerritbot added a subscriber: gerritbot. gerritbot added a comment. Change 233934 had a related patch set uploaded (by Jonas Kress (WMDE)): jscs: require space after all keywords, align with wikimedia preset https://gerrit.wikimedia.org/r/233934 TASK DETAIL