[Wikidata-bugs] [Maniphest] [Commented On] T110904: Banners should support extraClassNames parameter

2015-12-15 Thread Jdlrobson
Jdlrobson added a comment. @Victorbarbu yeh I think it might be overkill - we are probably good without them! TASK DETAIL https://phabricator.wikimedia.org/T110904 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Victorbarbu, Jdlrobson Cc: gerritbot

[Wikidata-bugs] [Maniphest] [Commented On] T110904: Banners should support extraClassNames parameter

2015-12-15 Thread gerritbot
gerritbot added a comment. Change 259152 merged by jenkins-bot: Added WikidataPageBanner support for extraClass https://gerrit.wikimedia.org/r/259152 TASK DETAIL https://phabricator.wikimedia.org/T110904 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/

[Wikidata-bugs] [Maniphest] [Commented On] T110904: Banners should support extraClassNames parameter

2015-12-15 Thread Victorbarbu
Victorbarbu added a comment. My pleasure! If it is still needed, I could try writing some tests, but I am not sure what could go wrong. TASK DETAIL https://phabricator.wikimedia.org/T110904 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Victorbar

[Wikidata-bugs] [Maniphest] [Commented On] T110904: Banners should support extraClassNames parameter

2015-12-15 Thread Jdlrobson
Jdlrobson added a comment. Thanks @Victorbarbu! :) TASK DETAIL https://phabricator.wikimedia.org/T110904 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Victorbarbu, Jdlrobson Cc: gerritbot, Victorbarbu, Sumit, Aklapper, Jdlrobson, Wikidata-bugs,

[Wikidata-bugs] [Maniphest] [Commented On] T110904: Banners should support extraClassNames parameter

2015-12-14 Thread Jdlrobson
Jdlrobson added a comment. Adding a php unit test might be advisable before calling this completely done! TASK DETAIL https://phabricator.wikimedia.org/T110904 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Victorbarbu, Jdlrobson Cc: gerritbot, Vic

[Wikidata-bugs] [Maniphest] [Commented On] T110904: Banners should support extraClassNames parameter

2015-12-14 Thread gerritbot
gerritbot added a subscriber: gerritbot. gerritbot added a comment. Change 259152 had a related patch set uploaded (by Victorbarbu): Added WikidataPageBanner support for extraClass https://gerrit.wikimedia.org/r/259152 TASK DETAIL https://phabricator.wikimedia.org/T110904 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T110904: Banners should support extraClassNames parameter

2015-12-14 Thread Victorbarbu
Victorbarbu added a comment. In https://phabricator.wikimedia.org/T110904#1878556, @Sumit wrote: > You can let the classes remain separated by space, as in the example. I haven't seen the example. Then I'll implement it as it is in the example TASK DETAIL https://phabricator.wikimedia.org/T

[Wikidata-bugs] [Maniphest] [Commented On] T110904: Banners should support extraClassNames parameter

2015-12-14 Thread Sumit
Sumit added a comment. You can let the classes remain separated by space, as in the example. TASK DETAIL https://phabricator.wikimedia.org/T110904 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Sumit Cc: Victorbarbu, Sumit, Aklapper, Jdlrobson, Wik

[Wikidata-bugs] [Maniphest] [Commented On] T110904: Banners should support extraClassNames parameter

2015-12-14 Thread Victorbarbu
Victorbarbu added a subscriber: Victorbarbu. Victorbarbu added a comment. I am currently working on implementing this feature. The model I have in mind is this one: property name will be `extraClasses`. The property will support multiple classes separated by semicolons `;` (I believe semicolon

[Wikidata-bugs] [Maniphest] [Commented On] T110904: Banners should support extraClassNames parameter

2015-12-05 Thread Aklapper
Aklapper added a comment. Imported as https://codein.withgoogle.com/dashboard/tasks/5166743517396992/ TASK DETAIL https://phabricator.wikimedia.org/T110904 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Aklapper Cc: Sumit, Aklapper, Jdlrobson, Wiki

[Wikidata-bugs] [Maniphest] [Commented On] T110904: Banners should support extraClassNames parameter

2015-11-18 Thread Sumit
Sumit added a subscriber: Sumit. Sumit added a comment. I'd be ready to mentor this in GCI 2015. TASK DETAIL https://phabricator.wikimedia.org/T110904 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Sumit Cc: Sumit, Aklapper, Jdlrobson, Wikidata-bug