[Wikidata-bugs] [Maniphest] [Commented On] T111511: [Task] Adapt ComparativeValueParserFactory to new data types system

2015-09-11 Thread gerritbot
gerritbot added a comment. Change 237428 merged by jenkins-bot: Adapt ComparativeValueParserFactory to new data types system https://gerrit.wikimedia.org/r/237428 TASK DETAIL https://phabricator.wikimedia.org/T111511 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T111511: [Task] Adapt ComparativeValueParserFactory to new data types system

2015-09-10 Thread gerritbot
gerritbot added a subscriber: gerritbot. gerritbot added a comment. Change 237413 had a related patch set uploaded (by Aude): Adapt ComparativeValueParserFactory to new data types system [WIP] https://gerrit.wikimedia.org/r/237413 TASK DETAIL https://phabricator.wikimedia.org/T111511 EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T111511: [Task] Adapt ComparativeValueParserFactory to new data types system

2015-09-10 Thread aude
aude added a comment. I have an initial version: https://gerrit.wikimedia.org/r/#/c/237413/ I don't think buildComparativeValueParser should be moved, but ComparativeValueParserFactory should get DataTypeDefinitions in the constructor (passed via ExternalValidationServices from WikibaseRepo

[Wikidata-bugs] [Maniphest] [Commented On] T111511: [Task] Adapt ComparativeValueParserFactory to new data types system

2015-09-10 Thread gerritbot
gerritbot added a comment. Change 237428 had a related patch set uploaded (by Aude): Adapt ComparativeValueParserFactory to new data types system https://gerrit.wikimedia.org/r/237428 TASK DETAIL https://phabricator.wikimedia.org/T111511 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T111511: [Task] Adapt ComparativeValueParserFactory to new data types system

2015-09-10 Thread gerritbot
gerritbot added a comment. Change 237413 abandoned by Aude: Adapt ComparativeValueParserFactory to new data types system [WIP] https://gerrit.wikimedia.org/r/237413 TASK DETAIL https://phabricator.wikimedia.org/T111511 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T111511: [Task] Adapt ComparativeValueParserFactory to new data types system

2015-09-10 Thread gerritbot
gerritbot added a comment. Change 237390 merged by jenkins-bot: Add getter in WikibaseRepo for DataTypeDefinitions https://gerrit.wikimedia.org/r/237390 TASK DETAIL https://phabricator.wikimedia.org/T111511 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T111511: [Task] Adapt ComparativeValueParserFactory to new data types system

2015-09-09 Thread Addshore
Addshore added a subscriber: Addshore. Addshore added a comment. Marking as high priority. The longer this is put off the more broken ExternalValidation is likely to become TASK DETAIL https://phabricator.wikimedia.org/T111511 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T111511: [Task] Adapt ComparativeValueParserFactory to new data types system

2015-09-09 Thread daniel
daniel added a comment. @aude wanted to poke at it. Maybe I can pair up with her tomorrow and get this done. TASK DETAIL https://phabricator.wikimedia.org/T111511 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: aude, daniel Cc: Addshore, daniel,

[Wikidata-bugs] [Maniphest] [Commented On] T111511: [Task] Adapt ComparativeValueParserFactory to new data types system

2015-09-09 Thread JeroenDeDauw
JeroenDeDauw added a comment. Daniels commit chain has been merged, so we really should get onto this ASAP. Daniel: probably quickest if you fix it yourself. As a bonus, you'll get direct feedback on the changes you made. TASK DETAIL https://phabricator.wikimedia.org/T111511 EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T111511: [Task] Adapt ComparativeValueParserFactory to new data types system

2015-09-07 Thread daniel
daniel added a comment. Status quo: ComparativeValueParserFactory has one relevant method: newComparativeValueParser( DumpMetaInformation $dumpMetaInformation ) which returns a ComparativeValueParser based on $dumpMetaInformation and the formatter factory freturned by the private method

[Wikidata-bugs] [Maniphest] [Commented On] T111511: [Task] Adapt ComparativeValueParserFactory to new data types system

2015-09-06 Thread JeroenDeDauw
JeroenDeDauw added a subscriber: JeroenDeDauw. JeroenDeDauw added a comment. Once again bitten by not having releases of the components in Wikibase.git. TASK DETAIL https://phabricator.wikimedia.org/T111511 EMAIL PREFERENCES