Wrh2 added a comment.
The individual who originally reported this issue now also says it is fixed.
Thanks again Sumit - this task can now be closed.
TASK DETAIL
https://phabricator.wikimedia.org/T111710
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
Wrh2 added a comment.
I was unable to reproduce the issue just now, but have also asked for feedback
from the original reporters at
https://en.wikivoyage.org/wiki/Wikivoyage:Travellers'_pub#banner_not_displaying.
Thanks for the quick attention.
TASK DETAIL
Sumit added a comment.
@Wrh2, the above fix has been deployed on English Wikivoyage. To test, I tried
repeated refreshing after cache clearing each time on
https://en.wikivoyage.org/wiki/Bertha_Benz_Memorial_Route. However I wasn't
able to reproduce the issue. If the issue still persists, let
gerritbot added a subscriber: gerritbot.
gerritbot added a comment.
Change 236735 had a related patch set uploaded (by Sumit):
WikidataPageBanner set focus after banner load
https://gerrit.wikimedia.org/r/236735
TASK DETAIL
https://phabricator.wikimedia.org/T111710
EMAIL PREFERENCES
Sumit added a comment.
@Jdlrobson, I've added a fix, but since I'm unable to see the issue locally,
I'll need your support for testing.
@Wrh2, I've tried testing the fix on Wikivoyage, by adding the code at
https://en.wikivoyage.org/wiki/User:Sumit.iitp/common.js It seems to work and
I've
gerritbot added a comment.
Change 236735 merged by jenkins-bot:
WikidataPageBanner set focus after banner load
https://gerrit.wikimedia.org/r/236735
TASK DETAIL
https://phabricator.wikimedia.org/T111710
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
Wrh2 added a comment.
@Sumit - see my second comment on this ticket. I've tried updating my
common.js file with the Javascript Jdlrobson suggested, as well as the
Javascript you provided, but in both cases I'm still able to reproduce the
problem. It appears that either Firefox is firing the
Wrh2 added a comment.
@Jdlrobson I tried the code you provided in my local common.js, as well as
executing on window.load (since the JQuery load event handler can be flaky) but
was still able to reproduce the issue.
This might not be a great workaround, but if I'm understanding the purpose of
