Reedy added a comment.
In https://phabricator.wikimedia.org/T114538#1705551, @TFlanagan-WMF wrote:
> Jumping in for the education team. We have many programs that are dependent
> on the education program extension (however flawed it may be) on over a dozen
> Wikimedia projects, so I would ask
Reedy added a comment.
Suggestions for a repo name? :D
TASK DETAIL
https://phabricator.wikimedia.org/T114538
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Reedy
Cc: Ricordisamoa, gerritbot, AKoval_WMF, FloorKoudijs, TFlanagan-WMF, hoo,
aude,
gerritbot added a comment.
Change 243966 merged by jenkins-bot:
Remove ORM use from DBSiteStore
https://gerrit.wikimedia.org/r/243966
TASK DETAIL
https://phabricator.wikimedia.org/T114538
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: gerritbot
aude added a subscriber: aude.
aude added a comment.
Unless I am forgetting something, I think the only places in Wikibase (and
core) that use ORM are the sites table and wb_changes table. imho, sites
should move away from using a database backend altogether. (the sites
information is config
JeroenDeDauw added a comment.
Those are also the 3 places I'm aware of, and I agree they all those move away
from using this code. If the sites stuff and Wikibase do this, then you could
move the ORM code to the EP extension.
TASK DETAIL
https://phabricator.wikimedia.org/T114538
EMAIL
gerritbot added a comment.
Change 243966 had a related patch set uploaded (by Anomie):
Remove ORM use from DBSiteStore
https://gerrit.wikimedia.org/r/243966
TASK DETAIL
https://phabricator.wikimedia.org/T114538
EMAIL PREFERENCES
Reedy added a comment.
16:05:52 Fatal error: Class undefined: ORMTable in
/mnt/jenkins-workspace/workspace/mediawiki-phpunit-hhvm/src/includes/site/DBSiteStore.php
on line 346
DAMN IT
TASK DETAIL
https://phabricator.wikimedia.org/T114538
EMAIL PREFERENCES
gerritbot added a subscriber: gerritbot.
gerritbot added a comment.
Change 243945 had a related patch set uploaded (by Reedy):
[WIP] Remove ORM code from core
https://gerrit.wikimedia.org/r/243945
TASK DETAIL
https://phabricator.wikimedia.org/T114538
EMAIL PREFERENCES
Reedy added a comment.
EducationProgram and Wikidata/Wikibase seem to be the only real users of this
code
So, it wants extracting from core into a separate repo. Adding to the WMF
vendor repo (for extension purposes), and then said repo wants adding as a
dependancy via composer to
