gerritbot added a comment.
Change 246190 merged by jenkins-bot:
Fix rc comments for pages directly affected by a sitelink change
https://gerrit.wikimedia.org/r/246190
TASK DETAIL
https://phabricator.wikimedia.org/T114664
EMAIL PREFERENCES
gerritbot added a comment.
Change 246190 had a related patch set uploaded (by Hoo man):
Fix rc comments for pages directly affected by a sitelink change
https://gerrit.wikimedia.org/r/246190
TASK DETAIL
https://phabricator.wikimedia.org/T114664
EMAIL PREFERENCES
daniel added a comment.
@hoo you are right, I was confused about what the issue is here.
TASK DETAIL
https://phabricator.wikimedia.org/T114664
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: daniel
Cc: hoo, Jonas, MGChecker, Ricordisamoa, aude,
hoo added a comment.
In https://phabricator.wikimedia.org/T114664#1703768, @daniel wrote:
> @hoo or we could just not call SiteLinkCommentCreator if the affected page
> isn't the connected page. ChangeHandler::getEditComment() should have the
> necessary knowledge.
But we have to call
daniel added a comment.
@hoo or we could just not call SiteLinkCommentCreator if the affected page
isn't the connected page. ChangeHandler::getEditComment() should have the
necessary knowledge.
TASK DETAIL
https://phabricator.wikimedia.org/T114664
EMAIL PREFERENCES
hoo added a subscriber: hoo.
hoo added a comment.
`SiteLinkCommentCreator` doesn't know about which page it is currently
formatting a comment for, so that it can't do this right now. In order to fix
that, `SiteLinkCommentCreator` needs to be made aware of the page that it's
formatting a
