Wrh2 added a comment.
I don't recall seeing a "1" for the TOC since we purged the cache for all
articles last week, so it's probably safe to call this issue resolved now.
TASK DETAIL
https://phabricator.wikimedia.org/T115719
EMAIL PREFERENCES
Wrh2 added a comment.
On English Wikivoyage I just made a minor edit to
https://en.wikivoyage.org/wiki/Template:Pagebanner which should hopefully force
a cache purge for all pages using that template. It seems to have done the
trick for the handful of pages that I checked -
Jdlrobson added a comment.
Actually I had an idea...
Add this code to MediaWiki:Mobile.js and it will purge existing pages when the
problem is encountered (e.g. crowd source purging the cache where needed)
if ($( '.wpb-banner-toc' ).text() === '1' ) { $.post( mw.util.getUrl(
mw.config.get(
Jdlrobson added a comment.
^ that comment was directed at @Atsirlin
TASK DETAIL
https://phabricator.wikimedia.org/T115719
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Jdlrobson
Cc: Atsirlin, gerritbot, Wrh2, Sumit, Aklapper, Jdlrobson,
Jdlrobson added a comment.
You have an unclosed comment in
https://ru.wikivoyage.org/wiki/MediaWiki:Mobile.js!
TASK DETAIL
https://phabricator.wikimedia.org/T115719
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Jdlrobson
Cc: Atsirlin, gerritbot,
Jdlrobson added a comment.
You can also put this in MediaWiki:Vector.js (more users on desktop so might
get resolved quicker)
TASK DETAIL
https://phabricator.wikimedia.org/T115719
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Jdlrobson
Cc:
Sumit added a comment.
I did a manual purge on a few pages for the change to take effect and hopefully
the problem seems to be fixed, so as the pages get purged, problem should go
away.
TASK DETAIL
https://phabricator.wikimedia.org/T115719
EMAIL PREFERENCES
Wrh2 added a comment.
It may be too early for feedback since the updated extension apparently just
went out today, but in a random sample of articles on Wikivoyage just now I
would say that the majority of them exhibited the behavior with the incorrect
TOC, so it may be premature to mark this
Jdlrobson added a comment.
Unfortunately since the table of contents is baked into the page HTML there is
no way to fix existing pages edited before today -we'll have to wait for them
to rectify themselves :-( but this change should stop it happening again. Let
me know if you see a page
gerritbot added a comment.
Change 248277 merged by jenkins-bot:
WikidataPageBanner add a separate flag for toc
https://gerrit.wikimedia.org/r/248277
TASK DETAIL
https://phabricator.wikimedia.org/T115719
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
gerritbot added a subscriber: gerritbot.
gerritbot added a comment.
Change 248277 had a related patch set uploaded (by Sumit):
WikidataPageBanner add a separate flag for toc
https://gerrit.wikimedia.org/r/248277
TASK DETAIL
https://phabricator.wikimedia.org/T115719
EMAIL PREFERENCES
Sumit added a comment.
I was unable to reproduce the issue locally, however still I've added a patch
to separate actual toc from the flag which stores true or false to show toc or
now. That should hopefully solve the issue.
TASK DETAIL
https://phabricator.wikimedia.org/T115719
EMAIL
Wrh2 added a subscriber: Wrh2.
Wrh2 added a comment.
I'm not sure if this is helpful or not, but when this issue first surfaced it
was proposed that it might be a caching issue, and that over time it would go
away. https://en.wikivoyage.org/wiki/Morro_Bay is an article that I have
edited
13 matches
Mail list logo
