[Wikidata-bugs] [Maniphest] [Commented On] T122748: Support putting extension.json in a callback

2016-01-02 Thread Paladox
Paladox added a comment. How can I migrate wikibase to extension registration since I have tried here https://gerrit.wikimedia.org/r/#/c/229119/ but keeps failing and I am not sure why. TASK DETAIL https://phabricator.wikimedia.org/T122748 EMAIL PREFERENCES https://phabricator.wikimedia.o

[Wikidata-bugs] [Maniphest] [Commented On] T122748: Support putting extension.json in a callback

2016-01-02 Thread Florian
Florian added a comment. "putting extension.json in a callback" doesn't make sense for me :) I'm pretty sure, if Wikibase will be converted to extension.json, that it will work with the current implemenation of ExtensionRegistration :) In https://phabricator.wikimedia.org/T122748#1912873, @Pala

[Wikidata-bugs] [Maniphest] [Commented On] T122748: Support putting extension.json in a callback

2016-01-02 Thread Paladox
Paladox added a comment. Sorry I doint have steps to reproduce since it isent broken. this is a feature request. Currently wikibase uses callbacks for some of its code. In extension.json to do a callback you have to set "callback": "example::example" but if you have most of your code that need

[Wikidata-bugs] [Maniphest] [Commented On] T122748: Support putting extension.json in a callback

2016-01-02 Thread Florian
Florian added a comment. In https://phabricator.wikimedia.org/T122748#1912840, @Paladox wrote: > What I think we should do is have an extension.json file that is the main > file then add code for "example require-extension":"extension2.json." that > will hold the callback. I'm not sure, how y

[Wikidata-bugs] [Maniphest] [Commented On] T122748: Support putting extension.json in a callback

2016-01-02 Thread Paladox
Paladox added a comment. Well because wikibase file looks like for example https://github.com/wikimedia/mediawiki-extensions-Wikibase/blob/master/client/WikibaseClient.php some is a callback and some isen't. The extension fails because some of the code should be outside of the callback and the

[Wikidata-bugs] [Maniphest] [Commented On] T122748: Support putting extension.json in a callback

2016-01-02 Thread Florian
Florian added a subscriber: Florian. Florian added a comment. I really don't understand, what you mean/want? What should be run in a callback and why? TASK DETAIL https://phabricator.wikimedia.org/T122748 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/

[Wikidata-bugs] [Maniphest] [Commented On] T122748: Support putting extension.json in a callback

2016-01-02 Thread Paladox
Paladox added a comment. The workaround is to be everything in the callback hook in extension.json which would make the file pointless if we have too do that. TASK DETAIL https://phabricator.wikimedia.org/T122748 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailprefe