[Wikidata-bugs] [Maniphest] [Commented On] T126073: Wikidata QUnit broken on branch REL1_25 causing other extensions to fail

JanZerebecki added a comment. https://gerrit.wikimedia.org/r/#/c/269310/ is an implementation for 1 TASK DETAIL https://phabricator.wikimedia.org/T126073 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Paladox, JanZerebecki Cc: aude, JanZerebecki, K

[Wikidata-bugs] [Maniphest] [Commented On] T126073: Wikidata QUnit broken on branch REL1_25 causing other extensions to fail

JanZerebecki added a comment. Yes I'm fine with 5, too. TASK DETAIL https://phabricator.wikimedia.org/T126073 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Paladox, JanZerebecki Cc: aude, JanZerebecki, Krinkle, hashar, StudiesWorld, Paladox, Aklap

[Wikidata-bugs] [Maniphest] [Commented On] T126073: Wikidata QUnit broken on branch REL1_25 causing other extensions to fail

Paladox added a comment. I think that the issues come into play when they are creating the branches for release they set it back in certain time so it may be fixed In master but broke in the release branch. TASK DETAIL https://phabricator.wikimedia.org/T126073 EMAIL PREFERENCES https://ph

[Wikidata-bugs] [Maniphest] [Commented On] T126073: Wikidata QUnit broken on branch REL1_25 causing other extensions to fail

Paladox added a comment. ValueView is not the only problem its repo, lib, view possibly others. TASK DETAIL https://phabricator.wikimedia.org/T126073 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Paladox Cc: hashar, StudiesWorld, Paladox, Aklapper

[Wikidata-bugs] [Maniphest] [Commented On] T126073: Wikidata QUnit broken on branch REL1_25 causing other extensions to fail

Mattflaschen added a comment. In https://phabricator.wikimedia.org/T126073#2004334, @Paladox wrote: > @Mattflaschen I found a better solution we could cut off unit tests with a > config so I have been going through all of wikidata doing that. Ive name the > config $wmgUseWikidataTest and disabl

[Wikidata-bugs] [Maniphest] [Commented On] T126073: Wikidata QUnit broken on branch REL1_25 causing other extensions to fail

Paladox added a comment. @Mattflaschen yes it is possible by using grunt or npm. But we would need to do that In mediawiki/core. TASK DETAIL https://phabricator.wikimedia.org/T126073 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Paladox Cc: hasha

[Wikidata-bugs] [Maniphest] [Commented On] T126073: Wikidata QUnit broken on branch REL1_25 causing other extensions to fail

Paladox added a comment. @Mattflaschen I found a better solution we could cut off unit tests with a config so I have been going through all of wikidata doing that. Ive name the config $wmgUseWikidataTest and disabled it by default. that way it isent a big change and can be done at a later point

[Wikidata-bugs] [Maniphest] [Commented On] T126073: Wikidata QUnit broken on branch REL1_25 causing other extensions to fail

Mattflaschen added a comment. @Paladox Okay, I tried to figure out what you need to do. I think you need to update Wikibase composer.json on REL1_25 to a version with the expect fix . However, the

[Wikidata-bugs] [Maniphest] [Commented On] T126073: Wikidata QUnit broken on branch REL1_25 causing other extensions to fail

Mattflaschen added a comment. In https://phabricator.wikimedia.org/T126073#2004134, @Mattflaschen wrote: > You can. I'll try to fix T103346: phpunit hhvm failure: LuaSandbox: > TextLibraryTests[87]: json decode, invalid values (trailing comma) > upst

[Wikidata-bugs] [Maniphest] [Commented On] T126073: Wikidata QUnit broken on branch REL1_25 causing other extensions to fail

Paladox added a comment. @Mattflaschen ok will do it in a sec seems that tests on REL1_26 also fail but not as many fail. So for example scribunto fails with the same bug so I backported the change. But qunit fails with some kind of js file in core I think. also phplint fails with https://inte

[Wikidata-bugs] [Maniphest] [Commented On] T126073: Wikidata QUnit broken on branch REL1_25 causing other extensions to fail

Paladox added a comment. @Mattflaschen would you like me to do the assert.expect changes or are you doing them. TASK DETAIL https://phabricator.wikimedia.org/T126073 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mattflaschen, Paladox Cc: StudiesW

[Wikidata-bugs] [Maniphest] [Commented On] T126073: Wikidata QUnit broken on branch REL1_25 causing other extensions to fail

Paladox added a comment. @Mattflaschen ok. Is there any way we could prevent this happening to the branches in the future. TASK DETAIL https://phabricator.wikimedia.org/T126073 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mattflaschen, Paladox C

[Wikidata-bugs] [Maniphest] [Commented On] T126073: Wikidata QUnit broken on branch REL1_25 causing other extensions to fail

Mattflaschen added a comment. In https://phabricator.wikimedia.org/T126073#2004046, @Paladox wrote: > Its really strange that this is causing wikidata on branch REL1_25 to fail. > Since REL1_25 was last updated sometime last year and that patch was uploaded > nearly 30 days ago. My hypothesis

[Wikidata-bugs] [Maniphest] [Commented On] T126073: Wikidata QUnit broken on branch REL1_25 causing other extensions to fail

Paladox added a comment. Its really strange that this is causing wikidata on branch REL1_25 to fail. Since REL1_25 was last updated sometime last year and that patch was uploaded nearly 30 days ago. TASK DETAIL https://phabricator.wikimedia.org/T126073 EMAIL PREFERENCES https://phabricato