gerritbot added a comment.
Change 274731 merged by jenkins-bot:
Add view-factory-callback to the entity type definitions
https://gerrit.wikimedia.org/r/274731
TASK DETAIL
https://phabricator.wikimedia.org/T127191
EMAIL PREFERENCES
daniel added a comment.
Waiting for related change: https://gerrit.wikimedia.org/r/#/c/274731/
TASK DETAIL
https://phabricator.wikimedia.org/T127191
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Bene, daniel
Cc: daniel, Bene, adrianheine,
gerritbot added a comment.
Change 274731 had a related patch set uploaded (by Bene):
Add view-factory-callback to the entity type definitions
https://gerrit.wikimedia.org/r/274731
TASK DETAIL
https://phabricator.wikimedia.org/T127191
EMAIL PREFERENCES
gerritbot added a comment.
Change 274393 merged by jenkins-bot:
Dispatch entity views based on callbacks
https://gerrit.wikimedia.org/r/274393
TASK DETAIL
https://phabricator.wikimedia.org/T127191
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
gerritbot added a comment.
Change 274393 had a related patch set uploaded (by Bene):
Dispatch entity views based on callbacks
https://gerrit.wikimedia.org/r/274393
TASK DETAIL
https://phabricator.wikimedia.org/T127191
EMAIL PREFERENCES
gerritbot added a comment.
Change 271345 merged by jenkins-bot:
Move entity type dispatching out of WikibaseView
https://gerrit.wikimedia.org/r/271345
TASK DETAIL
https://phabricator.wikimedia.org/T127191
EMAIL PREFERENCES
adrianheine added a comment.
In https://phabricator.wikimedia.org/T127191#2079460, @Bene wrote:
> `TemplateFactory` doesn't seem to serve a purpose here because we cannot
inject other templates from another component/extension. It might be nice to
make that class modular to be able to
Bene added a comment.
`TemplateFactory` doesn't seem to serve a purpose here because we cannot
inject other templates from another component/extension. It might be nice to
make that class modular to be able to support other template files as well but
for now it isn't useful for any other
adrianheine added a comment.
But `TemplateFactory` is constructed in `WikibaseRepo` via
`TemplateFactory::getDefaultInstance()` and then injected into
`EntityViewFactory`. The same could be done for a `MediaInfoViewFactory`.
TASK DETAIL
https://phabricator.wikimedia.org/T127191
EMAIL
Bene added a comment.
@adrianheine mainly because they need access to the TemplateFactory which
isn't available outside of Wikibase.
TASK DETAIL
https://phabricator.wikimedia.org/T127191
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Bene
Cc:
adrianheine added a comment.
In https://phabricator.wikimedia.org/T127191#2054679, @Bene wrote:
> I'd also add factory methods for the `StatementSectionsView` and
`EntityTermsView` because extensions of Wikibase defining new entity types want
to reuse those views.
Why is a
Bene added a comment.
In https://phabricator.wikimedia.org/T127191#2039646, @adrianheine wrote:
> From my point of view, `WikibaseView` is a component providing widgets for
a specific set of `WikibaseDataModel` concepts. Since the widgets for items and
properties use all other widgets,
adrianheine added a comment.
From my point of view, `WikibaseView` is a component providing widgets for a
specific set of `WikibaseDataModel` concepts. Since the widgets for items and
properties use all other widgets, we provide an `EntityViewFactory` wiring them
together.
gerritbot added a subscriber: gerritbot.
gerritbot added a comment.
Change 271345 had a related patch set uploaded (by Bene):
Allow injection of entity views
https://gerrit.wikimedia.org/r/271345
TASK DETAIL
https://phabricator.wikimedia.org/T127191
EMAIL PREFERENCES
14 matches
Mail list logo
