gerritbot added a comment.
Change 272755 merged by jenkins-bot:
Rewrite of getCurrentWord
https://gerrit.wikimedia.org/r/272755
TASK DETAIL
https://phabricator.wikimedia.org/T127721
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Jonas,
Smalyshev added a comment.
If we can't handle the second one yet, we should at least make it so that it
doesn't kill the wdt:https://phabricator.wikimedia.org/P31/ part, otherwise it
is rather weird. I think it would be better not having completion in this case
(then I just insert space
Jonas added a comment.
I fixed the first one, but I think the second one needs a complete rewrite of
getCurrentWord() in wikibase-rdf-hint.js.
TASK DETAIL
https://phabricator.wikimedia.org/T127721
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To:
gerritbot added a comment.
Change 272755 had a related patch set uploaded (by Jonas Kress (WMDE)):
Clean illegal characters from prefix
https://gerrit.wikimedia.org/r/272755
TASK DETAIL
https://phabricator.wikimedia.org/T127721
EMAIL PREFERENCES
Smalyshev added a comment.
AFAIR right now the code uses \S to grab words, I think it should use
something like \w.
TASK DETAIL
https://phabricator.wikimedia.org/T127721
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Smalyshev
Cc: Smalyshev,
