hoo added a comment.
In T132839#2776630, @Esc3300 wrote:
Maybe P106 and P17 could be a "classifying" ones as well.
P106 probably could, given it's only used on humans. I also thought about this myself before… please create a separate ticket for this.
P17 is used on so many different subjects (bu
hoo added a comment.
I poked at this a bit on Thursday and Friday and came up with a new idea which will (hopefully) significantly improve the suggestions given.
Currently there are two types of correlations that the suggester considers:
"Classifying" ones ("instance of" and "subclass of") where
Stashbot added a comment.
Mentioned in SAL (#wikimedia-operations) [2016-11-02T12:11:32Z] Updated Wikidata's property suggester with data from Monday's json dump and applied the T132839 workaroundsTASK DETAILhttps://phabricator.wikimedia.org/T132839EMAIL PREFERENCEShttps://phabricator.wikimedia.or
Stashbot added a comment.
Mentioned in SAL (#wikimedia-operations) [2016-10-13T10:31:25Z] Ran (updated) T132839-Workarounds.sh from my home in terbiumTASK DETAILhttps://phabricator.wikimedia.org/T132839EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: StashbotC
hoo added a comment.
I thought about this for a bit and have the following improvement in mind, which is going to work on the data structure we currently have, thus we can do a rather minimal change in the extension code in order to achieve this.
The current model being used is described on a very
Stashbot added a comment.
Mentioned in SAL (#wikimedia-operations) [2016-10-04T13:40:34Z] Updated Wikidata's property suggester with data from Monday's json dump and applied the T132839 workaroundsTASK DETAILhttps://phabricator.wikimedia.org/T132839EMAIL PREFERENCEShttps://phabricator.wikimedia.or
hoo added a comment.
Further updated the workaround:
It now also remove suggestions based on P18 (image) and P373 (commons category).TASK DETAILhttps://phabricator.wikimedia.org/T132839EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hooCc: AnjaJentzsch, Ladsgr
Stashbot added a comment.
Mentioned in SAL (#wikimedia-operations) [2016-09-14T15:50:56Z] Ran T132839-Workarounds.sh from my home in terbium (see T132839)TASK DETAILhttps://phabricator.wikimedia.org/T132839EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Stash
Stashbot added a comment.
Mentioned in SAL (#wikimedia-operations) [2016-09-14T15:50:56Z] Ran T132839-Workarounds.sh from my home in terbium (see T132839)TASK DETAILhttps://phabricator.wikimedia.org/T132839EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Stash
Stashbot added a comment.
Mentioned in SAL [2016-09-07T01:07:24Z] Updated Wikidata's property suggester with data from Monday's json dump and applied the T132839 workaroundsTASK DETAILhttps://phabricator.wikimedia.org/T132839EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpr
Stashbot added a comment.
Mentioned in SAL [2016-08-28T16:51:23Z] Ran T132839-Workarounds.sh from my home in terbium (see T132839)TASK DETAILhttps://phabricator.wikimedia.org/T132839EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: StashbotCc: AnjaJentzsch, Lad
Stashbot added a comment.
Mentioned in SAL [2016-08-28T16:51:23Z] Ran T132839-Workarounds.sh from my home in terbium (see T132839)TASK DETAILhttps://phabricator.wikimedia.org/T132839EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: StashbotCc: AnjaJentzsch, Lad
hoo added a comment.
Updated the workaround further, per @Sjoerddebruin:
hoo@terbium:~$ bash T132839-Workarounds.sh
Removing ext ids in item context
Batch 1: 0 rows
Removing P641 in item context
Batch 1: 0 rows
Removing P1344 in item context
Batch 1: 66 rows
Batch 2: 0 rows
Removing P463 in it
Stashbot added a comment.
Mentioned in SAL [2016-08-24T21:08:26Z] Ran DELETE FROM wbs_propertypairs WHERE pid1 = '641' on Wikidata for T132839TASK DETAILhttps://phabricator.wikimedia.org/T132839EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: StashbotCc: Tobi_
Stashbot added a comment.
Mentioned in SAL [2016-08-16T12:53:43Z] Put a better workaround for T132839 in place: Only remove property pairs with context = "item". This keeps ref and qualifier pairs for ext ids intact.TASK DETAILhttps://phabricator.wikimedia.org/T132839EMAIL PREFERENCEShttps://phabr
Stashbot added a comment.
Mentioned in SAL [2016-08-08T21:55:14Z] Updated Wikidata's property suggester with data from today's json dump and removed the external identifiers as a workaround for T132839TASK DETAILhttps://phabricator.wikimedia.org/T132839EMAIL PREFERENCEShttps://phabricator.wikimedi
Stashbot added a comment.
Mentioned in SAL [2016-07-07T08:33:55Z] Updated Wikidata's property suggester with data from Monday's json dump and removed the external identifiers as a workaround for T132839TASK DETAILhttps://phabricator.wikimedia.org/T132839EMAIL PREFERENCEShttps://phabricator.wikimed
Stashbot added a comment.
Mentioned in SAL [2016-05-28T19:47:45Z] Updated Wikidata's property
suggester with data from Monday's json dump and removed the external
identifiers as a workaround for https://phabricator.wikimedia.org/T132839
TASK DETAIL
https://phabricator.wikimedia.org/T13283
thiemowmde added a comment.
Thanks for the clarification, this is indeed an important difference.
Properties like ISBN are not classifying by value but by the pure fact that
they exist.
TASK DETAIL
https://phabricator.wikimedia.org/T132839
EMAIL PREFERENCES
https://phabricator.wikimedia
hoo added a comment.
In https://phabricator.wikimedia.org/T132839#2322937, @thiemowmde wrote:
> […]
> I suggest to:
>
> 1. Add unspecific identifiers that apply to all kinds of items to the
`$wgPropertySuggesterClassifyingPropertyIds` setting.
Why? I don't see how an identi
thiemowmde added a comment.
I believe this is wrong. There are "external-identifier" properties that
really should be suggested the moment it becomes clear what kind of item you
are editing. For example, something with "instanceof book" should get an ISBN
number a.s.a.p., and the other way a
daniel added a comment.
It does not look like PropertySuggester-Python is currently applying any
filtering based on data type (or value type). If we want to add such filtering,
the best place would probably be in `write_row` in `CsvWriter.php`. We could
also filter while reading the input fi
hoo added a comment.
In https://phabricator.wikimedia.org/T132839#2280617, @thiemowmde wrote:
> We also came up with a possible improvement: Some properties like "instance
of" and "Commons category" are not selective. The fact that this property
exists on an item does not say anything. W
thiemowmde added a comment.
FYI, I did an other run of code review on
https://github.com/Wikidata-lib/PropertySuggester-Python and
https://github.com/Wikidata-lib/PropertySuggester and could not find more
suspicious code. The Python script should produce massive amounts of warnings
when a d
thiemowmde added a comment.
We also came up with a possible improvement: Some properties like "instance
of" and "Commons category" are not selective. The fact that this property
exists on an item does not say anything. We think it's a good idea to add such
properties to a "non-selective" bla
hoo added a comment.
In https://phabricator.wikimedia.org/T132839#2280542, @Tobi_WMDE_SW wrote:
> @Lydia_pintscher suggests to look into the code again and find out whether
the problem comes from a change to Wikidata that's not reflected in
PropertySuggester.
We already did that
Tobi_WMDE_SW added a comment.
@Lydia_pintscher suggests to look into the code again and find out whether
the problem comes from a change to Wikidata that's not reflected in
PropertySuggester.
TASK DETAIL
https://phabricator.wikimedia.org/T132839
EMAIL PREFERENCES
https://phabricator.wik
Nikki added a comment.
The suggestions right now seem to be better than before, e.g. for the example
in the description I get `P131`, mouth of the watercourse, sex or gender, date
of birth. That still includes human properties, but at least mouth of the
watercourse actually shows up now.
Lydia_Pintscher added a comment.
@hoo removed the external IDs from the correlation table. This seems to
improve the situation for now. We'll still need to find a better solution
though.
TASK DETAIL
https://phabricator.wikimedia.org/T132839
EMAIL PREFERENCES
https://phabricator.wikimedi
Lydia_Pintscher added a comment.
@hoo tried the old correlation data and the suggestions are just as bad. This
indicates a problem with the code.
TASK DETAIL
https://phabricator.wikimedia.org/T132839
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To
Stashbot added a comment.
Mentioned in SAL [2016-05-06T11:10:01Z] Reverted the property suggester
data to data from the 20160411 dump (done testing
https://phabricator.wikimedia.org/T132839)
TASK DETAIL
https://phabricator.wikimedia.org/T132839
EMAIL PREFERENCES
https://phabricator.wik
Stashbot added a comment.
Mentioned in SAL [2016-05-06T11:02:30Z] Overwrote property suggester
data with data from the 20160215 dump
(https://phabricator.wikimedia.org/T132839)
TASK DETAIL
https://phabricator.wikimedia.org/T132839
EMAIL PREFERENCES
https://phabricator.wikimedia.org/set
hoo added a comment.
In https://phabricator.wikimedia.org/T132839#2239348, @thiemowmde wrote:
> Ideas we had in todays meeting:
>
> - Could it be that PropertySuggester ignores all new data types (e.g.
identifier)? On first look,
https://github.com/wmde/wbs_propertypairs/blob/master/
Lydia_Pintscher added a comment.
Yeah I think this is quite recent too.
I don't think splitting it between identifiers/nonidentifiers will solve the
underlying issue here.
I take it from Marius' comments that the correlation data didn't change
significantly. This leads me to suspect a
Nikki added a comment.
Its obsession with human properties does seem to be quite recent and
noticeable. If it had been like this all along, I'm not sure why I would
suddenly be noticing it so much now.
I'm not sure how your suggestion would work. None of the suggestions for the
example
Sjoerddebruin added a comment.
In https://phabricator.wikimedia.org/T132839#2213354, @hoo wrote:
> Can anyone confirm this is a recent regression? I have the feeling it is,
but I don't really know the old suggestions well enough to say for sure.
>
> A possible solution I could think o
hoo added a comment.
Can anyone confirm this is a recent regression? I have the feeling it is, but
I don't really know the old suggestions well enough to say for sure.
A possible solution I could think of: Make the suggester smarter about
statement groups (so that it only suggests extern
37 matches
Mail list logo
