gerritbot added a comment.
Change 353896 abandoned by Daniel Kinzler:
Re-apply "Drop EntityPerPage" [DNM]
https://gerrit.wikimedia.org/r/353896TASK DETAILhttps://phabricator.wikimedia.org/T140890EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup,
gerritbot added a comment.
Change 353897 abandoned by Daniel Kinzler:
Re-apply "Adapt Lexeme to removed EntityPerPage table and services"
https://gerrit.wikimedia.org/r/353897TASK DETAILhttps://phabricator.wikimedia.org/T140890EMAIL
gerritbot added a comment.
Change 384723 merged by Jcrespo:
[operations/puppet@production] mediawiki: Remove the cronjob for rebuilding entity_per_page table
https://gerrit.wikimedia.org/r/384723TASK DETAILhttps://phabricator.wikimedia.org/T140890EMAIL
gerritbot added a comment.
Change 384723 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[operations/puppet@production] mediawiki: Remove the cronjob for rebuilding entity_per_page table
https://gerrit.wikimedia.org/r/384723TASK
gerritbot added a comment.
Change 352574 merged by Jcrespo:
[operations/puppet@production] Do not rebuild wb_entity_per_page
https://gerrit.wikimedia.org/r/352574TASK DETAILhttps://phabricator.wikimedia.org/T140890EMAIL
gerritbot added a comment.
Change 352797 merged by ArielGlenn:
[operations/puppet@production] Do not make dumps of wb_entity_per_page
https://gerrit.wikimedia.org/r/352797TASK DETAILhttps://phabricator.wikimedia.org/T140890EMAIL
gerritbot added a comment.
Change 382671 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Remove EntityPerPage
https://gerrit.wikimedia.org/r/382671TASK DETAILhttps://phabricator.wikimedia.org/T140890EMAIL
gerritbot added a comment.
Change 382671 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/extensions/WikibaseMediaInfo@master] Remove EntityPerPage
https://gerrit.wikimedia.org/r/382671TASK DETAILhttps://phabricator.wikimedia.org/T140890EMAIL
gerritbot added a comment.
Change 382666 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Remove EntityPerPage
https://gerrit.wikimedia.org/r/382666TASK DETAILhttps://phabricator.wikimedia.org/T140890EMAIL
gerritbot added a comment.
Change 382666 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/extensions/WikibaseLexeme@master] Remove EntityPerPage
https://gerrit.wikimedia.org/r/382666TASK DETAILhttps://phabricator.wikimedia.org/T140890EMAIL
gerritbot added a comment.
Change 382461 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Remove a ton of unused code from MockEntityIdPager
https://gerrit.wikimedia.org/r/382461TASK DETAILhttps://phabricator.wikimedia.org/T140890EMAIL
gerritbot added a comment.
Change 381751 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Drop EntityPerPage
https://gerrit.wikimedia.org/r/381751TASK DETAILhttps://phabricator.wikimedia.org/T140890EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To:
hoo added a comment.
In T140890#3661547, @Lydia_Pintscher wrote:
In T140890#3652104, @hoo wrote:
Has no longer updating the table been properly announced?
Do you mean https://lists.wikimedia.org/pipermail/wikidata-tech/2017-June/001136.html ?
Sounds good to me. As the table will only slowly
Lydia_Pintscher added a comment.
In T140890#3652104, @hoo wrote:
Has no longer updating the table been properly announced?
Do you mean https://lists.wikimedia.org/pipermail/wikidata-tech/2017-June/001136.html ?TASK DETAILhttps://phabricator.wikimedia.org/T140890EMAIL
gerritbot added a comment.
Change 382461 had a related patch set uploaded (by Thiemo Mättig (WMDE); owner: Thiemo Mättig (WMDE)):
[mediawiki/extensions/Wikibase@master] Remove a ton of unused code from MockEntityIdPager
https://gerrit.wikimedia.org/r/382461TASK
hoo added a comment.
Has no longer updating the table been properly announced?TASK DETAILhttps://phabricator.wikimedia.org/T140890EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, hooCc: PokestarFan, Lydia_Pintscher, WMDE-leszek, Ladsgroup, Aklapper,
gerritbot added a comment.
Change 381751 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/extensions/Wikibase@master] Drop EntityPerPage
https://gerrit.wikimedia.org/r/381751TASK DETAILhttps://phabricator.wikimedia.org/T140890EMAIL
Ladsgroup added a comment.
I think this needs to be in monitor column or something like that until the two weeks in between announcement and deploy is done.TASK DETAILhttps://phabricator.wikimedia.org/T140890EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To:
gerritbot added a comment.
Change 353897 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/extensions/WikibaseLexeme@master] Re-apply "Adapt Lexeme to removed EntityPerPage table and services"
https://gerrit.wikimedia.org/r/353897TASK
gerritbot added a comment.
Change 353896 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/extensions/Wikibase@master] Re-apply "Drop EntityPerPage" [DNM]
https://gerrit.wikimedia.org/r/353896TASK DETAILhttps://phabricator.wikimedia.org/T140890EMAIL
gerritbot added a comment.
Change 353892 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Revert "Drop EntityPerPage" as per https://phabricator.wikimedia.org/T140890#3263721.
https://gerrit.wikimedia.org/r/353892TASK DETAILhttps://phabricator.wikimedia.org/T140890EMAIL
gerritbot added a comment.
Change 353893 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Revert "Adapt Lexeme to removed EntityPerPage table and services" as per https://phabricator.wikimedia.org/T140890#3263721
https://gerrit.wikimedia.org/r/353893TASK
gerritbot added a comment.
Change 353893 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/extensions/WikibaseLexeme@master] Revert "Adapt Lexeme to removed EntityPerPage table and services" as per https://phabricator.wikimedia.org/T140890#3263721
gerritbot added a comment.
Change 353892 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/extensions/Wikibase@master] Revert "Drop EntityPerPage" as per https://phabricator.wikimedia.org/T140890#3263721.
https://gerrit.wikimedia.org/r/353892TASK
Lydia_Pintscher added a comment.
We need a longer time to announce this change. I fear we'll need to revert this temporarily until we have made the announcement. We'll talk about the timeline in tomorrow's meeting. Sorry!TASK DETAILhttps://phabricator.wikimedia.org/T140890EMAIL
gerritbot added a comment.
Change 353538 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Adapt Lexeme to removed EntityPerPage table and services
https://gerrit.wikimedia.org/r/353538TASK DETAILhttps://phabricator.wikimedia.org/T140890EMAIL
gerritbot added a comment.
Change 353538 had a related patch set uploaded (by Thiemo Mättig (WMDE); owner: Thiemo Mättig (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Adapt Lexeme to removed EntityPerPage table and services
https://gerrit.wikimedia.org/r/353538TASK
Ladsgroup added a comment.
In T140890#3257769, @WMDE-leszek wrote:
so it drops stuff during the next git pull && php update.php?
One thing, We can't do update.php in production. This will be a #schema-change and DBAs needs to do it. That requires a dedicated phab card and stuff like that (I
Lydia_Pintscher added a comment.
Before we make any change to the live system we need to plan this properly. The assumption that no tool or script relies on this is wrong based on pretty vocal feedback we got.TASK DETAILhttps://phabricator.wikimedia.org/T140890EMAIL
daniel added a comment.
@WMDE-leszek That is essentially it. This is a (potentially) breaking change for tools on labs. According to https://www.wikidata.org/wiki/Wikidata:Stable_Interface_Policy#Stable_Public_APIs, it should be announced four weeks before we deploy it. I think in this case, we
WMDE-leszek added a comment.
Also, I just realized we should have a DB updater that drops the table when update.php is run.
Just wondering as I am somewhat involved in this kind of change for the first time: is there any policy/rule regarding dropping existing DB tables/columns? So we announce
Ladsgroup added a comment.
In T140890#3257245, @daniel wrote:
Good point, should have had a DEPLOY notice in the commit message. Didn't think of that, sorry. Can you tell Lea?
I will let Lea know about it tomorrow :)
Also, I just realized we should have a DB updater that drops the table when
daniel added a comment.
Good point, should have had a DEPLOY notice in the commit message. Didn't think of that, sorry. Can you tell Lea?
Also, I just realized we should have a DB updater that drops the table when update.php is run.TASK DETAILhttps://phabricator.wikimedia.org/T140890EMAIL
gerritbot added a comment.
Change 352544 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Drop EntityPerPage
https://gerrit.wikimedia.org/r/352544TASK DETAILhttps://phabricator.wikimedia.org/T140890EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To:
gerritbot added a comment.
Change 352797 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[operations/puppet@production] Do not make dumps of wb_entity_per_page
https://gerrit.wikimedia.org/r/352797TASK DETAILhttps://phabricator.wikimedia.org/T140890EMAIL
gerritbot added a comment.
Change 352574 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[operations/puppet@production] Do not rebuild or make dumps of wb_entity_per_page
https://gerrit.wikimedia.org/r/352574TASK DETAILhttps://phabricator.wikimedia.org/T140890EMAIL
gerritbot added a comment.
Change 352544 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/extensions/Wikibase@master] Drop EntityPerPage
https://gerrit.wikimedia.org/r/352544TASK DETAILhttps://phabricator.wikimedia.org/T140890EMAIL
daniel added a comment.
@Ladsgroup I see many mentions of EntityPerPag, but no actual logic using it. That was the idea. I hope all these places you found are now just dead wood, and can simply be deleted :)TASK DETAILhttps://phabricator.wikimedia.org/T140890EMAIL
Ladsgroup added a comment.
I think this is the next step. The master is rater heavily relying on EntityPerPage though :/
`
amir@amir-GL552VW:~/Wikibase5$ grep -ir "EntityPerPage" . | wc -l
144
`TASK DETAILhttps://phabricator.wikimedia.org/T140890EMAIL
39 matches
Mail list logo
