[Wikidata-bugs] [Maniphest] [Commented On] T140955: Wikibase\Repo\Store\WikiPageEntityStore::updateWatchlist: Automatic transaction with writes in progress (from DatabaseBase::query (LinkCache::addLin

2016-08-04 Thread jcrespo
jcrespo added a comment. I cannot see this anymore since 23 UTC yesterday. If you can confirm its successful deployment, I will mark this as resolved.TASK DETAILhttps://phabricator.wikimedia.org/T140955EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To:

[Wikidata-bugs] [Maniphest] [Commented On] T140955: Wikibase\Repo\Store\WikiPageEntityStore::updateWatchlist: Automatic transaction with writes in progress (from DatabaseBase::query (LinkCache::addLin

2016-08-03 Thread jcrespo
jcrespo added a comment. Indeed, it continues happening on WMF-servers. As we have the tag #wikimedia-log-errors (a WMF issue rather than a mediawiki or wikidata-only), I would like to keep this open if you are ok with that to check, for example, it does not happen by other unrelated reasons (both

[Wikidata-bugs] [Maniphest] [Commented On] T140955: Wikibase\Repo\Store\WikiPageEntityStore::updateWatchlist: Automatic transaction with writes in progress (from DatabaseBase::query (LinkCache::addLin

2016-08-02 Thread hoo
hoo added a comment. In T140955#2516051, @jcrespo wrote: I will check the logs. We will deploy the fixes this week (with wmf13). The improvements should take effect once the branch hits Wikidata (tomorrow).TASK DETAILhttps://phabricator.wikimedia.org/T140955EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T140955: Wikibase\Repo\Store\WikiPageEntityStore::updateWatchlist: Automatic transaction with writes in progress (from DatabaseBase::query (LinkCache::addLin

2016-08-02 Thread jcrespo
jcrespo added a comment. I will check the logs.TASK DETAILhttps://phabricator.wikimedia.org/T140955EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: jcrespoCc: gerritbot, hashar, aaron, hoo, Lydia_Pintscher, daniel, aude, jcrespo, Aklapper, TerraCodes, greg,

[Wikidata-bugs] [Maniphest] [Commented On] T140955: Wikibase\Repo\Store\WikiPageEntityStore::updateWatchlist: Automatic transaction with writes in progress (from DatabaseBase::query (LinkCache::addLin

2016-08-02 Thread hoo
hoo added a comment. All of @aaron's patches have been merged, can we consider this resolved?TASK DETAILhttps://phabricator.wikimedia.org/T140955EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hooCc: gerritbot, hashar, aaron, hoo, Lydia_Pintscher, daniel,

[Wikidata-bugs] [Maniphest] [Commented On] T140955: Wikibase\Repo\Store\WikiPageEntityStore::updateWatchlist: Automatic transaction with writes in progress (from DatabaseBase::query (LinkCache::addLin

2016-08-02 Thread gerritbot
gerritbot added a comment. Change 301551 merged by jenkins-bot: Avoid use of deadlockLoop() in EntityPerPageTable https://gerrit.wikimedia.org/r/301551TASK DETAILhttps://phabricator.wikimedia.org/T140955EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To:

[Wikidata-bugs] [Maniphest] [Commented On] T140955: Wikibase\Repo\Store\WikiPageEntityStore::updateWatchlist: Automatic transaction with writes in progress (from DatabaseBase::query (LinkCache::addLin

2016-08-01 Thread gerritbot
gerritbot added a comment. Change 301538 merged by jenkins-bot: Remove deadlockLoop() from places with few errors https://gerrit.wikimedia.org/r/301538TASK DETAILhttps://phabricator.wikimedia.org/T140955EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To:

[Wikidata-bugs] [Maniphest] [Commented On] T140955: Wikibase\Repo\Store\WikiPageEntityStore::updateWatchlist: Automatic transaction with writes in progress (from DatabaseBase::query (LinkCache::addLin

2016-07-28 Thread gerritbot
gerritbot added a comment. Change 301551 had a related patch set uploaded (by Aaron Schulz): Avoid use of deadlockLoop() in EntityPerPageTable https://gerrit.wikimedia.org/r/301551TASK DETAILhttps://phabricator.wikimedia.org/T140955EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T140955: Wikibase\Repo\Store\WikiPageEntityStore::updateWatchlist: Automatic transaction with writes in progress (from DatabaseBase::query (LinkCache::addLin

2016-07-27 Thread gerritbot
gerritbot added a comment. Change 301538 had a related patch set uploaded (by Aaron Schulz): Remove deadlockLoop() from places with few errors https://gerrit.wikimedia.org/r/301538TASK DETAILhttps://phabricator.wikimedia.org/T140955EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T140955: Wikibase\Repo\Store\WikiPageEntityStore::updateWatchlist: Automatic transaction with writes in progress (from DatabaseBase::query (LinkCache::addLin

2016-07-27 Thread jcrespo
jcrespo added a comment. This (although it is not the only one) is causing problems with huge sizes on logs. I would suggest to either disable the logging or sample them or all logs will be broken! Then you can continue fixing it in the same way before put it back to error level.TASK

[Wikidata-bugs] [Maniphest] [Commented On] T140955: Wikibase\Repo\Store\WikiPageEntityStore::updateWatchlist: Automatic transaction with writes in progress (from DatabaseBase::query (LinkCache::addLin

2016-07-22 Thread daniel
daniel added a comment. In T140955#2487188, @greg wrote: It was on the MediaWiki fatals dashboard in logstash :) Interesting - why, if these were warnings? Or are DB warnings considered fatal for some reason?TASK DETAILhttps://phabricator.wikimedia.org/T140955EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T140955: Wikibase\Repo\Store\WikiPageEntityStore::updateWatchlist: Automatic transaction with writes in progress (from DatabaseBase::query (LinkCache::addLin

2016-07-22 Thread daniel
daniel added a comment. @aaron If I interpret what you say correctly, that means that we should not use automatic transactions in web requests at all, at least none that write. I suggest to have a larger discussion about the appropriate use of transactions, on wikitech-l or as an RFC. In the

[Wikidata-bugs] [Maniphest] [Commented On] T140955: Wikibase\Repo\Store\WikiPageEntityStore::updateWatchlist: Automatic transaction with writes in progress (from DatabaseBase::query (LinkCache::addLin

2016-07-22 Thread aaron
aaron added a comment. Premature commits like this make multi-DB transactions less safe. Only Job/DeferrableUpdate/Maintenance code should be flushing transactions. If something needs its own transaction it should use some sort of deferred update.TASK

[Wikidata-bugs] [Maniphest] [Commented On] T140955: Wikibase\Repo\Store\WikiPageEntityStore::updateWatchlist: Automatic transaction with writes in progress (from DatabaseBase::query (LinkCache::addLin

2016-07-22 Thread greg
greg added a comment. It was on the MediaWiki fatals dashboard in logstash :)TASK DETAILhttps://phabricator.wikimedia.org/T140955EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gregCc: hashar, aaron, hoo, Lydia_Pintscher, daniel, aude, jcrespo, Aklapper,

[Wikidata-bugs] [Maniphest] [Commented On] T140955: Wikibase\Repo\Store\WikiPageEntityStore::updateWatchlist: Automatic transaction with writes in progress (from DatabaseBase::query (LinkCache::addLin

2016-07-22 Thread daniel
daniel added a comment. Sadly, deadlockLoop doesn't tell us what called it or what it is trying to do. Knowing which transaction was still open is nice, but knowing what tried to open another one would be helpfull.TASK DETAILhttps://phabricator.wikimedia.org/T140955EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T140955: Wikibase\Repo\Store\WikiPageEntityStore::updateWatchlist: Automatic transaction with writes in progress (from DatabaseBase::query (LinkCache::addLin

2016-07-21 Thread greg
greg added a comment. Last hour: F4295127: Selection_130.png What changed at ~19:26?TASK DETAILhttps://phabricator.wikimedia.org/T140955EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gregCc: hoo, Lydia_Pintscher, daniel, aude, jcrespo, Aklapper, TerraCodes,

[Wikidata-bugs] [Maniphest] [Commented On] T140955: Wikibase\Repo\Store\WikiPageEntityStore::updateWatchlist: Automatic transaction with writes in progress (from DatabaseBase::query (LinkCache::addLin

2016-07-21 Thread jcrespo
jcrespo added a comment. Since 10:30 the number of log errors has increased to 2000/hour, probably related to Wikidata API requests by bots.TASK DETAILhttps://phabricator.wikimedia.org/T140955EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: jcrespoCc:

[Wikidata-bugs] [Maniphest] [Commented On] T140955: Wikibase\Repo\Store\WikiPageEntityStore::updateWatchlist: Automatic transaction with writes in progress (from DatabaseBase::query (LinkCache::addLin

2016-07-20 Thread greg
greg added a comment. Similar errors also showing up frequently now: DatabaseBase::deadlockLoop: Automatic transaction with writes in progress (from DatabaseBase::query (LinksUpdate::acquirePageLock)), performing implicit commit! and DatabaseBase::deadlockLoop: Automatic transaction with writes