gerritbot added a comment.
Change 334343 merged by jenkins-bot:
Fix minor pattern matching issues in WikiTextPropertyOrderProvider
https://gerrit.wikimedia.org/r/334343TASK DETAILhttps://phabricator.wikimedia.org/T150788EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailprefere
gerritbot added a comment.
Change 334343 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Fix minor pattern matching issues in WikiTextPropertyOrderProvider
https://gerrit.wikimedia.org/r/334343TASK DETAILhttps://phabricator.wikimedia.org/T150788EMAIL PREFERENCEShttps://phabricator.wiki
thiemowmde added a comment.
Receiving comments like this on a closed ticket is rare. Thank you very much, @Esc3300! \o/TASK DETAILhttps://phabricator.wikimedia.org/T150788EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: Esc3300, gerritbot, Pasleim
Esc3300 added a comment.
Works fine, better than expected. I think it's good that statements only display in an re-ordered way once the page reloaded.
Good work. Thanks!TASK DETAILhttps://phabricator.wikimedia.org/T150788EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailprefer
gerritbot added a comment.
Change 327001 merged by jenkins-bot:
Apply property ordering in StatementGroupListView
https://gerrit.wikimedia.org/r/327001TASK DETAILhttps://phabricator.wikimedia.org/T150788EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowm
gerritbot added a comment.
Change 326986 merged by jenkins-bot:
Fix PropertyOrderProvider type hint in top level factory
https://gerrit.wikimedia.org/r/326986TASK DETAILhttps://phabricator.wikimedia.org/T150788EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: t
gerritbot added a comment.
Change 327001 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Apply property ordering in StatementGroupListView
https://gerrit.wikimedia.org/r/327001TASK DETAILhttps://phabricator.wikimedia.org/T150788EMAIL PREFERENCEShttps://phabricator.wikimedia.org/setting
gerritbot added a comment.
Change 326986 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Fix PropertyOrderProvider type hint in top level factory
https://gerrit.wikimedia.org/r/326986TASK DETAILhttps://phabricator.wikimedia.org/T150788EMAIL PREFERENCEShttps://phabricator.wikimedia.org/
Lydia_Pintscher added a comment.
If there is anything missing for this to be picked up next week please comment.TASK DETAILhttps://phabricator.wikimedia.org/T150788EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lydia_PintscherCc: Pasleim, thiemowmde, Aklapper
Lydia_Pintscher added a comment.
Input based on today's meeting:
documentation of format is needed
when input for the parser is garbage just returning an empty list of properties
when the list is empty return the statements in unordered order
separating the statements into section comes first. Th
thiemowmde added a comment.
The current order is in http://www.wikidata.org/wiki/MediaWiki:Wikibase-SortedProperties.
These are the formats I want a parser (the current one is in WikiTextPropertyOrderProvider) to accept:
== Have sections (they are just ignored) ==
* P1
* P1 (foo)
* [[Property:P1]
11 matches
Mail list logo