aude added a comment.
Would this link to Special:EntityPage or would the EntityTitleLookup have a way to fetch entity namespace mappings from the repo(s) instead of configuring in the client? or other way to resolve the links? Not sure we will always have a corresponding namespace for each entity
gerritbot added a comment.
Change 358365 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/extensions/Wikibase@master] Link to Special:EntityData instead of getting namespace settings in RepoLinker
https://gerrit.wikimedia.org/r/358365TASK DETAILhttps://phabricato
Ladsgroup added a comment.
The patch still needs some work but I will get it done soon.TASK DETAILhttps://phabricator.wikimedia.org/T153769EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: LadsgroupCc: gerritbot, aude, Aklapper, Jakob_WMDE, WMDE-leszek, Lydia_Pi
daniel added a comment.
Patch looks good, needs manual verification.TASK DETAILhttps://phabricator.wikimedia.org/T153769EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, danielCc: gerritbot, aude, Aklapper, Jakob_WMDE, WMDE-leszek, Lydia_Pintscher, da
Ladsgroup added a comment.
@daniel:
F8450066: image.pngTASK DETAILhttps://phabricator.wikimedia.org/T153769EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: LadsgroupCc: gerritbot, aude, Aklapper, Jakob_WMDE, WMDE-leszek, Lydia_Pintscher, daniel, GoranSMilovanov
gerritbot added a comment.
Change 358365 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Link to Special:EntityPage instead of getting namespace settings in RepoLinker
https://gerrit.wikimedia.org/r/358365TASK DETAILhttps://phabricator.wikimedia.org/T153769EMAIL PREFERENCEShttps://ph
WMDE-leszek added a comment.
Result maybe be desired in the end but with https://gerrit.wikimedia.org/r/358365 RepoLinker still does not use EntityTitleLookup, so I was not sure if this is now done, or is there still some work left.
If you say it's now all done, then cool!TASK DETAILhttps://phabric
Ladsgroup added a comment.
I was about to comment and say "feel free to reopen if you think we need the implementation" I agree it'd be nice but not sure if we should do it now.TASK DETAILhttps://phabricator.wikimedia.org/T153769EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emai
