gerritbot added a comment.
Change 385427 merged by jenkins-bot:
[wikidata/query/gui@master] Allow passing options to Result Views
https://gerrit.wikimedia.org/r/385427TASK DETAILhttps://phabricator.wikimedia.org/T155973EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferen
gerritbot added a comment.
Change 385427 had a related patch set uploaded (by Jonas Kress (WMDE); owner: Jonas Kress (WMDE)):
[wikidata/query/gui@master] Allow passing options to Result Views
https://gerrit.wikimedia.org/r/385427TASK DETAILhttps://phabricator.wikimedia.org/T155973EMAIL PREFERENCES
Yair_rand added a comment.
@Lucas_Werkmeister_WMDE Seems reasonable. Syntax issues and inconsistency between query metadata types can be resolved later.TASK DETAILhttps://phabricator.wikimedia.org/T155973EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Yair_ran
Lucas_Werkmeister_WMDE added a comment.
@Jonas just a slight change – I’d prefer standard JSON (not sure if you had something different in mind or the differences are only accidental):
#defaultView:Graph{"arrows":"red", "layout":"hierarchical", "otherOption":"Foo"}
@Yair_rand templates have the s
Yair_rand added a comment.
In T155973#3366705, @Jonas wrote:
So I would like to implement something like:
#defaultView:Graph{arrows:'red', layout:'hierarchical', othterOption:'Foo'}
Which would allow you to pass options to default view.
One issue with that: How would it handle settings spannin
Jonas added a comment.
So I would like to implement something like:
#defaultView:Graph{arrows:'red', layout:'hierarchical', othterOption:'Foo'}
Which would allow you to pass options to default view.TASK DETAILhttps://phabricator.wikimedia.org/T155973EMAIL PREFERENCEShttps://phabricator.wikimedia.
Smalyshev added a comment.
Don't have any objections to that, but I guess we need to specify which options we want, and document them on wiki too.TASK DETAILhttps://phabricator.wikimedia.org/T155973EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: S
