[Wikidata-bugs] [Maniphest] [Commented On] T159718: Evaluate if it is possbile to add an empty column for full entity ID to wb_terms without affecting wikidata.org users

2017-03-07 Thread Marostegui
Marostegui added a comment. In T159718#3079126, @WMDE-leszek wrote: Thank you @jcrespo and @Marostegui for your comments. I am happy I asked and you made me sketch the whole big plan. As you might have realized , I am really not a DB expert. Therefore some not smart things in the plan :) That's

[Wikidata-bugs] [Maniphest] [Commented On] T159718: Evaluate if it is possbile to add an empty column for full entity ID to wb_terms without affecting wikidata.org users

2017-03-06 Thread Marostegui
Marostegui added a comment. In T159718#3077513, @jcrespo wrote: Populate new column at the same time than the current one (ideally with code, but if you do not want to touch code, it can even be made with a trigger) + populate old values with maintenance If possible, I would avoid using tr

[Wikidata-bugs] [Maniphest] [Commented On] T159718: Evaluate if it is possbile to add an empty column for full entity ID to wb_terms without affecting wikidata.org users

2017-03-06 Thread jcrespo
jcrespo added a comment. So the comments: do not defer the creation of the indexes- those are extra alter tables and do no make things easier in any way- just create the indexes from the start- assuming they will be used. Renaming columns is a big no- specially to an already existent name. Always

[Wikidata-bugs] [Maniphest] [Commented On] T159718: Evaluate if it is possbile to add an empty column for full entity ID to wb_terms without affecting wikidata.org users

2017-03-06 Thread jcrespo
jcrespo added a comment. Ok, now I have some comments against that method, logistically, I am at a meeting, let me finish it and I will have some time to properly explain myself (nothing against the spirit of the changes, I would just do it in a different way, if code can handle it).TASK DETAILhttp

[Wikidata-bugs] [Maniphest] [Commented On] T159718: Evaluate if it is possbile to add an empty column for full entity ID to wb_terms without affecting wikidata.org users

2017-03-06 Thread WMDE-leszek
WMDE-leszek added a comment. Oh, sorry, I missed few comments while typing mine :) It seems to me @Marostegui and @jcrespo that it would better to wait until DC switch over, we can plan with that. We're completely fine with waiting until April. I think you should add the full plan here ASAP, ev

[Wikidata-bugs] [Maniphest] [Commented On] T159718: Evaluate if it is possbile to add an empty column for full entity ID to wb_terms without affecting wikidata.org users

2017-03-06 Thread jcrespo
jcrespo added a comment. Depending on the answer to this, we will plan further steps. I think you should add the full plan here ASAP, even if it is not 100% clear or decided, otherwise we may be adding steps to the process and make it unnecessarily long. E.g. if you plan to add an index later, it

[Wikidata-bugs] [Maniphest] [Commented On] T159718: Evaluate if it is possbile to add an empty column for full entity ID to wb_terms without affecting wikidata.org users

2017-03-06 Thread WMDE-leszek
WMDE-leszek added a comment. Thanks @Marostegui for infromation so far. And yes, @jcrespo is right. We first want to get an OK from you if this is a right way for us to go. I've changed task title slightly. Sorry for not being clear. So yes, we wouldn't have a code writing/reading to a new column

[Wikidata-bugs] [Maniphest] [Commented On] T159718: Evaluate if it is possbile to add an empty column for full entity ID to wb_terms without affecting wikidata.org users

2017-03-06 Thread jcrespo
jcrespo added a comment. If we depool the slaves we should be fine, shouldn't we? And if we use the DC switchover to alter the masters we'd also get rid of that issue? Hey, don't tell me, tell @WMDE-leszek, and see if he is ok with that schedule. :-)TASK DETAILhttps://phabricator.wikimedia.org/T15

[Wikidata-bugs] [Maniphest] [Commented On] T159718: Evaluate if it is possbile to add an empty column for full entity ID to wb_terms without affecting wikidata.org users

2017-03-06 Thread Marostegui
Marostegui added a comment. In T159718#3076201, @jcrespo wrote: Evaluate if it is feasible to add such an "empty" column without making Wikidata readonly. we can probably do it How certain are you? In my experience, the biggest blocker on production is not the size, but how busy the table is.

[Wikidata-bugs] [Maniphest] [Commented On] T159718: Evaluate if it is possbile to add an empty column for full entity ID to wb_terms without affecting wikidata.org users

2017-03-06 Thread jcrespo
jcrespo added a comment. Evaluate if it is feasible to add such an "empty" column without making Wikidata readonly. we can probably do it How certain are you? In my experience, the biggest blocker on production is not the size, but how busy the table is. That would create metadata locking issues